Mike Brady and GitHub
cbbfe83f3b
Update RELEASENOTES.md
2019-02-19 11:18:13 +00:00
Mike Brady and GitHub
78685b8528
Big update to audio_jack.c and other stuff
2019-02-19 11:13:17 +00:00
Mike Brady and GitHub
ec84f0fd98
Merge pull request #809 from nettings/development
...
Modify audio_jack.c to use native jack lockless buffers and to offer auto connect facilities. Overall, the backend is now written more in the idiom of jack audio.
Many thanks to [Jörn Nettingsmeier](https://github.com/nettings ).
2019-02-19 11:12:03 +00:00
Mike Brady and GitHub
10edce3452
Update configure.ac
...
Add `-u` option and improve compatibility with older `alsa` libraries.
2019-02-17 14:42:42 +00:00
Mike Brady and GitHub
55001a2ab9
Update RELEASENOTES.md
2019-02-17 14:41:21 +00:00
Mike Brady
72973631a1
Merge branch 'unstable' into development
2019-02-17 14:27:48 +00:00
Mike Brady
c14b54053b
Merge branch 'transit' into development
2019-02-17 14:27:09 +00:00
Mike Brady
2758312679
use CLOCK_REALTIME instead of CLOCK_MONOTONIC is the alsa library is older than 1.0.28.
2019-02-17 14:26:14 +00:00
Mike Brady
4d2bef33c2
Merge branch 'dangerous' into unstable
2019-02-17 14:22:51 +00:00
Mike Brady
00be8bc2a6
fix the ability to give attenation priority to hardware or software, set the default to software
2019-02-17 14:10:45 +00:00
Mike Brady
a8038c15c9
remove some diagnostics and add in a comment -- using CLOCK_REALTIME with alsa libraries before 1.0.28
2019-02-17 14:00:10 +00:00
Mike Brady
2c8d1dfc71
use CLOCK_REALTIME if alsa is earlier than 1.0.28
2019-02-17 13:52:38 +00:00
Mike Brady
dc8483db14
try using CLOCK_REALTIME -- a bad hack
2019-02-17 13:23:34 +00:00
Mike Brady
9abb349a1d
+1
2019-02-17 13:13:44 +00:00
Mike Brady
984fc90e5c
Check further on stall timing
2019-02-17 13:00:38 +00:00
Mike Brady
e1efc6e45a
add, but don't use, a check to see if alsa uses CLOCK_MONOLITHIC (or, presumably, otherwise CLOCK_REALTIME)
2019-02-17 12:32:37 +00:00
Mike Brady
d4d1aece90
Merge branch 'unstable' into development
2019-02-17 10:14:01 +00:00
Mike Brady
cae8bc0f3c
Stop increasing the debugging verbosity when a watchdog timeout occurs
2019-02-17 10:13:48 +00:00
Jörn Nettingsmeier
e59da78348
Fix segfault due to missing null check...
2019-02-16 21:26:32 +00:00
Jörn Nettingsmeier
b361ad84fc
NOP. Reformat code consistently, improve comments.
2019-02-16 19:57:28 +00:00
Mike Brady
e2163e2c80
Merge branch 'unstable' into development
2019-02-16 19:46:39 +00:00
Mike Brady
405a028f33
quieten some exiting debug messages
2019-02-16 19:44:25 +00:00
Mike Brady
fce6b5137e
Add a new command line option: -u to send logs to STDERR.
2019-02-16 19:32:13 +00:00
Jörn Nettingsmeier
31bbd743a5
Use appropriate warn/inform/debug levels.
2019-02-16 19:01:37 +00:00
Jörn Nettingsmeier
97370d8bce
Actually implement auto-connection, and document it.
2019-02-16 18:45:51 +00:00
Mike Brady
9f91bd2d98
fix tinysvcmdns issues reported in CVE-2017-12130
2019-02-16 17:51:47 +00:00
Jörn Nettingsmeier
4f39e0d830
Move away from hardcoded channels. Centralizes information, simplifies the code, and might be helpful for future surround support.
2019-02-16 16:09:29 +00:00
Jörn Nettingsmeier
bd5cfd3583
forgot to add new option autoconnect_pattern to default conf and common.h
2019-02-16 16:08:40 +00:00
Jörn Nettingsmeier
28ea6972af
Add dummy option jack_autoconnect_option.
2019-02-16 15:33:29 +00:00
Mike Brady
617d4bc228
Turn up debug level to 3 when too long a silence occurs
2019-02-16 14:56:34 +00:00
Mike Brady
0efe25eb1b
Merge branch 'unstable' into development
2019-02-16 14:07:21 +00:00
Mike Brady
14aa9d4180
Quieten a very noisy mutex debug message
2019-02-16 14:06:40 +00:00
Jörn Nettingsmeier
5c1769f87c
Partly revert c00199d664, some 0 are actually longs. It's late :(
2019-02-16 02:28:59 +00:00
Jörn Nettingsmeier
3a4deb38a2
Declare all file-global variables as static, remove unused thread pointer.
2019-02-16 02:26:36 +00:00
Jörn Nettingsmeier
90f24c62df
Add myself to (C)omplain-to tag :-D
2019-02-16 02:20:21 +00:00
Jörn Nettingsmeier
c00199d664
Always use NULL instead of 0 for pointers for clarity.
2019-02-16 02:15:35 +00:00
Jörn Nettingsmeier
95246dcd84
Use more conservative JACK client name (a simple token without whitespace).
2019-02-16 02:05:05 +00:00
Jörn Nettingsmeier
4751a4e1bc
Move jack base latency computation out of delay() into graph() to save cycles.
2019-02-16 02:03:15 +00:00
Jörn Nettingsmeier
bda8b99cda
Add graph reorder callback, this is where we now compute the output latencies.
2019-02-16 01:53:49 +00:00
Jörn Nettingsmeier
f1ba07ff2b
Make callback names simpler and more consistent. Always use &callback in setter functions to make the function pointer explicit, even though it's not syntactically necessary.
2019-02-16 01:02:30 +00:00
Jörn Nettingsmeier
0009fcddf6
Revert "Remove client_mutex, since JACK opening and closing is now single-threaded."
...
That was a bit too optimistic, I guess. Must understand more about the rest of shairport-sync.
Fixes spurious segfault on program termination with CTRL-C that does not happen in gdb :)
This reverts commit 8e46c727d5 .
2019-02-16 00:53:04 +00:00
Jörn Nettingsmeier
55797c8387
Remove unused headers. <getopt.h> will come back once we implement command line parsing, the others may well be gone for good.
2019-02-15 23:51:11 +00:00
Jörn Nettingsmeier
8e46c727d5
Remove client_mutex, since JACK opening and closing is now single-threaded.
2019-02-15 23:45:12 +00:00
Jörn Nettingsmeier
2826756938
Remove global client_is_open flag, always execute former conditional statements. We know we're open.
2019-02-15 23:43:00 +00:00
Jörn Nettingsmeier
753cc07777
Remove optional is_running() API call, since it doesn't do anything useful.
...
We are either already running along just fine, or we are throughly dead.
2019-02-15 23:39:53 +00:00
Jörn Nettingsmeier
1906bfd727
Remove indirections open_if_needed() and close(), can now be integrated into API calls init and deinit.
2019-02-15 23:38:01 +00:00
Jörn Nettingsmeier
ec68c677e0
Remove jack_stop() function pointer from API struct, since it does nothing. Checked, no segfault on program termination.
2019-02-15 23:17:50 +00:00
Jörn Nettingsmeier
8c5e85c87c
Remove audio_client_disconnect option. This is not good behaviour for a JACK client, and adds nothing.
2019-02-15 23:14:31 +00:00
Jörn Nettingsmeier
edd699dfbc
Remove auto_client_open_interval option, always open JACK connection immediately or fail.
...
Remove client creation thread and wrapper function.
2019-02-15 23:08:04 +00:00
Jörn Nettingsmeier
63b3381a27
Fail early and fail deadly (AFAIK there is no fallback to another audio backend, so any severe JACK issue should be fatal).
2019-02-15 22:59:31 +00:00