Remove audio_client_disconnect option. This is not good behaviour for a JACK client, and adds nothing.

audio_jack.c

@@ -211,10 +211,6 @@ int jack_init(__attribute__((unused)) int argc, __attribute__((unused)) char **a
     if (config_lookup_string(config.cfg, "jack.client_name", &str)) {
       config.jack_client_name = (char *)str;
     }
-
-    /* See if we should close the client at then end of a play session. */
-    config_set_lookup_bool(config.cfg, "jack.auto_client_disconnect",
-                           &config.jack_auto_client_disconnect);
   }
 
   if (config.jack_client_name == NULL)
@@ -251,8 +247,6 @@ void jack_start(__attribute__((unused)) int i_sample_rate,
 
 void jack_stop(void) {
   // debug(1, "jack stop");
-  if (config.jack_auto_client_disconnect)
-    jack_close();
 }
 
 int jack_is_running() {

common.h

@@ -233,8 +233,6 @@ typedef struct {
                                           // debugging. Currently audio packets only...
 #ifdef CONFIG_JACK
   char *jack_client_name;
-  int jack_auto_client_disconnect;    // will disconnect from the server on end of session if set,
-                                      // normally clear.
 #endif
 
 } shairport_cfg;

scripts/shairport-sync.conf

@@ -109,7 +109,6 @@ pa =
 jack =
 {
 //	client_name = "Shairport Sync"; //Set this to the name of the client that should appear in "Connections" when Shairport Sync is active.
-//	auto_client_disconnect = "no"; // Set this to "yes" to close the jack client automatically at then end of a play session. Default is no -- the client stays connected.
 };
 
 // Parameters for the "pipe" audio back end, a back end that directs raw CD-style audio output to a pipe. No interpolation is done.