Mike Brady
e8a92d3c3b
ensure alsa mixer is initialised before trying to set volume. Normalise the 'pvol' volume mesasages to the hardware devices' maximum volume when using combined hardware and software attenuation.
2019-09-10 13:03:54 +01:00
Mike Brady and GitHub
677684de04
Bug fixes
...
Fixes an error whereby the 'pvol' volume metadata was no longer sent if Shairport Sync was configured to ignore volume control information coming from the audio source. Addresses issue #903 .
Fixes a compilation error if including the MQTT client.
2019-09-10 10:08:47 +01:00
Mike Brady and GitHub
15d6338adf
Update RELEASENOTES-DEVELOPMENT.md
2019-09-10 10:06:54 +01:00
Mike Brady
b59dd4229e
fix regression no volume metadata was being sent if configured to ignore volume control -- issue #903 .
2019-09-10 09:56:25 +01:00
Mike Brady
c7a290c36a
remove a call to a non-existent terminate_mqtt function in the clean-up.
2019-09-10 09:29:21 +01:00
Mike Brady
d734b7e71d
add volume-up and volume-down to the dbus test client. Quieten a debug message.
2019-09-08 17:43:07 +01:00
Mike Brady
2b980ff2a8
make dbus interface set more quickly an AdvancedRemoteControlAvailable to false when going from an iTunes to an AirPlay service.
2019-09-08 17:26:06 +01:00
Mike Brady
185000d0bd
Remove some old code and clean up the exit cleanup function so that it works better with libdaemon and its parent and child processes
2019-09-08 17:03:36 +01:00
Mike Brady
839c778a7c
Only send shuffle commands if a change is necessary
2019-09-08 15:53:52 +01:00
Mike Brady and GitHub
89487c16bb
Update RELEASENOTES-DEVELOPMENT.md
2019-09-04 20:40:23 +01:00
Mike Brady and GitHub
874dfefc4c
Update RELEASENOTES-DEVELOPMENT.md
2019-09-04 20:39:35 +01:00
Mike Brady
daab7a634c
Clean up the scanning code for detecting either a standard DACP server or an advanced DACP server.
2019-09-04 20:24:34 +01:00
Mike Brady and GitHub
2965900b6c
Update RELEASENOTES-DEVELOPMENT.md
2019-09-04 09:47:20 +01:00
Mike Brady
cf70c12392
avoid a compilation warning when the dacp stuff isn't needed
2019-09-04 09:37:48 +01:00
Mike Brady
4f09a3299e
Fix occasional crashing bug in Ububntu 14.04 (sometimes triggered by DHCP renewal and Avahi / dbus issues) by removing second avahi threaded poll and an unnecessary avahi service client (very sparse Avahi documentation), also remove obselete SIG setup code.
2019-09-04 09:24:34 +01:00
Mike Brady
a3a1884f71
Remove obselete SIG setup and action stuff
2019-09-04 09:19:44 +01:00
Mike Brady
5c90204ecf
Merge branch 'development' of https://github.com/mikebrady/shairport-sync into development
...
Forgot.
2019-09-03 10:48:27 +01:00
Mike Brady
4d6f5b4844
Remove second avahi threaded poll, remove service client.
2019-09-03 10:47:10 +01:00
Mike Brady and GitHub
8c940516a9
Update RELEASENOTES-DEVELOPMENT.md
2019-08-29 12:21:15 +01:00
Mike Brady and GitHub
9aa5fa90f9
Update RELEASENOTES-DEVELOPMENT.md
2019-08-29 12:19:51 +01:00
Mike Brady
c1f6e2ea18
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
...
Fix metadata issues with the dbus and the MPRIS interfaces -- handle missing artwork properly, make the 'available' property more resilient.
2019-08-29 11:56:13 +01:00
Mike Brady
86b6d7bfff
Squashed commit of the following:
...
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
Recognise situation where a track has no artwork properly.
Less likely to drop the 'availabile' property.
Always output the full metadata whenever any part of it has changed.
Metadata coming from dacp is now incorporated,
2019-08-29 11:47:49 +01:00
Mike Brady and GitHub
d846bc53be
Update RELEASENOTES-DEVELOPMENT.md
2019-08-28 09:07:41 +01:00
Mike Brady and GitHub
9fdfa5c235
Update RELEASENOTES-DEVELOPMENT.md
2019-08-28 09:07:13 +01:00
Mike Brady and GitHub
701141680d
Merge pull request #898 from Angus71/alac_a_fmtp_seg_fault
...
Fixes a potential crash when an incomplete `fmtp` parameter set is sent by the requesting client.
2019-08-28 09:00:12 +01:00
Mike Brady and GitHub
7f2b437318
Merge pull request #887 from henriknil/early_version_usage
...
Return EXIT_WITH_SUCCESS on early exit on version (`–version` or `-V`) and help (`–help` or `-h`) arguments.
2019-08-28 08:55:14 +01:00
Angus71
bf4bd8ef04
Clean up
2019-08-25 09:50:40 +02:00
Angus71
333e3904e7
Fixed seg. fault with ALAC and incomplete a:fmtp
2019-08-24 22:02:33 +02:00
Henrik Nilsson
14de9e27ab
Return success on version and help argument
...
It's not a failure to print version or usage, so use return code
success.
2019-08-01 10:16:37 +02:00
Henrik Nilsson
2e7e5b6856
Check help and version argument early
...
Check for the help and version arguments makes sure that it's
always possible to get the version and usage even if there are
issues in other parts of the code.
2019-08-01 10:16:37 +02:00
Mike Brady and GitHub
040a5915e3
Merge pull request #885 from bootc/development
...
More typo fixes across the tree.
2019-07-27 09:53:33 +02:00
Chris Boot
b9cf91b2bb
More typo fixes across the tree
...
Previously I have made spelling changes as caught by Debian's lintian
tool, which has a short list of common misspellings that it tests for.
This time I decided to run codespell against the source and fix all the
obvious problems it came up with. It also uses a list of misspellings
but it's much larger than lintian's, but also has some false positives
so I went over the list by hand.
The command I used to do check the source was:
git ls-tree -rz --name-only HEAD | xargs -0 codespell -L minimise,errorstring
2019-07-27 00:05:38 -03:00
Mike Brady and GitHub
addc744bfa
Update RELEASENOTES-DEVELOPMENT.md
2019-07-24 08:51:55 +02:00
Mike Brady
336e1bb1c3
remove some detritus
2019-07-22 13:34:35 +01:00
Mike Brady
e6bd5b1556
Fix a bug that sometimes caused a crash when a service name was specified in the configuration file. Some other minor changes.
2019-07-21 08:52:27 +01:00
Mike Brady
175ae0a650
Fix a bug that sometimes caused a crash when a service name was specified in the configuration file. The fix was to be more systematic in allocating and deallocating memory for termporary strings. Thanks to Chris Boot, Ari Sovijarvi and Jeroen Massar for the bug report. Fixes Debian Bug report #925577 .
...
Allow the rtsp_listen_loop to exit if the RTSP port (usually port 5000) is not available. This allows the system to exit cleanly rather than abort.
2019-07-21 09:06:37 +02:00
Mike Brady and GitHub
1dd0d82836
Update README.md
2019-07-05 10:09:50 +01:00
Mike Brady and GitHub
d78528a59e
Update README.md
2019-07-05 09:20:43 +01:00
Mike Brady
7d6b52edd4
Expose some of the settings used in the disable_standby_mode and tidy up some of the silence-generating code.
2019-06-20 10:53:57 +01:00
Mike Brady
a8faacd3fc
Expose some of the settings used in the disable_standby_mode.
...
Specifically, firstly, the disable_standby_mode_silence_threshold, which is the
amount of audio in the output device's hardware buffer. It should normally
be close to the value givein in the audio_backend_buffer_desired_length_in_seconds
setting. If it drops to this value, silence is added to the buffer to prevent
the output device from becoming idle.
Secondly, the disable_standby_mode_silence_scan_interval is the time between checks
of the output device's hardware buffer.
The code for generating frames of possibly-dithered silence has been simplified.
2019-06-20 10:45:27 +01:00
Mike Brady
c8b0be30b4
find . \( -name \*.cpp -or -name \*.h -or -name \*.c \) -exec clang-format -i -style='{BasedOnStyle: llvm, IndentWidth: 2, ColumnLimit: 100}' '{}' \;
2019-06-19 19:06:54 +01:00
Mike Brady and GitHub
7fc977d8d3
Change comments for use_precision_timing
2019-06-17 22:44:12 +01:00
Mike Brady and GitHub
55488ad24c
Update RELEASENOTES-DEVELOPMENT.md
2019-06-17 22:30:44 +01:00
Mike Brady and GitHub
34b96729a2
Refine the precision timing code
...
Only allow it if the output device is a hardware device
2019-06-17 22:27:03 +01:00
Mike Brady and GitHub
1ca9226242
Update audio_alsa.c
2019-06-17 22:25:47 +01:00
Mike Brady
7013b0cc3d
refine the selection of precision timing to be allowed only if the device is a real hardware device
2019-06-17 19:43:23 +01:00
Mike Brady
9199bf24dd
fix the detection of the availability of precision timing information -- actuall, renable it
2019-06-17 10:38:20 +01:00
Mike Brady
a46c761aa6
make snd_pcm_recover silent when the debug level is 0, not the other way around, duh.
2019-06-17 10:04:23 +01:00
Mike Brady
65abca2562
change the threshold for turning off disable standby mode to more than 40 underruns in the first 100 writes.
2019-06-17 09:47:56 +01:00
Mike Brady
cd9982c43b
if disable_standby_mode is enabled, disable if if more than 20 underruns occur for 50 silence buffers at the start.
2019-06-17 09:39:04 +01:00