Commit Graph
852 Commits
Author SHA1 Message Date
Jörg Krause da1af7da2c Fix missing header include for waitpid 2015-07-30 08:21:36 +02:00
Jörg Krause 3efe2302d0 Fix segfault with gcc 5.x 2015-07-30 08:18:15 +02:00
Mike Brady 94025d4939 Bump bug fix number 2015-05-28 16:44:36 +01:00
Mike Brady 7e403325bf Update RELEASENOTES.md 2015-05-28 16:43:15 +01:00
Mike Brady fc169382ed Merge pull request #78 from joerg-krause/master
Fix segfault with musl libc – allocate the player thread enough stack space.
2015-05-28 16:38:05 +01:00
Jörg Krause 8a122426c6 Fix redirection of incorrect system headers
The POSIX correct header include is `<poll.h>` [1] and `<signal.h>`

The glibc silently redirects these incorrect includes, musl libc prints
a warning:
  #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
  #warning redirecting incorrect #include <sys/signal.h> to <signal.h>

[1]
http://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.h.html

[2]
http://pubs.opengroup.org/onlinepubs/7908799/xsh/signal.h.html
2015-05-28 09:54:46 +02:00
Jörg Krause e12d7ad23e Fix segfault with musl libc
shairport-sync crashes on musl libc when accessing the `statistics` array in
`player_thread_func()`. This array is quite large (60128 bytes) and the data
for this thread exceed the the default stack size on musl libc of 80k [1].

Safe and portable programs should not depend upon the default stack limit, but
instead, explicitly allocate enough stack for each thread by using the
pthread_attr_setstacksize routine [2].

So, lets set the stack size for the `player_thread` to 128k. A follow-up patch
may set the stack sizes for the other threads, too. The difficulty here is to
decide how much memory to allocate for the stack.

[1]
http://wiki.musl-libc.org/wiki/Functional_differences_from_glibc#Thread_stack_size

[2]
https://computing.llnl.gov/tutorials/pthreads/#Stack
2015-05-28 09:10:59 +02:00
Mike Brady 4b3151f84e Update info about packages 2015-05-17 11:37:29 +01:00
Mike Brady 66b1495674 Remove development note from master branch, duh. 2015-05-08 18:40:58 +01:00
Mike Brady 921ebf0d79 Add note about switching to the development branch 2015-05-08 18:36:09 +01:00
Mike Brady 5786daf4f0 Update man link 2015-05-08 17:11:10 +01:00
Mike Brady 83f92b2255 Rephrase active branch stuff. 2015-05-06 18:39:18 +01:00
Mike Brady b0462cabb8 Update ref to Arch Linux package. 2015-05-06 18:36:57 +01:00
Mike Brady 75b8c5c9aa Move to "master" and "development" branches. 2015-04-25 17:14:36 +01:00
Mike Brady 45ab13499d Change branch names...
to "master" and "development"
2015-04-25 17:07:10 +01:00
Mike Brady 0c23ed235a Add not about forked daapd latency. 2015-04-21 15:26:00 +01:00
Mike Brady 60d97c4272 Update note 2015-04-20 21:41:27 +01:00
Mike Brady 266cfb7d6b Make 2.2.3 a Release 2015-04-20 21:32:34 +01:00
Mike Brady 44ce5df9ae Update RELEASENOTES.md 2015-04-20 18:39:41 +01:00
Mke Brady 9bcc6a5bac Add libcrypto -- needed for Arch Linux build. 2015-04-20 18:36:46 +01:00
Mike Brady f0576d1dfe Fix typo. 2015-04-19 11:27:25 +01:00
Mike Brady e7ee5da18d New bugfix noted. 2015-04-19 11:22:44 +01:00
Mike Brady a56207b2ce Merge pull request #70 from sdigit/2.2
Fix compiler warnings
2015-04-19 09:48:38 +01:00
sdigit 6651490ee7 Fix compiler warnings:
1) implicit declaration due to lacking stdlib.h
2) const/const char mixing
2015-04-11 15:40:13 -05:00
Mike Brady 82011bb757 Fix typo and recompikle man and html files 2015-04-04 23:21:54 +01:00
Mike Brady 98ed2dc75d Update README.md 2015-04-04 09:14:24 +01:00
Mike Brady 7a043b402b Change text layout slightly 2015-04-04 09:12:50 +01:00
Mike Brady 49c27eb128 Update RELEASENOTES.md 2015-04-03 22:20:39 +01:00
Mike Brady 8d8b5f445b Note moveing of metadata stuff. 2015-04-03 22:20:00 +01:00
Mke Brady 0ede9c5e7c Remove all metadata stuff -- move it to 2.3, clean up a few header files. 2015-04-03 22:16:15 +01:00
Mike Brady 65042f5867 Say that this is the stable branch 2015-04-03 13:56:05 +01:00
Mike Brady 7d947205b9 Modified the init script to wait for all services. 2015-03-29 18:12:20 +01:00
Mike Brady 29f9bedca1 Make shairport-sync service start last.
Make shairport-sync wait until all services are started before launching. Leave the sleep command in, but comment it out.

(Note, if you're updating your existing init script, run `sudo insserv shairport-sync` after making the changes in order to have the startup sequence correctly reconfigured.)
2015-03-29 18:04:15 +01:00
Mike Brady 3163e781b2 Update RELEASENOTES.md 2015-03-28 10:55:01 +00:00
Mike Brady e0a450308c Add sleep
Three seconds seems to work for many systems.
2015-03-28 10:51:44 +00:00
Mike Brady f12dc802dd Update LIBSOXR.md 2015-03-21 19:59:07 +00:00
Mike Brady 783e4aa31e Add warning for stalled metadata, add option for coverart 2015-03-21 18:22:21 +00:00
Mike Brady 6aa7fe100d Remove problematic LD_LIBRARY_PATH redefinition
Remove problematic LD_LIBRARY_PATH redefinition, which seems to cause auto tools to be unable to locate the GNU libc compatible malloc and other bad things.
2015-03-21 17:15:36 +00:00
Mike Brady 543663692d Update about metadata 2015-03-19 08:58:06 +00:00
Mike Brady 3665650f33 didn't mean to add the 'ideas' files -- removed 2015-03-18 21:03:35 +00:00
Mike Brady c2383d4942 Fix flush glitch, add artwork request to metadata set. 2015-03-18 21:02:49 +00:00
Mike Brady decc44c55f Add a few extra checks and a progress token. Turns out that iTunes delievery of artwork metadata is very buggy. Best not ask for it (remove metadata type 1 from the mDNS md=xxxphrase) 2015-03-17 22:59:29 +00:00
Mke Brady a6f156cfc0 Adjust the volume transfer function to be a bit steeper in mid to high volume 2015-03-16 21:11:04 +00:00
Mike Brady a2790fc102 Improve metadata output -- maybe it works reliably now. Add call to get audio parameters from back ends, to be able to give volume metadata. 2015-03-16 11:11:54 +00:00
Mike Brady 606c3fd080 Allow non-blocking option to adding item to pc queue -- necessary for 'resume' and possibly 'flush'. Stop pc_queue locking up (?) 2015-03-14 14:21:17 +00:00
Mke Brady e8be4e4883 Add a 'resume' metadata tag for when the stream is about to play 2015-03-12 23:07:02 +00:00
Mke Brady 60b3a6f7fd A little closer to an XML metadata sender. Still in flux. 2015-03-12 22:42:32 +00:00
Mike Brady edcd6da6b0 Debugging metadata code. The metadata is all a construction zone right now. 2015-03-12 20:46:21 +00:00
Mike Brady 9af829f7b2 Add a few new metadata messages. Change some of the codes -- important. 2015-03-11 22:38:09 +00:00
Mike Brady 0edf91cee9 Expose interface for sending metadata 2015-03-11 22:37:01 +00:00