Commit Graph
3794 Commits
Author SHA1 Message Date
Mike Brady 9aa5fa90f9 Update RELEASENOTES-DEVELOPMENT.md 2019-08-29 12:19:51 +01:00
Mike Brady c1f6e2ea18 Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
Fix metadata issues with the dbus and the MPRIS interfaces -- handle missing artwork properly, make the 'available' property more resilient.
2019-08-29 11:56:13 +01:00
Mike Brady 86b6d7bfff Squashed commit of the following:
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
    Recognise situation where a track has no artwork properly.
    Less likely to drop the 'availabile' property.
    Always output the full metadata whenever any part of it has changed.
    Metadata coming from dacp is now incorporated,
2019-08-29 11:47:49 +01:00
Mike Brady d846bc53be Update RELEASENOTES-DEVELOPMENT.md 2019-08-28 09:07:41 +01:00
Mike Brady 9fdfa5c235 Update RELEASENOTES-DEVELOPMENT.md 2019-08-28 09:07:13 +01:00
Mike Brady 701141680d Merge pull request #898 from Angus71/alac_a_fmtp_seg_fault
Fixes a potential crash when an incomplete `fmtp` parameter set is sent by the requesting client.
2019-08-28 09:00:12 +01:00
Mike Brady 7f2b437318 Merge pull request #887 from henriknil/early_version_usage
Return EXIT_WITH_SUCCESS on early exit on version (`–version` or `-V`)  and help (`–help` or `-h`) arguments.
2019-08-28 08:55:14 +01:00
Angus71 bf4bd8ef04 Clean up 2019-08-25 09:50:40 +02:00
Angus71 333e3904e7 Fixed seg. fault with ALAC and incomplete a:fmtp 2019-08-24 22:02:33 +02:00
Henrik Nilsson 14de9e27ab Return success on version and help argument
It's not a failure to print version or usage, so use return code
success.
2019-08-01 10:16:37 +02:00
Henrik Nilsson 2e7e5b6856 Check help and version argument early
Check for the help and version arguments makes sure that it's
always possible to get the version and usage even if there are
issues in other parts of the code.
2019-08-01 10:16:37 +02:00
Mike Brady 040a5915e3 Merge pull request #885 from bootc/development
More typo fixes across the tree.
2019-07-27 09:53:33 +02:00
Chris Boot b9cf91b2bb More typo fixes across the tree
Previously I have made spelling changes as caught by Debian's lintian
tool, which has a short list of common misspellings that it tests for.
This time I decided to run codespell against the source and fix all the
obvious problems it came up with. It also uses a list of misspellings
but it's much larger than lintian's, but also has some false positives
so I went over the list by hand.

The command I used to do check the source was:
git ls-tree -rz --name-only HEAD | xargs -0 codespell -L minimise,errorstring
2019-07-27 00:05:38 -03:00
Mike Brady addc744bfa Update RELEASENOTES-DEVELOPMENT.md 2019-07-24 08:51:55 +02:00
Mike Brady 336e1bb1c3 remove some detritus 2019-07-22 13:34:35 +01:00
Mike Brady e6bd5b1556 Fix a bug that sometimes caused a crash when a service name was specified in the configuration file. Some other minor changes. 2019-07-21 08:52:27 +01:00
Mike Brady 175ae0a650 Fix a bug that sometimes caused a crash when a service name was specified in the configuration file. The fix was to be more systematic in allocating and deallocating memory for termporary strings. Thanks to Chris Boot, Ari Sovijarvi and Jeroen Massar for the bug report. Fixes Debian Bug report #925577.
Allow the rtsp_listen_loop to exit if the RTSP port (usually port 5000) is not available. This allows the system to exit cleanly rather than abort.
2019-07-21 09:06:37 +02:00
Mike Brady 1dd0d82836 Update README.md 2019-07-05 10:09:50 +01:00
Mike Brady d78528a59e Update README.md 2019-07-05 09:20:43 +01:00
Mike Brady 7d6b52edd4 Expose some of the settings used in the disable_standby_mode and tidy up some of the silence-generating code. 2019-06-20 10:53:57 +01:00
Mike Brady a8faacd3fc Expose some of the settings used in the disable_standby_mode.
Specifically, firstly, the disable_standby_mode_silence_threshold, which is the
amount of audio in the output device's hardware buffer. It should normally
be close to the value givein in the audio_backend_buffer_desired_length_in_seconds
setting. If it drops to this value, silence is added to the buffer to prevent
the output device from becoming idle.

Secondly, the disable_standby_mode_silence_scan_interval is the time between checks
of the output device's hardware buffer.

The code for generating frames of possibly-dithered silence has been simplified.
2019-06-20 10:45:27 +01:00
Mike Brady c8b0be30b4 find . \( -name \*.cpp -or -name \*.h -or -name \*.c \) -exec clang-format -i -style='{BasedOnStyle: llvm, IndentWidth: 2, ColumnLimit: 100}' '{}' \; 2019-06-19 19:06:54 +01:00
Mike Brady 7fc977d8d3 Change comments for use_precision_timing 2019-06-17 22:44:12 +01:00
Mike Brady 55488ad24c Update RELEASENOTES-DEVELOPMENT.md 2019-06-17 22:30:44 +01:00
Mike Brady 34b96729a2 Refine the precision timing code
Only allow it if the output device is a hardware device
2019-06-17 22:27:03 +01:00
Mike Brady 1ca9226242 Update audio_alsa.c 2019-06-17 22:25:47 +01:00
Mike Brady 7013b0cc3d refine the selection of precision timing to be allowed only if the device is a real hardware device 2019-06-17 19:43:23 +01:00
Mike Brady 9199bf24dd fix the detection of the availability of precision timing information -- actuall, renable it 2019-06-17 10:38:20 +01:00
Mike Brady a46c761aa6 make snd_pcm_recover silent when the debug level is 0, not the other way around, duh. 2019-06-17 10:04:23 +01:00
Mike Brady 65abca2562 change the threshold for turning off disable standby mode to more than 40 underruns in the first 100 writes. 2019-06-17 09:47:56 +01:00
Mike Brady cd9982c43b if disable_standby_mode is enabled, disable if if more than 20 underruns occur for 50 silence buffers at the start. 2019-06-17 09:39:04 +01:00
Mike Brady dbea82c212 restore full code for checking for precise timing but stop making it necessary for disable standby mode. 2019-06-17 07:54:04 +01:00
Mike Brady 9af4895f33 Update note about Arch Linux. 2019-06-16 12:18:58 +01:00
Mike Brady 3b2efad6ff Update README.md 2019-06-09 15:05:05 +01:00
Mike Brady 2c4b485a56 Update README.md 2019-06-09 15:04:20 +01:00
Mike Brady b41c9863f3 bring in small changes from 3.3.2 master branch 2019-06-07 17:52:20 +01:00
Mike Brady 413df6d063 Correct a compilation error in Alpine Linux 2019-06-07 17:48:45 +01:00
Mike Brady 3615b99f5e Update RELEASENOTES.md 2019-06-05 15:31:50 +01:00
Mike Brady 9d624e40c5 Update RELEASENOTES-DEVELOPMENT.md 2019-06-05 15:31:08 +01:00
Mike Brady fb6d65d715 Update shairport-sync.spec 2019-06-05 15:28:15 +01:00
Mike Brady 15cb5479c2 Update RELEASENOTES.md 2019-06-05 15:26:16 +01:00
Mike Brady 9c54bfa991 *Bug Fixes*
* Fix a bug in the MQTT documentation and add sanity checking for the port chosen.
* Fix a bug that caused manual format and rate setting to be ignored.
* Add missing support for format settings S24_LE, S24_BE, S32_LE and S32_BE.
* Fix a bug that caused dither to be too loud.
* Fix error message for invalid standby mode choice.
2019-06-05 15:05:54 +01:00
Mike Brady 1704916a47 Squashed commit of the following:
commit 85fae473bb
Merge: bf91d35 854942d
Author: Mike Brady <mikebrady@eircom.net>
Date:   Tue Jun 4 22:15:37 2019 +0100

    Merge pull request #860 from joerg-krause/patch-2

    Debug requested period size value

commit 854942df92
Author: Jörg Krause <joerg.krause@embedded.rocks>
Date:   Tue Jun 4 20:47:43 2019 +0200

    Debug requested period size value

commit bf91d35bfb
Author: Mike Brady <mikebrady@eircom.net>
Date:   Tue Jun 4 15:33:30 2019 +0100

    Update RELEASENOTES-DEVELOPMENT.md

commit 3ca3408255
Author: Mike Brady <mikebrady@eircom.net>
Date:   Tue Jun 4 15:32:10 2019 +0100

    Fix error message for invalid standby mode choice

commit 4bafe1c982
Author: Mike Brady <mikebrady@eircom.net>
Date:   Mon Jun 3 10:03:54 2019 +0100

    quieten a compilation warning

commit 9d96906402
Author: Mike Brady <mikebrady@eircom.net>
Date:   Sun Jun 2 18:05:40 2019 +0100

    Update configure.ac

commit 0c5c4bfe3f
Author: Mike Brady <mikebrady@eircom.net>
Date:   Sun Jun 2 18:04:51 2019 +0100

    Update RELEASENOTES-DEVELOPMENT.md

commit 85cc1bdd97
Author: Mike Brady <mikebrady@eircom.net>
Date:   Sun Jun 2 17:56:47 2019 +0100

    Fix the dither calculation -- it was 12 dB too high, really noticable on the U8 setting.

commit 25f0fbc24d
Author: Mike Brady <mikebrady@eircom.net>
Date:   Sun Jun 2 13:42:19 2019 +0100

    Update INSTALL.md

commit d91e41d976
Author: Mike Brady <mikebrady@eircom.net>
Date:   Wed May 29 17:26:44 2019 +0100

    Add missing support for S32_LE, S32_BE, S24_LE and S24_LE formats.

commit 7f2e6b1aac
Author: Mike Brady <mikebrady@eircom.net>
Date:   Wed May 29 16:18:51 2019 +0100

    Add support for S32_LE, S32_BE, S24_LE and S24_BE wqhen generating frames of dithered silence

commit 76ad4e6a73
Author: Mike Brady <mikebrady@eircom.net>
Date:   Wed May 29 16:00:47 2019 +0100

    enable specification of specific formats and/or speeds to turn off automatic format/speed selection, fixing a bug. Clarify some of the warnings. Fix a few typos in the configuration file sample.

commit a8222e3f85
Merge: c677006 19fbede
Author: Mike Brady <mikebrady@eircom.net>
Date:   Mon May 27 09:30:57 2019 +0100

    Merge pull request #855 from idcrook/conf_mqtt_port

    mqtt port config changes – fix error in the configuration file and check port number for sanity.
    Many thanks, David. It'll find it's easy into the next release.

commit 19fbededcf
Author: David Crook <idcrook@users.noreply.github.com>
Date:   Sat May 25 13:01:22 2019 -0600

    mqtt port config changes

    1. update example shairport-sync.conf file
    2. update config file mqtt port parsing

    Signed-off-by: David Crook <idcrook@users.noreply.github.com>

commit c677006541
Merge: 744c595 3c4a878
Author: Mike Brady <mikebrady@eircom.net>
Date:   Fri May 24 17:37:26 2019 +0100

    Bring into line with master 3.3
2019-06-05 15:02:26 +01:00
Mike Brady 85fae473bb Merge pull request #860 from joerg-krause/patch-2
Debug requested period size value
2019-06-04 22:15:37 +01:00
Jörg Krause 854942df92 Debug requested period size value 2019-06-04 20:47:43 +02:00
Mike Brady bf91d35bfb Update RELEASENOTES-DEVELOPMENT.md 2019-06-04 15:33:30 +01:00
Mike Brady 3ca3408255 Fix error message for invalid standby mode choice 2019-06-04 15:32:10 +01:00
Mike Brady 4bafe1c982 quieten a compilation warning 2019-06-03 10:03:54 +01:00
Mike Brady 9d96906402 Update configure.ac 2019-06-02 18:05:40 +01:00
Mike Brady 0c5c4bfe3f Update RELEASENOTES-DEVELOPMENT.md 2019-06-02 18:04:51 +01:00