nils/shairport-sync
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Omit password in debug (syslog) output

Browse Source 
Configuration files may contain it, but those can be protected with
filesystem permissions.

Debug log, however, may end up in syslog(3) which is usually accessible
by all users on a system.

Avoid disclosing user secrets by simply not printing the password.
This commit is contained in:
Klemens Nanni
2024-02-24 14:41:02 +01:00
parent 00a4758404
commit b831da4bf1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
shairport.c
+1 -1
View File
@@ -2429,7 +2429,7 @@ int main(int argc, char **argv) {
debug(1, "allow a session to be interrupted: %d.", config.allow_session_interruption);
debug(1, "busy timeout time is %d.", config.timeout);
debug(1, "drift tolerance is %f seconds.", config.tolerance);
debug(1, "password is \"%s\".", strnull(config.password));
debug(1, "password is %s.", config.password == NULL ? "not set" : "set (omitted)");
debug(1, "default airplay volume is: %.6f.", config.default_airplay_volume);
debug(1, "high threshold airplay volume is: %.6f.", config.high_threshold_airplay_volume);
if (config.limit_to_high_volume_threshold_time_in_minutes == 0)