We need to use this any time we write to or access any of the
audio-buffer related variables. This also removes the need to use
'volatile', which cripples the compiler optimizations.
Using the `volatile` qualifier in multithreading code is never the right
answer. Mutexes should be used as was attempted with the audio buffer
code. Here, we implement a new mutex for the volume and fix_volume
globals, and grab a lock on it when necessary, which is for both reads
and writes.
If you turned set `debug = 1` in hairtunes, you'd quickly get a mess of
debug messages that showed bf_est_drift in bf_est_update() going quicky
out of range toward a float NaN value (usually negative). Clearly the
presence of this `out` variable in biquad_filt was meant to be used, not
marked as unused.
This allows the compiler to do a much better job on this file, as it
currently can't inline most of the functions because they are
technically visible outside the file. Mark most functions and variables
static to let the compiler work.
- when requesting a packet, do not request an already received packet
- move the last-chance resend to buffer_get_frame
- check more often for missing frames
own checks show that some frames need to be requested up to 4 times
on bad connections
disconnection
I was looking to trigger an action when I connect to shairport.
Basically, I want to switch on the stereo when I start playing music
over shairport (and I want to switch if off when I stop streaming).
Because my set-up will be different than any other set-up, I thought
about making it generic.
Two new command-line options --play_prog and --stop_prog take one
argument: the command line to start when the first connection is made or
when the last connection quits.
Example:
$ shairport.pl --play_prog="amixer set PCM 100%"
The last-chance resend was sometimes fired up to 6 times (probably while
receiving multiple new packets while playing the same buffer-data).
The following patch corrects this: only one retry is sent out.
For this to happen, I change abuf->ready to -1 ("1 retry sent out") and
by changing the other comparisons of abuf->ready to != 1.
Probably, this could be improved, by implementing a first check at t-30,
t-20, t-10, ...
Dan McGee
B. van BerkumandDan McGee
Stef SimoensandDan McGee
Albert Zeyer
Dmitry Alenichev
JH Laird
James Laird
Juho Vähä-Herttua
Gareth Jones
Marcin Nowicki
Lucas Garron
sbleon
Jan Ortgies
Stijn Meurkens
Yuval Tal
Klaus Reimer
Jonty