Commit Graph
96 Commits
Author SHA1 Message Date
Mike Brady b8f348d459 Restore compatibility with AirPower on Android. 2020-12-07 14:04:22 +00:00
Mike Brady 54cb9de183 Handle active_remote_id as a string rather than an unsigned 32-bit number -- seems ROON uses a longer character sequence.
Tidy up some error messages about which backend is selected.
    Tighten up memory allocatons in DACP.c.
    Add a default name for the pipe backend: /tmp/shairport-sync-audio
    Ensure the metadata pipe is created, if necessary, when the --with-metadata option is chosen without dbus or mpris
    Make the first output backend in the list of backends the default and make its name the default output_name. Clang-format everything
    Add the word 'jack' to the version string if Jack Audio support is compiled in.
    Fix a flaw in resyncing -- a flush is set up but not triggered.
    Open metadata and audio pipes with 666 permissions.
    Ensure metadata and cover art are enabled if metadata support is included at compilation.
    Reword some misleading error messages.
    Set convolution defaults even if no configuration file is found.
2020-09-30 15:02:35 +01:00
Mike Brady 27faeaf696 Squashed commit of the following:
Use a  gentler flush process for resyncing.
    Potentially fix a flaw in resyncing. The problem was that a flush is set up but not triggered.
    Open metadata and audio pipes with 666 permissions for easier integration with other audio sources to give them permission to write to the audio pipe later.
    Ensure metadata and cover art are enabled if metadata support is included at compilation.
    Reword some misleading error messages.
    Set convolution defaults even if no configuration file is found.
    Quieten a few debug messages.
2020-08-21 10:43:09 +01:00
Mike Brady bdc2dca3ec 3.3.7rc0 2020-07-06 17:09:15 +01:00
Mike Brady 02224666da Squashed commit of the following:
Don't use strndup as old versions of OpenWrt don't seem to have it
    Update FREEBSD.md
    Fix comparison between old and new metadata strings by checking they have equal lengths as well.
    Remove a redundant definition to prevent use on an uninitialised copy, clean up some of the less-used backends
    Remove some unwanted and unused variable declarations from audio_dummy.c and audio_soundio.c
    Add the -fno-common flag to compilation.
    Treat the "mper" attribute as the 64-bit item that it is rather than a 32-bit item as hithereto. Output it as a hexadecimal number to correspond with the format of the track id obtained from AppleScript
    Make changes to that it compiles under gcc-10 with -fno-common
    Add a SIGCHLD handler to reap zombie processes generated after script invocations where wait_for_completion is set to "no".
    Update and rename CONTRIBUTING.md to REPORTING ISSUES.md
    Add a few more commands and clarify some text.
    Change from talking about a server to talking about a client. Technically, e.g. iTunes is a client of Shairport Sync.
    Store the UserAgent so as to recognise forked-daapd so as to always send a revision_number of 1 when asking for playerstatus of forked-daapd.
    Add or update some of the copyright notices
    Add the ability to set the volume directly to the D-Bus RemoteControl interface and to the MPRIS interface. Both use the recently-discovered ability to set the device_volume.
    Merge in Pieter De Gendt's work on resampling on the jack backend.
    Merge pull request #939 from pdgendt/feature/jack-soxr-resampling
    Add SetAirplayVolume to the D-Bus RemoteControl interface.
    Add SetVolume to the MPRIS interface.
    Hook up the Volume property in the MPRIS interface.
    Modify RemoteCommand in the D-Bus interface to return the HTTP status and response.
    Change the type of airplay_volume from int to double in the metadata hub.
    Add a few sample commands in the D-Bus document.
2020-02-20 21:32:35 +00:00
Mike Brady d734b7e71d add volume-up and volume-down to the dbus test client. Quieten a debug message. 2019-09-08 17:43:07 +01:00
Mike Brady 2b980ff2a8 make dbus interface set more quickly an AdvancedRemoteControlAvailable to false when going from an iTunes to an AirPlay service. 2019-09-08 17:26:06 +01:00
Mike Brady daab7a634c Clean up the scanning code for detecting either a standard DACP server or an advanced DACP server. 2019-09-04 20:24:34 +01:00
Mike Brady 86b6d7bfff Squashed commit of the following:
Fix Issue #890 -- https://github.com/mikebrady/shairport-sync/issues/890
    Recognise situation where a track has no artwork properly.
    Less likely to drop the 'availabile' property.
    Always output the full metadata whenever any part of it has changed.
    Metadata coming from dacp is now incorporated,
2019-08-29 11:47:49 +01:00
Mike Brady c8b0be30b4 find . \( -name \*.cpp -or -name \*.h -or -name \*.c \) -exec clang-format -i -style='{BasedOnStyle: llvm, IndentWidth: 2, ColumnLimit: 100}' '{}' \; 2019-06-19 19:06:54 +01:00
Mike Brady 413df6d063 Correct a compilation error in Alpine Linux 2019-06-07 17:48:45 +01:00
Mike Brady d9168f4aa7 remove a strncpy truncation warning
update a timing setting in the settings file
list the alsa hardware devices in the -h message
2019-05-17 10:43:54 +01:00
Mike Brady 57bcea52c7 Tidy up the exit() arguments. 2019-04-10 21:32:08 +01:00
Mike Brady cc0ff56ab7 Create the dbus/system.d directory if it doesn't already exist. 2019-03-18 19:37:09 +00:00
Mike Brady 405a028f33 quieten some exiting debug messages 2019-02-16 19:44:25 +00:00
Mike Brady 79e22063ef check that the systems are started before trying to stop them, duh. 2019-02-05 15:51:16 +00:00
Mike Brady 0feb59eaa5 move malloc_cleanup to common.c 2019-01-23 16:34:05 +00:00
Mike Brady 2e4428538d Add an "active" mode that can time out after a period -- 10 seconds by default -- after play ends. 2019-01-21 21:43:55 +00:00
Mike Brady f6d6700d6e Quieten a debug message. 2019-01-18 16:28:02 +00:00
Mike Brady 6a27712e94 Quieten a debug message. 2019-01-13 10:00:11 +00:00
Mike Brady 8f20e5808b clang format 2019-01-10 16:12:57 +00:00
Mike Brady 8e72574a57 Add some diagnostics, shorten timeouts and set so_linger of zero whenever a write or read error occurs. 2019-01-10 16:10:53 +00:00
Mike Brady 59b3abd965 quieten some dacp debug messages 2018-12-27 14:36:29 +00:00
Mike Brady ad6c721d5a Format 2018-12-27 14:04:31 +00:00
Mike Brady 668f78062e Fix a few memory leaks by deleting responses even when the reply is somehow illegal. 2018-12-27 14:02:19 +00:00
Mike Brady 10985a0bec Bug fix: close a socket even if it doesn't successfully connect. Enhance some debug messages. 2018-12-26 10:42:52 +00:00
Mike Brady 72079adaf4 Initial shot at tidying up the avahi monitoring for DACP Id port information to make it survive abnormal temrination of play sessions. 2018-12-08 21:55:49 +00:00
Mike Brady d2f6a446e1 Bring up to date with 3.3d2 from the raspberry pi 2018-08-22 14:41:03 +01:00
Mike Brady 76c5dd9285 Stop using SIGUSR1 for cancelling threads, use pthread_cancel and friends instead, fix some memory leaks, add accurate ouput rate calculation to statistics, add "quit" verb to MPRIS and native d-bus interfaces. Probably still buggy. 2018-07-30 10:07:11 +01:00
Mike Brady 703ab8e556 Quieten a few debug messages 2018-07-22 16:13:49 +01:00
Mike Brady 5f750ba9b7 Fix a few memory leaks. 2018-07-22 16:12:52 +01:00
Mike Brady 2eaaa9cdb3 Fix a bug where the dacp notification handlers are called 2018-07-21 15:35:07 +01:00
Mike Brady f1d4503431 Try to add proper cancellation code to all threads -- not complete, buggy. 2018-07-20 13:50:38 +01:00
Mike Brady 41241681e3 Make resend error backoff work better and set it to 0.5 seconds. Quieten some routine debug messages. 2018-04-23 13:09:44 +01:00
Mike Brady ad48056686 Improvements in handling non-existent DACP server, slightly more informative debug messages. 3.2RC4. 2018-04-18 10:34:50 +01:00
Mike Brady ed0ce06e82 Fix a few tiny typos and rationalise some debug message levels. 2018-04-16 10:00:22 +01:00
Mike Brady fd7c2d7954 Allow audio packets as well as resends on the control port. Add some debug messages. 2018-04-11 20:05:21 +01:00
Mike Brady a9d6e0a2e6 Remove some debug messages 2018-04-11 10:34:09 +01:00
Mike Brady 9e944e4050 Allow for an actual NULL DACP-ID string 2018-04-11 09:55:12 +01:00
Mike Brady a02b97598f Quieten a debug message 2018-04-08 16:12:13 +01:00
Mike Brady 08a7d4ffb5 Use snprintf in place of sprintf. 2018-04-08 15:36:05 +01:00
Mike Brady 7fb8913532 Use snprintf in place of sprintf and initialise mutexes for debugging. 2018-04-08 12:36:00 +01:00
Mike Brady aa69f52d04 Quiten some debug messages and some compiler warnings 2018-04-07 17:40:46 +01:00
Mike Brady fb3f9f51eb Handle situation when the Shairport Sync player is deselected. 2018-04-07 17:13:04 +01:00
Mike Brady 5e6f444339 Quieten scan debug messages 2018-04-07 14:01:03 +01:00
Mike Brady 4aab0a6f92 Improve the scanner to start and stop properly and to release track data when remote control becomes unavailable. 2018-04-07 13:22:38 +01:00
Mike Brady 7481c707d9 Check the dacp scan code. 2018-04-07 11:39:38 +01:00
Mike Brady 00664871f2 Begin to debug the DACP scanner starting and stopping. 2018-04-04 22:44:46 +01:00
Mike Brady 84cd85eb22 Fix problem when reconnecting to an itunes play session. 2018-04-03 22:43:35 +01:00
Mike Brady f9845d017b Fix problem when reconnecting to an itunes play session. 2018-04-03 22:32:43 +01:00