44 Commits
Author SHA1 Message Date
zutroy97 0e37b5adcf Reverted back track_id as hex string 2026-07-05 17:45:24 -05:00
zutroy97andClaude Sonnet 5 0c946ea040 Publish and accept track_id as decimal instead of hex
Changes the mper-derived track_id published over MQTT from hex to
decimal, and updates queue_next to embed the value in the DACP
persistentid query without a 0x prefix, matching the new format.
Queueing behavior (command=add&mode=3) is unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 07:55:01 -05:00
zutroy97andClaude Sonnet 5 6531f0ef5d Fix build: restore stop_play() for MQTT disconnect command
An unrelated change in a prior commit swapped stop_play() for
release_play_lock(NULL), which isn't declared in rtsp.h and broke
the build with an implicit-declaration error.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-03 21:57:25 -05:00
Scott Simon f6e2c6f252 Remove commented-out code from mqtt.c 2026-07-03 15:37:27 -05:00
Scott SimonandClaude Sonnet 5 1fbb6312f6 Fix byte order of track_id published over MQTT
The 'mper' handler cast the raw big-endian persistent-id bytes directly
to a host-native uint64_t, which reverses the value on little-endian
hosts (e.g. Raspberry Pi). metadata_hub.c already reconstructs the same
field correctly by applying ntohl() to each 32-bit half; mqtt.c now does
the same, so the published track_id matches the real dmap.persistentid
and can be used directly with the queue_next command.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-03 15:37:27 -05:00
Scott SimonandClaude Sonnet 5 b6a5a07df5 Add test track_id reference notes to mqtt.c
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-03 15:37:27 -05:00
Scott Simon 790752499c Fix command format in MQTT queue_next function 2026-07-03 15:36:43 -05:00
Scott Simon bac7a7b4c8 Update MQTT command for queue_next functionality 2026-07-03 15:36:43 -05:00
Scott SimonandClaude Sonnet 5 dfad96df7b Add queue_next MQTT remote command to enqueue a track by persistent ID
Sends ctrl-int/1/cue?command=add&query='dmap.persistentid:0x<id>'&mode=3
to the DACP source, where <id> is the hex track_id string taken directly
from the MQTT payload after "queue_next ".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-03 15:36:43 -05:00
Mike Brady f30dd7aee6 Enhancements
Enable the AirPlay 2 build to operate an optional classic-AirPlay-only service or to gracefully degrade to classic AirPlay, as follows:
  1. Add a new command-line option '-—service-type=<type>' and an equivalent configuration entry 'service_type = "<type>"' in the 'general' section of the configuration file,
     where <type> can be "auto", "classic" or "airplay2":
      1. "auto" (default) means that the service will be AirPlay 2 if NQPTP is running. If NQPTP is not running, classic AirPlay service will be provided instead, and in that case,
      "(Classic)" will be appended to the default AirPlay service name visible to AirPlay clients like Apple Music, for example "RaspberryPi3B (Classic)".
      2. "classic" means the service will be classic AirPlay (aka AirPlay 1).
      3. "airplay2" means the service will be the modern AirPlay 2. In this case, as distinct from "auto", if NQPTP is not running, Shairport Sync will log an error and terminate.
  2. In the systemd service file, NQPTP is now a "Want" rather than a "Require". If it's present, then it will be launched before Shairport Sync. If it's absent, Shairport Sync will launch anyway.
  3. Improve the delivery of input format changes and emit 'sdsc' metadata when changes occur.
  4. Emit new format information in the log if statistics is enabled.

Docker Changes
  1. Support for linux/arm/v6 has been dropped, as Docker is no longer supported.
  2. NQPTP is not started in the AirPlay 2 Docker image if '--service-type=classic' or '--service-type=airplay1' is in the command line options at the end of the docker run command.
     The purpose is to ensure that ports 319 and 320 are left alone when the AirPlay 2 image is set to provide Classic service only.
     Note that setting the configuration file 'service_type' to 'classic' will not prevent NQPTP from starting up -- you must use the command line option.
  3. A new "dev" target has been added. It is a large image containing the custom-built FFmpeg library, NQPTP, Avahi and D-Bus along with the Shairport Sync source and
     all necessary development tools. When started, Avahi, D-Bus and NQPTP are all installed and running. The bash shell has also been added and is entered.

Stability Improvements
  Reorganise session preemption to fully terminate the existing session before starting a new one.
  Don't delay closing the event port to wait for it to be closed at the client end.
  Add a safe_socket_close() function to ensure sockets are fully closed. Use -1 to designate closed rather than 0, to prevent attempts to reclose sockets, causing mayhem.
  Re-order FFmpeg decommissioning during teardown.
2026-05-18 09:57:12 +01:00
Mike Brady 11052b7896 Lot of changes here.
1. check_classic_mac_basic.yml — update to latest macOS-latest
2. docker-on-push-tag-or-pr — dependant updates
3. FFTConvolver — fix a compilation warning when the DEBUG flag is turned off
4. Reorganise some source files — e.g. move most of the metadata stuff into a subdirectory
5. Remove unused special-purpose AirPlay 2 RC event handler.
6. Reorganise source files and source code relating to the standard event handler.
7. Check configuration settings a little more carefully to offer more meaningful diagnostics.
8. Add password to AirPlay 2 and reorganise initialisation to set AirPlay 2 flags accordingly.  Also, remove redundant airplay_pin.
9. Remove redundant debug facility definitions from common.h
10. Make it possible to omit all the dacp stuff from a build.
11. Make it possible to omit metadata multicast from a build.
12. Add AP2-native metadata by setting bit 50 of features to true.
13. Improve stability when pre-empting an existing play session.
14. Fix a few compiler warnings in the pair_ap library.
15. Ensure that the audio format is known before starting synchronisation.
16. Improve handle_configure to set/clear a new config setting. Doesn’t seem to do anything…
17. Experimentally turn off bit 46 of AirPlay 2 features — seems to stop failing pair-verify attempts.
2026-04-26 10:23:18 +01:00
Markus Reiter 7654cb339b Add default_entity_id for Home Assistant auto-discovery. 2026-02-16 21:57:07 +01:00
lululombard bd9008e4f7 Add MQTT retain flag support 2026-02-08 12:43:53 +01:00
Mike Brady 16b6534ad3 further changes to remove compilation warnings on 32-bit builds 2025-12-31 19:02:16 +00:00
Mike Brady e9f60c89d2 Cleaned up the get_play_lock and release_play_lock stuff and placed them in the right (?) places for AP2, AP1 compatibiity and Classic AP. Fixed the setting of flags and GID in Bonjour. 2025-12-09 12:10:05 +00:00
Mike Brady e12a3ed7b2 Do a long-overdue rebuild of the buffered audio processor and, with everything we have figured out, implement a cleaner method to handle both immediate and deferred flush requests. Remove lots of old flags and redundant code. Leave in a few debug messages. 2025-11-16 16:58:34 +00:00
Jordan Zucker da4cb00816 Trying again 2025-03-30 17:23:40 -07:00
Mike Brady 60143518c2 This squashed commit comprises a long series of improvements, bug fixes, optimizations, and new feature additions:
- 48,000 frames per second operation,
 - 48k lossless stereo, 5.1 and 7.1 surround sound
 - Multichannel and multi rate operation on ALSA, PipeWire, PulseAudio, FreeBSD, stdout and unix pipe output backends.

Automatic, flexible and controllable output format (rate, sample format and channel count) selection.

Full FFmpeg integration to support transcoding, resampling, and new audio formats.

Better operation on lower powered devices down to e.g. Raspberry Pi B.

Reduced Docker image sizes with a slimmed-down FFmpeg library.

Enhanced timestamp handling for better synchronization.

Improved the sync error calculation.

A new "vernier" resampling and interpolation method for low-power CPUs.

Bug fixes and minor enhancements.

Note -- there are many breaking changes from previous versions of Shairport Sync!
2025-02-23 13:31:17 +00:00
Mike Brady df8663655e Fix compilation bug in classic mode -- don't look for config.airplay_device_id. 2024-10-16 15:41:30 +01:00
aaronk6 6258021d55 Fixed multiple devices getting merged in Home Assistant 2024-09-24 20:32:08 +02:00
aaronk6 af6d90282e Set unique device identifier 2024-09-24 20:32:08 +02:00
aaronk6 e252ee7fb5 MQTT auto discovery working 2024-09-24 20:32:08 +02:00
aaronk6 b4f160e320 MQTT autodiscovery (WIP) 2024-09-24 20:32:08 +02:00
aaronk6 cda315b6aa Add support for MQTT autodiscovery 2024-09-24 20:32:08 +02:00
aaronk6 6de30126a9 MQTT: Add is_active and is _playing 2024-09-24 20:32:08 +02:00
Mike Brady 8e5393ec42 Parse phbt/phb0 metddata tokens. 2022-12-05 11:37:22 +00:00
Mike Brady e8b8c6edb7 Clang cleanup 2022-11-18 18:14:50 +00:00
Mike Brady d67909b837 Add new metadata item: sps:songdatakind, derived from the asdk metadata token. It seems to indicate a timed item (0) or an untimed stream (1). Add output format, output frame rate, stream type (Realtime/Buffered/Classic) properties. Update MQTT appropriately. 2022-11-12 16:42:25 +00:00
Mike Brady 3e4b67e97d Add two new metadata items -- the player's service name, e.g. "Den Speakers" and the name of the current client, if any, e.g. "Joe's iPhone". 2022-11-07 11:33:05 +00:00
Mike Brady a382ac6672 Clang Format 2022-03-14 11:56:43 +11:00
Mike Brady 3d720d65bf MQTT -- add code to deal with empty payloads by adding a dummy payload to empty messages by default. 2022-02-07 12:36:08 +00:00
Mike Brady 65773c5af4 Merge branch 'development' of github.com:mikebrady/shairport-sync into development
Some pull requersts and a documentation update.
2021-12-27 12:19:08 +00:00
Mike Brady 966d68bdec Begin to get SPS to give a unique shm interface name to nqptp. Also clang format 2021-12-27 12:19:01 +00:00
Cody Cutrer 82c7f4eff0 extract several pieces of client metadata for AP2 2021-12-26 12:13:42 -07:00
Cody Cutrer a9c8de50b1 some MQTT metadata improvements
document some more of the fields that can come through, and add
a few more "parsed" messages:
 * active_remote_id
 * dacp_id
 * server_ip
2021-12-23 19:09:16 -07:00
Mike Brady dfd90bac6b Clean up code for the silent lead-in on a non-syncing back end e.g. a pipe. Clean up pipe creation and initial opening and associated error messages. Fix error with warning/die messages. Tidy up some debug messages. 2020-06-05 17:22:53 +01:00
Mike Brady 9ae649fa9a change some debugging messages 2020-05-28 15:39:10 +01:00
Till Zimmermann 60b9347a00 Fixed Cover Bug, checking dependencies 2019-05-09 11:59:02 +02:00
Mike Brady f3b2d07089 Add active_start and active_end messages to mqtt 2019-03-08 15:05:23 +00:00
Till ZimmermannandGitHub cb38e90e20 Small logic fix
Fixes #767
2018-11-03 14:34:12 +01:00
Mike Brady c2e3fa5aa7 Move ab_mutex, flow control CV and flush mutex initialisation and teardown out of the player thread. Thus remove need for player theread lock. Format some of the surce files. 2018-07-14 13:38:29 +01:00
Till Zimmermann 3d1086ea2e Fixed not connected bug, added version string 2018-06-20 18:58:34 +02:00
Till Zimmermann c445510d5a minor improvements on the mqtt feature 2018-06-19 20:25:22 +02:00
Till Zimmermann 02694948f3 Initial MQTT Version 2018-06-19 19:40:08 +02:00