From f6c2b07c9b80c1b15201d6e813a9872b6e12e9aa Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Mon, 23 Apr 2018 19:20:49 +0100 Subject: [PATCH 1/8] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d663e8f..1c607356 100644 --- a/README.md +++ b/README.md @@ -187,7 +187,7 @@ $ autoreconf -i -f - `--with-soxr` for libsoxr-based resampling. - `--with-piddir` for specifying where the PID file should be stored. This directory is normally chosen automatically. The directory must be writable. If you use this option, you may have to edit the init script to search for the PID file in your new location. - `--with-metadata` to add support for Shairport Sync to pipe metadata to a compatible application of your choice. See https://github.com/mikebrady/shairport-sync-metadata-reader for a sample metadata reader. -- `--with-configfile` to install a configuration file and a separate sample file at the `make install` stage. Default is to install. An existing `/etc/shairport-sync.conf` will not be overwritten. +- `--with-configfiles` to install a configuration file and a separate sample file at the `make install` stage. Default is to install. An existing `/etc/shairport-sync.conf` will not be overwritten. - `--with-pkg-config` to use pkg-config to find libraries. Default is to use pkg-config — this option is for special purpose use. - `--with-apple-alac` to include the Apple ALAC Decoder. - `--with-convolution` to include a convolution filter that can be used to apply effects such as frequency and phase correction, and a loudness filter that compensates for human ear non-linearity. Requires `libsndfile`. From 09bb60a338a14dd03258a6022ca9712905427d4f Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Wed, 25 Apr 2018 17:42:51 +0100 Subject: [PATCH 2/8] Make the options for the dbus and mpris interfaces --with-dbus-interface and --with-mpris-interface rather than --with-dbus and --with-mpris. --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7e410172..82f77928 100644 --- a/configure.ac +++ b/configure.ac @@ -277,7 +277,7 @@ AC_ARG_WITH(dns_sd, [ --with-dns_sd = choose dns_sd mDNS support], [ AM_CONDITIONAL([USE_DNS_SD], [test "x$HAS_DNS_SD" = "x1"]) # Look for dbus flag -AC_ARG_WITH(dbus, [ --with-dbus-interface = include support for the native Shairport Sync D-Bus interface], [ +AC_ARG_WITH(dbus-interface, [ --with-dbus-interface = include support for the native Shairport Sync D-Bus interface], [ AC_MSG_RESULT(>>Including dbus support) HAS_DBUS=1 AC_DEFINE([HAVE_DBUS], 1, [Needed by the compiler.]) @@ -295,7 +295,7 @@ AC_ARG_WITH(dbus-test-client, [ --with-dbus-test-client = compile dbus test cli AM_CONDITIONAL([USE_DBUS_CLIENT], [test "x$HAS_DBUS_CLIENT" = "x1"]) # Look for mpris flag -AC_ARG_WITH(mpris, [ --with-mpris-interface = include support for a Shairport Sync D-Bus interface conforming to the MPRIS standard], [ +AC_ARG_WITH(mpris-interface, [ --with-mpris-interface = include support for a Shairport Sync D-Bus interface conforming to the MPRIS standard], [ AC_MSG_RESULT(>>Including the MPRIS D-Bus Interface) HAS_MPRIS=1 AC_DEFINE([HAVE_MPRIS], 1, [Needed by the compiler.]) From fa6e2b3b9a02614d5a0dcfaf245892d3116eb3df Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Wed, 25 Apr 2018 17:43:10 +0100 Subject: [PATCH 3/8] Make the options for the dbus and mpris interfaces --with-dbus-interface and --with-mpris-interface rather than --with-dbus and --with-mpris. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 82f77928..88f789fb 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ # Process this file with autoconf to produce a configure script. AC_PREREQ([2.50]) -AC_INIT([shairport-sync], [3.2RC4], [mikebrady@eircom.net]) +AC_INIT([shairport-sync], [3.2RC5], [mikebrady@eircom.net]) AM_INIT_AUTOMAKE AC_CONFIG_SRCDIR([shairport.c]) AC_CONFIG_HEADERS([config.h]) From 09a16354853a4b53b34178a6a24ced45a8df1440 Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Fri, 27 Apr 2018 13:53:37 +0100 Subject: [PATCH 4/8] Update RELEASENOTES.md --- RELEASENOTES.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index bd9f285b..f0eed60e 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -1,3 +1,9 @@ +Version 3.2RC5 +==== +**Bug Fixes** +* When errors occur sending resend requests, back off for 0.5 seconds, rather than 10 seconds, and make the code actually work. +* Make the configuration options for including the dbus interface and the mpris interface be `--with-dbus-interface` and `--with-mpris-interface` as expected, not `--with-dbus` and `--with-mpris` as they actually were. + Version 3.2RC4 ==== **Bug Fixes** From 1a62b25de7f44fa2dcd61a8adf7cedfde4ffca9d Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Fri, 27 Apr 2018 14:18:50 +0100 Subject: [PATCH 5/8] Update TROUBLESHOOTING.md --- TROUBLESHOOTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/TROUBLESHOOTING.md b/TROUBLESHOOTING.md index 17a4a7fa..9b4cfb60 100644 --- a/TROUBLESHOOTING.md +++ b/TROUBLESHOOTING.md @@ -34,6 +34,9 @@ to the file `/etc/network/interfaces`. There are some more details in some the closed issues on this repository. +### Faulty WiFi +For an example of what it can take to track down a bad WiFi situation -- in this case, a slowly-dying base station -- please look at [this report](https://github.com/mikebrady/shairport-sync/issues/689). + ### Can't play from iTunes on Windows **Problem** From a35238b4ea8402d2e566f7c02e14daf4487c2d0a Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Sat, 28 Apr 2018 23:16:06 +0100 Subject: [PATCH 6/8] Update TROUBLESHOOTING.md --- TROUBLESHOOTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TROUBLESHOOTING.md b/TROUBLESHOOTING.md index 9b4cfb60..e80f9cb9 100644 --- a/TROUBLESHOOTING.md +++ b/TROUBLESHOOTING.md @@ -12,7 +12,7 @@ In this brief document will be listed some problems and some solutions, some pro **Problem** -Shairport Sync is installed and running, but sometimes it disappears from the network, and sometimes it suffers from long dropouts. +Shairport Sync is installed and running, but sometimes it disappears from the network, and sometimes it suffers from long dropouts. You can check WiFi throughput using, for example, https://thepi.io/how-to-use-your-raspberry-pi-to-monitor-broadband-speed/ **Possible Cause** @@ -35,7 +35,7 @@ to the file `/etc/network/interfaces`. There are some more details in some the closed issues on this repository. ### Faulty WiFi -For an example of what it can take to track down a bad WiFi situation -- in this case, a slowly-dying base station -- please look at [this report](https://github.com/mikebrady/shairport-sync/issues/689). +For an example of what it can take to track down a bad WiFi situation – in this case, a faulty WiFi adapter – please look at [this report](https://github.com/mikebrady/shairport-sync/issues/689). ### Can't play from iTunes on Windows From 47d3c5485ed58d666c60f0b680cc9bf111af2685 Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Sat, 28 Apr 2018 23:17:11 +0100 Subject: [PATCH 7/8] Update TROUBLESHOOTING.md --- TROUBLESHOOTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/TROUBLESHOOTING.md b/TROUBLESHOOTING.md index e80f9cb9..ce3397fb 100644 --- a/TROUBLESHOOTING.md +++ b/TROUBLESHOOTING.md @@ -10,9 +10,13 @@ In this brief document will be listed some problems and some solutions, some pro ### WiFi adapter running in power-saving / low-power mode +**Check Throughput** + + You can check WiFi throughput using, for example, https://thepi.io/how-to-use-your-raspberry-pi-to-monitor-broadband-speed/ + **Problem** -Shairport Sync is installed and running, but sometimes it disappears from the network, and sometimes it suffers from long dropouts. You can check WiFi throughput using, for example, https://thepi.io/how-to-use-your-raspberry-pi-to-monitor-broadband-speed/ +Shairport Sync is installed and running, but sometimes it disappears from the network, and sometimes it suffers from long dropouts. **Possible Cause** From 548d5da997cdd23f9b67f50c4060d225396bd073 Mon Sep 17 00:00:00 2001 From: Mike Brady Date: Sat, 5 May 2018 11:49:48 +0100 Subject: [PATCH 8/8] Restore the old way of determining latency for clients identifying with AirPlay user agent strings having a version of 353 (iOS 11.1.2) or earlier. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 88f789fb..e6fe5e60 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ # Process this file with autoconf to produce a configure script. AC_PREREQ([2.50]) -AC_INIT([shairport-sync], [3.2RC5], [mikebrady@eircom.net]) +AC_INIT([shairport-sync], [3.2RC6], [mikebrady@eircom.net]) AM_INIT_AUTOMAKE AC_CONFIG_SRCDIR([shairport.c]) AC_CONFIG_HEADERS([config.h])