Fix some silent issues that were highlighted by "infer"

2017-09-03 15:08:13 +01:00
parent 47886a33b4
commit 31a09bb368
4 changed files with 48 additions and 29 deletions
@@ -998,12 +998,13 @@ void alac_decode_frame(alac_file *alac, unsigned char *inbuffer, void *outbuffer

 alac_file *alac_create(int samplesize, int numchannels) {
  alac_file *newfile = malloc(sizeof(alac_file));
-
-  memset(newfile, 0, sizeof(alac_file));
-
-  newfile->samplesize = samplesize;
-  newfile->numchannels = numchannels;
-  newfile->bytespersample = (samplesize / 8) * numchannels;
-
+  if (newfile) {
+    memset(newfile, 0, sizeof(alac_file));
+    newfile->samplesize = samplesize;
+    newfile->numchannels = numchannels;
+    newfile->bytespersample = (samplesize / 8) * numchannels;
+  } else {
+    fprintf(stderr, "FIXME: can not allocate memory for a new file in alac_cxreate."); 
+  }
  return newfile;
 }