From 1d6d251ddd4452c78dc91110ba37a91035f01748 Mon Sep 17 00:00:00 2001
From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Wed, 26 Oct 2022 13:56:40 +0100
Subject: [PATCH] Move to using "latest" tags for the latest release and
 "rolling" for intermediate (non-release) updates on the master branch.

---
 .github/workflows/docker-build-on-push.yaml |  5 +++--
 .github/workflows/docker-build-on-tag.yaml  | 11 ++++++-----
 .github/workflows/stale.yaml                |  1 +
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/docker-build-on-push.yaml b/.github/workflows/docker-build-on-push.yaml
index 17a621a5..6879ad03 100644
--- a/.github/workflows/docker-build-on-push.yaml
+++ b/.github/workflows/docker-build-on-push.yaml
@@ -1,7 +1,7 @@
 # Builds a docker image when a commit is made. Also pushes the build if the branch is 'master' or 'development'.
 
 # Tag pattern
-# 'master'      - latest, latest-classic
+# 'master'      - rolling, rolling-classic
 # 'development' - development, development-classic
 
 name: Build and push docker (commit)
@@ -31,7 +31,7 @@ jobs:
       - name: Is branch "master"?
         if: ${{ env.SHAIRPORT_SYNC_BRANCH == 'master' }}
         run: |
-          echo "IMAGE_TAG_BASE=latest" >> $GITHUB_ENV
+          echo "IMAGE_TAG_BASE=rolling" >> $GITHUB_ENV
 
       - name: Is branch "development"?
         if: ${{ env.SHAIRPORT_SYNC_BRANCH == 'development' }}
@@ -74,3 +74,4 @@ jobs:
           tags: ${{ secrets.DOCKER_IMAGE_NAME }}:${{ env.IMAGE_TAG_BASE }}-classic
           build-args: |
             SHAIRPORT_SYNC_BRANCH=${{ env.SHAIRPORT_SYNC_BRANCH }}
+ 
diff --git a/.github/workflows/docker-build-on-tag.yaml b/.github/workflows/docker-build-on-tag.yaml
index 0e87ebd4..5f27fa3b 100644
--- a/.github/workflows/docker-build-on-tag.yaml
+++ b/.github/workflows/docker-build-on-tag.yaml
@@ -1,6 +1,6 @@
 # Builds & pushes a docker image when a tag is created.
 # Tag pattern: '[tag]' & '[tag]-classic'
-# 'stable' & 'stable-classic' also, when master tagged.
+# 'latest' & 'latest-classic' also, when master tagged.
 
 # Only pushes the tag when it matches one of the following patterns:
 # X, X.Y or X.Y.Z
@@ -38,7 +38,7 @@ jobs:
 
       - name: Is branch "master"?
         if: ${{ env.SHAIRPORT_SYNC_BRANCH == 'master' }}
-        run: echo "STABLE_TAG=true" >> $GITHUB_ENV
+        run: echo "LATEST_TAG=true" >> $GITHUB_ENV
 
       - name: Is branch "development"?
         if: ${{ env.SHAIRPORT_SYNC_BRANCH == 'development' }}
@@ -67,7 +67,7 @@ jobs:
           push: true
           tags: |
             ${{ secrets.DOCKER_IMAGE_NAME }}:${{ env.GIT_TAG }}
-            ${{ env.STABLE_TAG == 'true' && format('{0}:stable', secrets.DOCKER_IMAGE_NAME) || '' }}
+            ${{ env.LATEST_TAG == 'true' && format('{0}:latest', secrets.DOCKER_IMAGE_NAME) || '' }}
           build-args: |
             SHAIRPORT_SYNC_BRANCH=${{ env.SHAIRPORT_SYNC_BRANCH }}
             NQPTP_BRANCH=${{ env.NQPTP_BRANCH }}
@@ -81,6 +81,7 @@ jobs:
           push: true
           tags: |
             ${{ secrets.DOCKER_IMAGE_NAME }}:${{ env.GIT_TAG }}-classic
-            ${{ env.STABLE_TAG == 'true' && format('{0}:stable-classic', secrets.DOCKER_IMAGE_NAME) || '' }}
+            ${{ env.LATEST_TAG == 'true' && format('{0}:latest-classic', secrets.DOCKER_IMAGE_NAME) || '' }}
           build-args: |
-            SHAIRPORT_SYNC_BRANCH=${{ env.SHAIRPORT_SYNC_BRANCH }}
\ No newline at end of file
+            SHAIRPORT_SYNC_BRANCH=${{ env.SHAIRPORT_SYNC_BRANCH }}
+ 
diff --git a/.github/workflows/stale.yaml b/.github/workflows/stale.yaml
index 51658c01..d938bd71 100644
--- a/.github/workflows/stale.yaml
+++ b/.github/workflows/stale.yaml
@@ -19,3 +19,4 @@ jobs:
           # These are the defaults at the time of writing. https://github.com/marketplace/actions/close-stale-issues
           # days-before-stale: 45
           # days-before-close: 7
+