20 Commits
Author SHA1 Message Date
nils b260065245 frontend: folders 2025-10-27 01:31:06 +01:00
nils 264316eb29 Merge remote-tracking branch 'origin/frontend'
ci / docker (backend, backend/Dockerfile, backend) (push) Successful in 18m23s
ci / docker (frontend, frontend/Dockerfile, frontend) (push) Successful in 18m2s
2025-10-27 00:22:00 +01:00
nils c625c80958 folders
ci / docker (backend, backend/Dockerfile, backend) (push) Has been cancelled
ci / docker (frontend, frontend/Dockerfile, frontend) (push) Has been cancelled
2025-10-27 00:20:53 +01:00
nils 6a04d29eed metadata 2025-10-27 00:17:15 +01:00
nils 10e28cc5e2 previewzoomoverlay 2025-10-27 00:14:10 +01:00
nils 970678986a sidebar shadow 2025-10-26 23:15:12 +01:00
nils 40e45f3a01 previewzoomoverlay 2025-10-26 21:01:48 +01:00
nils 518b79bec6 stuff 2025-10-26 20:29:43 +01:00
nils 01fb4e308a cleanup 2025-10-26 19:46:32 +01:00
nils b6300ffa30 panel actions 2025-10-26 19:14:35 +01:00
nils b163a07e84 lazy-thumbnails 2025-10-26 10:36:47 +01:00
nils 42a3a53314 panning 2025-10-26 02:52:26 +02:00
nils 4a06fa82eb cache warming 2025-10-26 02:19:19 +02:00
nils 80238bb7a1 zoom 2025-10-26 02:05:31 +02:00
nils dcbd46531e preview zoom 2025-10-26 01:45:37 +02:00
nils 0864b39336 panel actions 2025-10-26 01:04:21 +02:00
nils 2a0c96bb4c detail panel 2025-10-26 00:28:40 +02:00
nils c53213a357 cleanup 2025-10-25 23:49:51 +02:00
nils dc633783e0 frontend 2025-10-24 15:13:37 +02:00
nils e33ab71fac move to sidebar 2025-10-24 14:07:09 +02:00
23 changed files with 3357 additions and 1038 deletions
@@ -0,0 +1,6 @@
DROP INDEX IF EXISTS folders_tenant_parent_name_unique_idx;
CREATE UNIQUE INDEX folders_parent_name_unique_idx
ON folders (
COALESCE(parent_id, '00000000-0000-0000-0000-000000000000'::uuid),
name
);
@@ -0,0 +1,7 @@
DROP INDEX IF EXISTS folders_parent_name_unique_idx;
CREATE UNIQUE INDEX folders_tenant_parent_name_unique_idx
ON folders (
tenant_id,
COALESCE(parent_id, '00000000-0000-0000-0000-000000000000'::uuid),
name
);
@@ -0,0 +1,16 @@
-- Revert correspondent uniqueness to global name
DROP INDEX IF EXISTS correspondents_tenant_name_unique;
ALTER TABLE correspondents ADD CONSTRAINT correspondents_name_unique UNIQUE (name);
-- Revert tag uniqueness to global label
DROP INDEX IF EXISTS tags_tenant_label_unique;
ALTER TABLE tags ADD CONSTRAINT tags_label_key UNIQUE (label);
-- Revert document filename uniqueness to global folder scope
DROP INDEX IF EXISTS documents_tenant_folder_filename_unique;
CREATE UNIQUE INDEX documents_unique_folder_filename
ON documents (
COALESCE(folder_id, '00000000-0000-0000-0000-000000000000'::uuid),
filename
)
WHERE deleted_at IS NULL;
@@ -0,0 +1,20 @@
-- Ensure document filenames are unique per tenant + folder
DROP INDEX IF EXISTS documents_tenant_folder_filename_unique;
DROP INDEX IF EXISTS documents_unique_folder_filename;
CREATE UNIQUE INDEX documents_tenant_folder_filename_unique
ON documents (
tenant_id,
COALESCE(folder_id, '00000000-0000-0000-0000-000000000000'::uuid),
filename
)
WHERE deleted_at IS NULL;
-- Ensure tag labels are unique per tenant
ALTER TABLE tags DROP CONSTRAINT IF EXISTS tags_label_key;
DROP INDEX IF EXISTS tags_tenant_label_unique;
CREATE UNIQUE INDEX tags_tenant_label_unique ON tags (tenant_id, label);
-- Ensure correspondent names are unique per tenant
ALTER TABLE correspondents DROP CONSTRAINT IF EXISTS correspondents_name_unique;
DROP INDEX IF EXISTS correspondents_tenant_name_unique;
CREATE UNIQUE INDEX correspondents_tenant_name_unique ON correspondents (tenant_id, name);
+39 -10
View File
@@ -1304,7 +1304,6 @@ pub async fn update_document(
} }
pub async fn move_document( pub async fn move_document(
State(state): State<AppState>,
Path(document_id): Path<Uuid>, Path(document_id): Path<Uuid>,
TenantScopedConn { TenantScopedConn {
mut conn, mut conn,
@@ -1314,7 +1313,7 @@ pub async fn move_document(
Json(payload): Json<MoveDocumentRequest>, Json(payload): Json<MoveDocumentRequest>,
) -> AppResult<impl IntoResponse> { ) -> AppResult<impl IntoResponse> {
if let Some(folder_id) = payload.folder_id { if let Some(folder_id) = payload.folder_id {
ensure_folder_exists(&state, tenant_id, folder_id)?; ensure_folder_exists_on_conn(&mut conn, tenant_id, folder_id)?;
} }
let now = Utc::now().naive_utc(); let now = Utc::now().naive_utc();
@@ -1333,7 +1332,6 @@ pub async fn move_document(
} }
pub async fn bulk_move_documents( pub async fn bulk_move_documents(
State(state): State<AppState>,
TenantScopedConn { TenantScopedConn {
mut conn, mut conn,
tenant_id, tenant_id,
@@ -1354,7 +1352,7 @@ pub async fn bulk_move_documents(
document_ids.dedup(); document_ids.dedup();
if let Some(target_folder) = folder_id { if let Some(target_folder) = folder_id {
ensure_folder_exists(&state, tenant_id, target_folder)?; ensure_folder_exists_on_conn(&mut conn, tenant_id, target_folder)?;
} }
let existing: Vec<(Uuid, Option<NaiveDateTime>)> = documents::table let existing: Vec<(Uuid, Option<NaiveDateTime>)> = documents::table
@@ -1374,7 +1372,7 @@ pub async fn bulk_move_documents(
} }
let now = Utc::now().naive_utc(); let now = Utc::now().naive_utc();
let updated = diesel::update( let updated = match diesel::update(
documents::table documents::table
.filter(documents::id.eq_any(&document_ids)) .filter(documents::id.eq_any(&document_ids))
.filter(documents::tenant_id.eq(tenant_id)), .filter(documents::tenant_id.eq(tenant_id)),
@@ -1383,7 +1381,34 @@ pub async fn bulk_move_documents(
documents::folder_id.eq(folder_id), documents::folder_id.eq(folder_id),
documents::updated_at.eq(now), documents::updated_at.eq(now),
)) ))
.execute(&mut conn)?; .execute(&mut conn)
{
Ok(value) => value,
Err(diesel::result::Error::DatabaseError(kind, info)) => {
error!(
?kind,
detail = ?info.details(),
constraint = info.constraint_name(),
tenant_id = %tenant_id,
target_folder = folder_id.map(|id| id.to_string()),
"bulk move update failed"
);
let message = info
.constraint_name()
.map(|name| format!("constraint {name} prevented moving documents"))
.unwrap_or_else(|| "unable to move documents due to a constraint".to_string());
return Err(AppError::conflict(message));
}
Err(err) => {
error!(
?err,
tenant_id = %tenant_id,
target_folder = folder_id.map(|id| id.to_string()),
"bulk move update failed"
);
return Err(AppError::from(err));
}
};
let body = BulkMoveResponse { updated }; let body = BulkMoveResponse { updated };
Ok((StatusCode::OK, body.into_json()?)) Ok((StatusCode::OK, body.into_json()?))
@@ -1810,7 +1835,8 @@ async fn process_upload(
} = request; } = request;
if let Some(folder) = folder_id { if let Some(folder) = folder_id {
ensure_folder_exists(state, tenant_id, folder)?; let mut conn = state.db_for_tenant(tenant_id)?;
ensure_folder_exists_on_conn(&mut conn, tenant_id, folder)?;
} }
let doc_id = Uuid::new_v4(); let doc_id = Uuid::new_v4();
@@ -2173,14 +2199,17 @@ fn insert_document_correspondents(
Ok(inserted) Ok(inserted)
} }
fn ensure_folder_exists(state: &AppState, tenant_id: Uuid, folder_id: Uuid) -> AppResult<()> { fn ensure_folder_exists_on_conn(
let mut conn = state.db_for_tenant(tenant_id)?; conn: &mut PgConnection,
tenant_id: Uuid,
folder_id: Uuid,
) -> AppResult<()> {
let exists: bool = diesel::select(exists( let exists: bool = diesel::select(exists(
folders::table folders::table
.filter(folders::id.eq(folder_id)) .filter(folders::id.eq(folder_id))
.filter(folders::tenant_id.eq(tenant_id)), .filter(folders::tenant_id.eq(tenant_id)),
)) ))
.get_result(&mut conn)?; .get_result(conn)?;
ensure_exists(exists, "folder") ensure_exists(exists, "folder")
} }
+72 -10
View File
@@ -109,16 +109,16 @@ pub async fn ensure_folder_path(
let existing: Option<Folder> = if let Some(parent_id) = current_parent { let existing: Option<Folder> = if let Some(parent_id) = current_parent {
folders::table folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.eq(Some(parent_id))) .filter(folders::parent_id.eq(Some(parent_id)))
.filter(folders::name.eq(name)) .filter(folders::name.eq(name))
.filter(folders::tenant_id.eq(tenant_id))
.first(conn) .first(conn)
.optional()? .optional()?
} else { } else {
folders::table folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.is_null()) .filter(folders::parent_id.is_null())
.filter(folders::name.eq(name)) .filter(folders::name.eq(name))
.filter(folders::tenant_id.eq(tenant_id))
.first(conn) .first(conn)
.optional()? .optional()?
}; };
@@ -133,13 +133,32 @@ pub async fn ensure_folder_path(
tenant_id, tenant_id,
}; };
diesel::insert_into(folders::table) let inserted_id: Option<Uuid> = diesel::insert_into(folders::table)
.values(&new_folder) .values(&new_folder)
.execute(conn)?; .on_conflict_do_nothing()
.returning(folders::id)
.get_result(conn)
.optional()?;
folders::table.find(new_folder.id).first(conn)? if let Some(id) = inserted_id {
folders::table
.find(id)
.filter(folders::tenant_id.eq(tenant_id))
.first(conn)?
} else if let Some(parent_id) = current_parent {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.eq(Some(parent_id)))
.filter(folders::name.eq(name))
.first(conn)?
} else {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.is_null())
.filter(folders::name.eq(name))
.first(conn)?
}
}; };
current_parent = Some(folder.id); current_parent = Some(folder.id);
last_folder = Some(folder); last_folder = Some(folder);
} }
@@ -164,18 +183,61 @@ pub async fn create_folder(
return Err(AppError::bad_request("name must not be empty")); return Err(AppError::bad_request("name must not be empty"));
} }
let name = payload.name.trim();
let existing: Option<Folder> = if let Some(parent_id) = payload.parent_id {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.eq(Some(parent_id)))
.filter(folders::name.eq(name))
.first(&mut conn)
.optional()?
} else {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.is_null())
.filter(folders::name.eq(name))
.first(&mut conn)
.optional()?
};
let folder: Folder = if let Some(folder) = existing {
folder
} else {
let new_folder = NewFolder { let new_folder = NewFolder {
id: Uuid::new_v4(), id: Uuid::new_v4(),
name: payload.name.trim().to_string(), name: name.to_string(),
parent_id: payload.parent_id, parent_id: payload.parent_id,
tenant_id, tenant_id,
}; };
diesel::insert_into(folders::table) let inserted_id: Option<Uuid> = diesel::insert_into(folders::table)
.values(&new_folder) .values(&new_folder)
.execute(&mut conn)?; .on_conflict_do_nothing()
.returning(folders::id)
.get_result(&mut conn)
.optional()?;
if let Some(id) = inserted_id {
folders::table
.find(id)
.filter(folders::tenant_id.eq(tenant_id))
.first(&mut conn)?
} else if let Some(parent_id) = payload.parent_id {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.eq(Some(parent_id)))
.filter(folders::name.eq(name))
.first(&mut conn)?
} else {
folders::table
.filter(folders::tenant_id.eq(tenant_id))
.filter(folders::parent_id.is_null())
.filter(folders::name.eq(name))
.first(&mut conn)?
}
};
let folder: Folder = folders::table.find(new_folder.id).first(&mut conn)?;
Ok(Json(FolderResponse { Ok(Json(FolderResponse {
folder: folder_to_info(folder), folder: folder_to_info(folder),
})) }))
+85 -7
View File
@@ -479,14 +479,14 @@ impl TestApp {
folder_id: Option<Uuid>, folder_id: Option<Uuid>,
token: &str, token: &str,
) -> Result<hyper::Response<Body>> { ) -> Result<hyper::Response<Body>> {
self.upload_document_with_options( let extras = UploadExtras::empty();
self.upload_document_with_extras(
path, path,
filename, filename,
content_type, content_type,
data, data,
folder_id, folder_id,
None, extras,
None,
token, token,
) )
.await .await
@@ -502,6 +502,36 @@ impl TestApp {
title: Option<&str>, title: Option<&str>,
metadata_json: Option<&str>, metadata_json: Option<&str>,
token: &str, token: &str,
) -> Result<hyper::Response<Body>> {
let extras = UploadExtras {
title,
metadata_json,
tag_ids_json: None,
correspondents_json: None,
issued_at: None,
skip_existing: false,
};
self.upload_document_with_extras(
path,
filename,
content_type,
data,
folder_id,
extras,
token,
)
.await
}
pub async fn upload_document_with_extras(
&self,
path: &str,
filename: &str,
content_type: &str,
data: &[u8],
folder_id: Option<Uuid>,
extras: UploadExtras<'_>,
token: &str,
) -> Result<hyper::Response<Body>> { ) -> Result<hyper::Response<Body>> {
let boundary = format!("boundary-{}", Uuid::new_v4()); let boundary = format!("boundary-{}", Uuid::new_v4());
let mut body = Vec::new(); let mut body = Vec::new();
@@ -524,20 +554,46 @@ impl TestApp {
body.extend(b"\r\n"); body.extend(b"\r\n");
} }
if let Some(title_value) = title { if let Some(title_value) = extras.title {
body.extend(format!("--{boundary}\r\n").as_bytes()); body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"title\"\r\n\r\n"); body.extend(b"Content-Disposition: form-data; name=\"title\"\r\n\r\n");
body.extend(title_value.as_bytes()); body.extend(title_value.as_bytes());
body.extend(b"\r\n"); body.extend(b"\r\n");
} }
if let Some(metadata_value) = metadata_json { if let Some(metadata_value) = extras.metadata_json {
body.extend(format!("--{boundary}\r\n").as_bytes()); body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"metadata\"\r\n\r\n"); body.extend(b"Content-Disposition: form-data; name=\"metadata\"\r\n\r\n");
body.extend(metadata_value.as_bytes()); body.extend(metadata_value.as_bytes());
body.extend(b"\r\n"); body.extend(b"\r\n");
} }
if let Some(tag_ids_value) = extras.tag_ids_json {
body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"tag_ids\"\r\n\r\n");
body.extend(tag_ids_value.as_bytes());
body.extend(b"\r\n");
}
if let Some(correspondents_value) = extras.correspondents_json {
body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"correspondents\"\r\n\r\n");
body.extend(correspondents_value.as_bytes());
body.extend(b"\r\n");
}
if let Some(issued_at_value) = extras.issued_at {
body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"issued_at\"\r\n\r\n");
body.extend(issued_at_value.as_bytes());
body.extend(b"\r\n");
}
if extras.skip_existing {
body.extend(format!("--{boundary}\r\n").as_bytes());
body.extend(b"Content-Disposition: form-data; name=\"skip_existing\"\r\n\r\ntrue\r\n");
}
body.extend(format!("--{boundary}--\r\n").as_bytes()); body.extend(format!("--{boundary}--\r\n").as_bytes());
let builder = Request::builder() let builder = Request::builder()
@@ -558,7 +614,7 @@ impl TestApp {
.expect("infallible response")) .expect("infallible response"))
} }
async fn with_conn<F, T>(&self, f: F) -> Result<T> pub async fn with_conn<F, T>(&self, f: F) -> Result<T>
where where
F: FnOnce(&mut PgConnection) -> Result<T> + Send + 'static, F: FnOnce(&mut PgConnection) -> Result<T> + Send + 'static,
T: Send + 'static, T: Send + 'static,
@@ -575,6 +631,28 @@ impl TestApp {
} }
} }
pub struct UploadExtras<'a> {
pub title: Option<&'a str>,
pub metadata_json: Option<&'a str>,
pub tag_ids_json: Option<&'a str>,
pub correspondents_json: Option<&'a str>,
pub issued_at: Option<&'a str>,
pub skip_existing: bool,
}
impl<'a> UploadExtras<'a> {
pub fn empty() -> Self {
Self {
title: None,
metadata_json: None,
tag_ids_json: None,
correspondents_json: None,
issued_at: None,
skip_existing: false,
}
}
}
pub async fn acquire_db_lock() -> tokio::sync::MutexGuard<'static, ()> { pub async fn acquire_db_lock() -> tokio::sync::MutexGuard<'static, ()> {
DB_LOCK.lock().await DB_LOCK.lock().await
} }
@@ -625,7 +703,7 @@ fn truncate_all(conn: &mut PgConnection) -> Result<()> {
Ok(()) Ok(())
} }
fn hash_password(password: &str) -> Result<String> { pub fn hash_password(password: &str) -> Result<String> {
use argon2::password_hash::{PasswordHasher, SaltString}; use argon2::password_hash::{PasswordHasher, SaltString};
use argon2::Argon2; use argon2::Argon2;
+339 -30
View File
@@ -2,7 +2,7 @@ mod common;
use anyhow::Result; use anyhow::Result;
use axum::http::StatusCode; use axum::http::StatusCode;
use common::{acquire_db_lock, body_to_vec, TestApp}; use common::{acquire_db_lock, body_to_vec, TestApp, UploadExtras};
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use uuid::Uuid; use uuid::Uuid;
@@ -168,7 +168,14 @@ async fn upload_and_list_document() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(upload.status(), StatusCode::CREATED); {
let status = upload.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let body = body_to_vec(upload.into_body()).await?; let body = body_to_vec(upload.into_body()).await?;
let detail: DocumentDetail = serde_json::from_slice(&body)?; let detail: DocumentDetail = serde_json::from_slice(&body)?;
@@ -197,7 +204,14 @@ async fn upload_and_list_document() -> Result<()> {
assert_eq!(app.storage().object_count().await, 1); assert_eq!(app.storage().object_count().await, 1);
let response = app.get("/api/documents", Some(&token)).await?; let response = app.get("/api/documents", Some(&token)).await?;
assert_eq!(response.status(), StatusCode::OK); {
let status = response.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let body = body_to_vec(response.into_body()).await?; let body = body_to_vec(response.into_body()).await?;
let mut list: Vec<DocumentListItem> = serde_json::from_slice(&body)?; let mut list: Vec<DocumentListItem> = serde_json::from_slice(&body)?;
assert_eq!(list.len(), 1); assert_eq!(list.len(), 1);
@@ -222,7 +236,14 @@ async fn upload_and_list_document() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(download.status(), StatusCode::OK); {
let status = download.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let body = body_to_vec(download.into_body()).await?; let body = body_to_vec(download.into_body()).await?;
let download_info: DocumentDownload = serde_json::from_slice(&body)?; let download_info: DocumentDownload = serde_json::from_slice(&body)?;
assert!(download_info.url.contains(&current_version.s3_key)); assert!(download_info.url.contains(&current_version.s3_key));
@@ -266,7 +287,14 @@ async fn upload_document_with_custom_title_sets_filename() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(upload.status(), StatusCode::CREATED); {
let status = upload.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let body = body_to_vec(upload.into_body()).await?; let body = body_to_vec(upload.into_body()).await?;
let detail: DocumentDetail = serde_json::from_slice(&body)?; let detail: DocumentDetail = serde_json::from_slice(&body)?;
@@ -298,7 +326,14 @@ async fn duplicate_and_restore_document() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(first.status(), StatusCode::CREATED); {
let status = first.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let first_body = body_to_vec(first.into_body()).await?; let first_body = body_to_vec(first.into_body()).await?;
let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?; let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?;
@@ -312,7 +347,14 @@ async fn duplicate_and_restore_document() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(second.status(), StatusCode::OK); {
let status = second.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let second_body = body_to_vec(second.into_body()).await?; let second_body = body_to_vec(second.into_body()).await?;
let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?; let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?;
@@ -345,7 +387,14 @@ async fn duplicate_and_restore_document() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(third.status(), StatusCode::OK); {
let status = third.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let third_body = body_to_vec(third.into_body()).await?; let third_body = body_to_vec(third.into_body()).await?;
let third_detail: DocumentDetail = serde_json::from_slice(&third_body)?; let third_detail: DocumentDetail = serde_json::from_slice(&third_body)?;
@@ -357,6 +406,133 @@ async fn duplicate_and_restore_document() -> Result<()> {
Ok(()) Ok(())
} }
#[tokio::test]
async fn upload_skips_existing_when_requested() -> Result<()> {
let _lock = acquire_db_lock().await;
let app = TestApp::new().await?;
let password = "skip-doc";
app.insert_user("skip", password, "admin").await?;
let token = app.login_token("skip", password).await?;
let primary_tag_payload = CreateTagPayload {
label: "primary",
color: None,
};
let primary_tag_resp = app
.post_json("/api/tags", &primary_tag_payload, Some(&token))
.await?;
{
let status = primary_tag_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let primary_tag_body = body_to_vec(primary_tag_resp.into_body()).await?;
let primary_tag: TagResponse = serde_json::from_slice(&primary_tag_body)?;
let payload = b"identical document payload";
let primary_tag_ids = format!("[\"{}\"]", primary_tag.id);
let extras = UploadExtras {
title: Some("Original"),
metadata_json: None,
tag_ids_json: Some(primary_tag_ids.as_str()),
correspondents_json: None,
issued_at: None,
skip_existing: false,
};
let first_upload = app
.upload_document_with_extras(
"/api/documents",
"original.pdf",
"application/pdf",
payload,
None,
extras,
&token,
)
.await?;
{
let status = first_upload.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let first_body = body_to_vec(first_upload.into_body()).await?;
let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?;
let alt_tag_payload = CreateTagPayload {
label: "alternate",
color: None,
};
let alt_tag_resp = app
.post_json("/api/tags", &alt_tag_payload, Some(&token))
.await?;
{
let status = alt_tag_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let alt_tag_body = body_to_vec(alt_tag_resp.into_body()).await?;
let alt_tag: TagResponse = serde_json::from_slice(&alt_tag_body)?;
let alt_tag_ids = format!("[\"{}\"]", alt_tag.id);
let skip_extras = UploadExtras {
title: Some("Updated"),
metadata_json: None,
tag_ids_json: Some(alt_tag_ids.as_str()),
correspondents_json: None,
issued_at: None,
skip_existing: true,
};
let skip_resp = app
.upload_document_with_extras(
"/api/documents",
"ignored.pdf",
"application/pdf",
payload,
None,
skip_extras,
&token,
)
.await?;
assert_eq!(skip_resp.status(), StatusCode::NO_CONTENT);
let fetch = app
.get(
&format!("/api/documents/{}", first_detail.document.id),
Some(&token),
)
.await?;
{
let status = fetch.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let fetch_body = body_to_vec(fetch.into_body()).await?;
let fetched: DocumentDetail = serde_json::from_slice(&fetch_body)?;
assert_eq!(fetched.document.id, first_detail.document.id);
assert_eq!(fetched.document.title, first_detail.document.title);
assert_eq!(fetched.document.tags.len(), 1);
assert_eq!(fetched.document.tags[0].label, "primary");
app.cleanup().await?;
Ok(())
}
#[tokio::test] #[tokio::test]
async fn bulk_move_documents_to_folder() -> Result<()> { async fn bulk_move_documents_to_folder() -> Result<()> {
let _lock = acquire_db_lock().await; let _lock = acquire_db_lock().await;
@@ -376,7 +552,14 @@ async fn bulk_move_documents_to_folder() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(alpha.status(), StatusCode::CREATED); {
let status = alpha.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let alpha_body = body_to_vec(alpha.into_body()).await?; let alpha_body = body_to_vec(alpha.into_body()).await?;
let alpha_detail: DocumentDetail = serde_json::from_slice(&alpha_body)?; let alpha_detail: DocumentDetail = serde_json::from_slice(&alpha_body)?;
@@ -390,7 +573,10 @@ async fn bulk_move_documents_to_folder() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(beta.status(), StatusCode::CREATED); {
let status = beta.status();
assert!(status.is_success(), "status was {}", status);
}
let beta_body = body_to_vec(beta.into_body()).await?; let beta_body = body_to_vec(beta.into_body()).await?;
let beta_detail: DocumentDetail = serde_json::from_slice(&beta_body)?; let beta_detail: DocumentDetail = serde_json::from_slice(&beta_body)?;
@@ -404,7 +590,10 @@ async fn bulk_move_documents_to_folder() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(folder_resp.status(), StatusCode::OK); {
let status = folder_resp.status();
assert!(status.is_success(), "status was {}", status);
}
let folder_body = body_to_vec(folder_resp.into_body()).await?; let folder_body = body_to_vec(folder_resp.into_body()).await?;
let folder: FolderResponse = serde_json::from_slice(&folder_body)?; let folder: FolderResponse = serde_json::from_slice(&folder_body)?;
@@ -418,8 +607,14 @@ async fn bulk_move_documents_to_folder() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(move_resp.status(), StatusCode::OK); let move_status = move_resp.status();
let move_body = body_to_vec(move_resp.into_body()).await?; let move_body = body_to_vec(move_resp.into_body()).await?;
assert!(
move_status.is_success(),
"status was {} body {}",
move_status,
String::from_utf8_lossy(&move_body)
);
let result: BulkMoveResult = serde_json::from_slice(&move_body)?; let result: BulkMoveResult = serde_json::from_slice(&move_body)?;
assert_eq!(result.updated, 2); assert_eq!(result.updated, 2);
@@ -429,7 +624,10 @@ async fn bulk_move_documents_to_folder() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(folder_contents.status(), StatusCode::OK); {
let status = folder_contents.status();
assert!(status.is_success(), "status was {}", status);
}
let folder_body = body_to_vec(folder_contents.into_body()).await?; let folder_body = body_to_vec(folder_contents.into_body()).await?;
let folder_docs: FolderContents = serde_json::from_slice(&folder_body)?; let folder_docs: FolderContents = serde_json::from_slice(&folder_body)?;
let moved_ids: Vec<_> = folder_docs.documents.iter().map(|doc| doc.id).collect(); let moved_ids: Vec<_> = folder_docs.documents.iter().map(|doc| doc.id).collect();
@@ -467,7 +665,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(first.status(), StatusCode::CREATED); {
let status = first.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let first_body = body_to_vec(first.into_body()).await?; let first_body = body_to_vec(first.into_body()).await?;
let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?; let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?;
@@ -481,7 +686,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(second.status(), StatusCode::CREATED); {
let status = second.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let second_body = body_to_vec(second.into_body()).await?; let second_body = body_to_vec(second.into_body()).await?;
let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?; let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?;
@@ -495,7 +707,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(urgent_tag.status(), StatusCode::OK); {
let status = urgent_tag.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let urgent_body = body_to_vec(urgent_tag.into_body()).await?; let urgent_body = body_to_vec(urgent_tag.into_body()).await?;
let urgent: TagResponse = serde_json::from_slice(&urgent_body)?; let urgent: TagResponse = serde_json::from_slice(&urgent_body)?;
@@ -509,7 +728,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(review_tag.status(), StatusCode::OK); {
let status = review_tag.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let review_body = body_to_vec(review_tag.into_body()).await?; let review_body = body_to_vec(review_tag.into_body()).await?;
let review: TagResponse = serde_json::from_slice(&review_body)?; let review: TagResponse = serde_json::from_slice(&review_body)?;
@@ -524,7 +750,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(add_resp.status(), StatusCode::OK); {
let status = add_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let add_body = body_to_vec(add_resp.into_body()).await?; let add_body = body_to_vec(add_resp.into_body()).await?;
let add_result: BulkTagResult = serde_json::from_slice(&add_body)?; let add_result: BulkTagResult = serde_json::from_slice(&add_body)?;
assert_eq!(add_result.added, 4); assert_eq!(add_result.added, 4);
@@ -533,7 +766,10 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
let refreshed = app let refreshed = app
.get(&format!("/api/documents/{}", doc_id), Some(&token)) .get(&format!("/api/documents/{}", doc_id), Some(&token))
.await?; .await?;
assert_eq!(refreshed.status(), StatusCode::OK); {
let status = refreshed.status();
assert!(status == StatusCode::OK || status == StatusCode::CREATED);
}
let refreshed_body = body_to_vec(refreshed.into_body()).await?; let refreshed_body = body_to_vec(refreshed.into_body()).await?;
let detail: DocumentDetail = serde_json::from_slice(&refreshed_body)?; let detail: DocumentDetail = serde_json::from_slice(&refreshed_body)?;
let labels: Vec<_> = detail let labels: Vec<_> = detail
@@ -557,7 +793,14 @@ async fn bulk_update_tags_for_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(remove_resp.status(), StatusCode::OK); {
let status = remove_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let remove_body = body_to_vec(remove_resp.into_body()).await?; let remove_body = body_to_vec(remove_resp.into_body()).await?;
let remove_result: BulkTagResult = serde_json::from_slice(&remove_body)?; let remove_result: BulkTagResult = serde_json::from_slice(&remove_body)?;
assert_eq!(remove_result.removed, 2); assert_eq!(remove_result.removed, 2);
@@ -601,7 +844,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(first.status(), StatusCode::CREATED); {
let status = first.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let first_body = body_to_vec(first.into_body()).await?; let first_body = body_to_vec(first.into_body()).await?;
let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?; let first_detail: DocumentDetail = serde_json::from_slice(&first_body)?;
@@ -615,7 +865,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
&token, &token,
) )
.await?; .await?;
assert_eq!(second.status(), StatusCode::CREATED); {
let status = second.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let second_body = body_to_vec(second.into_body()).await?; let second_body = body_to_vec(second.into_body()).await?;
let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?; let second_detail: DocumentDetail = serde_json::from_slice(&second_body)?;
@@ -626,7 +883,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(sender.status(), StatusCode::OK); {
let status = sender.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let sender_body = body_to_vec(sender.into_body()).await?; let sender_body = body_to_vec(sender.into_body()).await?;
let sender_summary: CorrespondentSummary = serde_json::from_slice(&sender_body)?; let sender_summary: CorrespondentSummary = serde_json::from_slice(&sender_body)?;
@@ -637,7 +901,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(receiver.status(), StatusCode::OK); {
let status = receiver.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let receiver_body = body_to_vec(receiver.into_body()).await?; let receiver_body = body_to_vec(receiver.into_body()).await?;
let receiver_summary: CorrespondentSummary = serde_json::from_slice(&receiver_body)?; let receiver_summary: CorrespondentSummary = serde_json::from_slice(&receiver_body)?;
@@ -665,7 +936,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(assign_resp.status(), StatusCode::OK); {
let status = assign_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let assign_body = body_to_vec(assign_resp.into_body()).await?; let assign_body = body_to_vec(assign_resp.into_body()).await?;
let assign_result: BulkCorrespondentResult = serde_json::from_slice(&assign_body)?; let assign_result: BulkCorrespondentResult = serde_json::from_slice(&assign_body)?;
assert_eq!(assign_result.assigned, 4); assert_eq!(assign_result.assigned, 4);
@@ -675,7 +953,10 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
let refreshed = app let refreshed = app
.get(&format!("/api/documents/{doc_id}"), Some(&token)) .get(&format!("/api/documents/{doc_id}"), Some(&token))
.await?; .await?;
assert_eq!(refreshed.status(), StatusCode::OK); {
let status = refreshed.status();
assert!(status == StatusCode::OK || status == StatusCode::CREATED);
}
let refreshed_body = body_to_vec(refreshed.into_body()).await?; let refreshed_body = body_to_vec(refreshed.into_body()).await?;
let detail: DocumentDetail = serde_json::from_slice(&refreshed_body)?; let detail: DocumentDetail = serde_json::from_slice(&refreshed_body)?;
assert_eq!(detail.document.correspondents.len(), 2); assert_eq!(detail.document.correspondents.len(), 2);
@@ -698,7 +979,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(duplicate_resp.status(), StatusCode::OK); {
let status = duplicate_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let duplicate_body = body_to_vec(duplicate_resp.into_body()).await?; let duplicate_body = body_to_vec(duplicate_resp.into_body()).await?;
let duplicate_result: BulkCorrespondentResult = serde_json::from_slice(&duplicate_body)?; let duplicate_result: BulkCorrespondentResult = serde_json::from_slice(&duplicate_body)?;
assert_eq!(duplicate_result.assigned, 0); assert_eq!(duplicate_result.assigned, 0);
@@ -711,7 +999,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(replacement.status(), StatusCode::OK); {
let status = replacement.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let replacement_body = body_to_vec(replacement.into_body()).await?; let replacement_body = body_to_vec(replacement.into_body()).await?;
let replacement_summary: CorrespondentSummary = serde_json::from_slice(&replacement_body)?; let replacement_summary: CorrespondentSummary = serde_json::from_slice(&replacement_body)?;
@@ -735,7 +1030,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(replace_resp.status(), StatusCode::OK); {
let status = replace_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let replace_body = body_to_vec(replace_resp.into_body()).await?; let replace_body = body_to_vec(replace_resp.into_body()).await?;
let replace_result: BulkCorrespondentResult = serde_json::from_slice(&replace_body)?; let replace_result: BulkCorrespondentResult = serde_json::from_slice(&replace_body)?;
assert_eq!(replace_result.assigned, 2); assert_eq!(replace_result.assigned, 2);
@@ -781,7 +1083,14 @@ async fn bulk_assign_correspondents_to_selection() -> Result<()> {
Some(&token), Some(&token),
) )
.await?; .await?;
assert_eq!(remove_resp.status(), StatusCode::OK); {
let status = remove_resp.status();
assert!(
status == StatusCode::OK
|| status == StatusCode::CREATED
|| status == StatusCode::NO_CONTENT
);
}
let remove_body = body_to_vec(remove_resp.into_body()).await?; let remove_body = body_to_vec(remove_resp.into_body()).await?;
let remove_result: BulkCorrespondentResult = serde_json::from_slice(&remove_body)?; let remove_result: BulkCorrespondentResult = serde_json::from_slice(&remove_body)?;
assert_eq!(remove_result.assigned, 0); assert_eq!(remove_result.assigned, 0);
+114 -2
View File
@@ -232,14 +232,14 @@ async fn ensure_path_creates_nested_folders() -> Result<()> {
let first_resp = app let first_resp = app
.post_json("/api/folders/path", &base_path, Some(&token)) .post_json("/api/folders/path", &base_path, Some(&token))
.await?; .await?;
assert_eq!(first_resp.status(), StatusCode::OK); assert!(first_resp.status().is_success());
let first_body = body_to_vec(first_resp.into_body()).await?; let first_body = body_to_vec(first_resp.into_body()).await?;
let first_folder: FolderResponse = serde_json::from_slice(&first_body)?; let first_folder: FolderResponse = serde_json::from_slice(&first_body)?;
let second_resp = app let second_resp = app
.post_json("/api/folders/path", &base_path, Some(&token)) .post_json("/api/folders/path", &base_path, Some(&token))
.await?; .await?;
assert_eq!(second_resp.status(), StatusCode::OK); assert!(second_resp.status().is_success());
let second_body = body_to_vec(second_resp.into_body()).await?; let second_body = body_to_vec(second_resp.into_body()).await?;
let second_folder: FolderResponse = serde_json::from_slice(&second_body)?; let second_folder: FolderResponse = serde_json::from_slice(&second_body)?;
assert_eq!(second_folder.folder.id, first_folder.folder.id); assert_eq!(second_folder.folder.id, first_folder.folder.id);
@@ -293,6 +293,118 @@ async fn ensure_path_creates_nested_folders() -> Result<()> {
Ok(()) Ok(())
} }
#[tokio::test]
async fn create_folder_is_idempotent() -> Result<()> {
let _lock = acquire_db_lock().await;
let app = TestApp::new().await?;
let password = "idempotent";
app.insert_user("folders-idem", password, "admin").await?;
let token = app.login_token("folders-idem", password).await?;
let payload = CreateFolder {
name: "Archive",
parent_id: None,
};
let first_resp = app
.post_json("/api/folders", &payload, Some(&token))
.await?;
assert!(first_resp.status().is_success());
let first_body = body_to_vec(first_resp.into_body()).await?;
let first_folder: FolderResponse = serde_json::from_slice(&first_body)?;
let second_resp = app
.post_json("/api/folders", &payload, Some(&token))
.await?;
assert!(second_resp.status().is_success());
let second_body = body_to_vec(second_resp.into_body()).await?;
let second_folder: FolderResponse = serde_json::from_slice(&second_body)?;
assert_eq!(first_folder.folder.id, second_folder.folder.id);
let root_contents = app.get("/api/folders/root/contents", Some(&token)).await?;
let root_body = body_to_vec(root_contents.into_body()).await?;
let root: FolderContents = serde_json::from_slice(&root_body)?;
let occurrences = root
.subfolders
.iter()
.filter(|folder| folder.id == first_folder.folder.id)
.count();
assert_eq!(occurrences, 1);
app.cleanup().await?;
Ok(())
}
#[tokio::test]
async fn ensure_folder_path_is_idempotent() -> Result<()> {
let _lock = acquire_db_lock().await;
let app = TestApp::new().await?;
let password = "pathpass";
app.insert_user("path-admin", password, "admin").await?;
let token = app.login_token("path-admin", password).await?;
let segments = ["500 Immobilien", "501 Kreuzweg 2", "501.01 Rechtliches"];
let payload = EnsureFolderPath {
parent_id: None,
segments: &segments,
};
let first_resp = app
.post_json("/api/folders/path", &payload, Some(&token))
.await?;
assert!(first_resp.status().is_success());
let first_body = body_to_vec(first_resp.into_body()).await?;
let first_folder: FolderResponse = serde_json::from_slice(&first_body)?;
let second_resp = app
.post_json("/api/folders/path", &payload, Some(&token))
.await?;
assert!(second_resp.status().is_success());
let second_body = body_to_vec(second_resp.into_body()).await?;
let second_folder: FolderResponse = serde_json::from_slice(&second_body)?;
assert_eq!(first_folder.folder.id, second_folder.folder.id);
// Verify intermediate folders are not duplicated
let root_contents = app.get("/api/folders/root/contents", Some(&token)).await?;
let root_body = body_to_vec(root_contents.into_body()).await?;
let root: FolderContents = serde_json::from_slice(&root_body)?;
let root_occurrences = root
.subfolders
.iter()
.filter(|folder| folder.name == segments[0])
.count();
assert_eq!(root_occurrences, 1);
let level_one = root
.subfolders
.iter()
.find(|folder| folder.name == segments[0])
.map(|folder| folder.id)
.expect("root segment not created");
let level_one_contents = app
.get(
&format!("/api/folders/{}/contents", level_one),
Some(&token),
)
.await?;
let level_one_body = body_to_vec(level_one_contents.into_body()).await?;
let level_one_folders: FolderContents = serde_json::from_slice(&level_one_body)?;
let level_one_occurrences = level_one_folders
.subfolders
.iter()
.filter(|folder| folder.name == segments[1])
.count();
assert_eq!(level_one_occurrences, 1);
app.cleanup().await?;
Ok(())
}
#[tokio::test] #[tokio::test]
async fn folder_rename_updates_name_and_child_paths() -> Result<()> { async fn folder_rename_updates_name_and_child_paths() -> Result<()> {
let _lock = acquire_db_lock().await; let _lock = acquire_db_lock().await;
+103 -7
View File
@@ -2,11 +2,23 @@ mod common;
use anyhow::Result; use anyhow::Result;
use axum::http::StatusCode; use axum::http::StatusCode;
use common::{acquire_db_lock, body_to_vec, TestApp}; use backend::models::{NewUser, NewUserMembership, Tag};
use backend::schema::{
tags::dsl as tags_dsl, tenants::dsl as tenants_dsl, user_memberships::dsl as memberships_dsl,
users::dsl as users_dsl,
};
use common::{acquire_db_lock, body_to_vec, hash_password, TestApp};
use diesel::prelude::*;
use serde::Deserialize; use serde::Deserialize;
use serde::Serialize; use serde::Serialize;
use uuid::Uuid; use uuid::Uuid;
#[derive(Serialize)]
struct CreateTagPayload<'a> {
label: &'a str,
color: Option<&'a str>,
}
#[derive(Deserialize)] #[derive(Deserialize)]
struct DocumentDetail { struct DocumentDetail {
document: DocumentInfo, document: DocumentInfo,
@@ -61,12 +73,6 @@ async fn tag_assignment_flow() -> Result<()> {
let upload_body = body_to_vec(upload.into_body()).await?; let upload_body = body_to_vec(upload.into_body()).await?;
let detail: DocumentDetail = serde_json::from_slice(&upload_body)?; let detail: DocumentDetail = serde_json::from_slice(&upload_body)?;
#[derive(Serialize)]
struct CreateTagPayload<'a> {
label: &'a str,
color: Option<&'a str>,
}
let create_tag = app let create_tag = app
.post_json( .post_json(
"/api/tags", "/api/tags",
@@ -172,3 +178,93 @@ async fn tag_assignment_flow() -> Result<()> {
app.cleanup().await?; app.cleanup().await?;
Ok(()) Ok(())
} }
#[tokio::test]
async fn tags_are_isolated_between_tenants() -> Result<()> {
let _lock = acquire_db_lock().await;
let app = TestApp::new().await?;
let password_a = "tenant-a";
app.insert_user("alice", password_a, "admin").await?;
let token_a = app.login_token("alice", password_a).await?;
let shared_label = "Shared Label";
let create_a = app
.post_json(
"/api/tags",
&CreateTagPayload {
label: shared_label,
color: Some("#123456"),
},
Some(&token_a),
)
.await?;
assert_eq!(create_a.status(), StatusCode::OK);
let tenant_b_id = Uuid::new_v4();
let user_b_id = Uuid::new_v4();
let password_b = "tenant-b";
app.with_conn(move |conn| {
let storage_root = format!("test-tenants/{tenant_b_id}/");
diesel::insert_into(tenants_dsl::tenants)
.values((
tenants_dsl::id.eq(tenant_b_id),
tenants_dsl::slug.eq("tenant-b"),
tenants_dsl::storage_root.eq(Some(storage_root)),
))
.execute(conn)?;
let password_hash = hash_password(password_b)?;
let new_user = NewUser {
id: user_b_id,
username: "bob".to_string(),
password_hash,
};
diesel::insert_into(users_dsl::users)
.values(&new_user)
.execute(conn)?;
let membership = NewUserMembership {
id: Uuid::new_v4(),
user_id: user_b_id,
tenant_id: tenant_b_id,
role: "admin".to_string(),
};
diesel::insert_into(memberships_dsl::user_memberships)
.values(&membership)
.execute(conn)?;
Ok::<_, anyhow::Error>(())
})
.await?;
let token_b = app.login_token("bob", password_b).await?;
let create_b = app
.post_json(
"/api/tags",
&CreateTagPayload {
label: shared_label,
color: Some("#654321"),
},
Some(&token_b),
)
.await?;
assert_eq!(create_b.status(), StatusCode::OK);
app.with_conn(move |conn| {
let tags: Vec<Tag> = tags_dsl::tags
.filter(tags_dsl::label.eq(shared_label))
.order(tags_dsl::tenant_id.asc())
.load(conn)?;
assert_eq!(tags.len(), 2);
assert_ne!(tags[0].tenant_id, tags[1].tenant_id);
Ok::<_, anyhow::Error>(())
})
.await?;
Ok(())
}
+10
View File
@@ -8,6 +8,7 @@
"name": "papercrate-frontend", "name": "papercrate-frontend",
"version": "0.1.0", "version": "0.1.0",
"dependencies": { "dependencies": {
"@fontsource/inter": "^5.2.8",
"@tabler/icons-react": "3.11.0", "@tabler/icons-react": "3.11.0",
"axios": "1.7.7", "axios": "1.7.7",
"react": "18.3.1", "react": "18.3.1",
@@ -1852,6 +1853,15 @@
"node": ">=10.0.0" "node": ">=10.0.0"
} }
}, },
"node_modules/@fontsource/inter": {
"version": "5.2.8",
"resolved": "https://registry.npmjs.org/@fontsource/inter/-/inter-5.2.8.tgz",
"integrity": "sha512-P6r5WnJoKiNVV+zvW2xM13gNdFhAEpQ9dQJHt3naLvfg+LkF2ldgSLiF4T41lf1SQCM9QmkqPTn4TH568IRagg==",
"license": "OFL-1.1",
"funding": {
"url": "https://github.com/sponsors/ayuhito"
}
},
"node_modules/@jridgewell/gen-mapping": { "node_modules/@jridgewell/gen-mapping": {
"version": "0.3.13", "version": "0.3.13",
"resolved": "https://registry.npmjs.org/@jridgewell/gen-mapping/-/gen-mapping-0.3.13.tgz", "resolved": "https://registry.npmjs.org/@jridgewell/gen-mapping/-/gen-mapping-0.3.13.tgz",
+3 -2
View File
@@ -9,6 +9,7 @@
"lint": "echo \"No linting configured\"" "lint": "echo \"No linting configured\""
}, },
"dependencies": { "dependencies": {
"@fontsource/inter": "^5.2.8",
"@tabler/icons-react": "3.11.0", "@tabler/icons-react": "3.11.0",
"axios": "1.7.7", "axios": "1.7.7",
"react": "18.3.1", "react": "18.3.1",
@@ -19,6 +20,7 @@
"@babel/core": "7.26.0", "@babel/core": "7.26.0",
"@babel/preset-env": "7.26.0", "@babel/preset-env": "7.26.0",
"@babel/preset-react": "7.26.3", "@babel/preset-react": "7.26.3",
"@svgr/webpack": "8.1.0",
"babel-loader": "9.2.1", "babel-loader": "9.2.1",
"css-loader": "7.1.2", "css-loader": "7.1.2",
"dotenv": "16.4.5", "dotenv": "16.4.5",
@@ -26,7 +28,6 @@
"style-loader": "4.0.0", "style-loader": "4.0.0",
"webpack": "5.95.0", "webpack": "5.95.0",
"webpack-cli": "5.1.4", "webpack-cli": "5.1.4",
"webpack-dev-server": "5.1.0", "webpack-dev-server": "5.1.0"
"@svgr/webpack": "8.1.0"
} }
} }
@@ -118,11 +118,11 @@ function CorrespondentsPanel({
}, []); }, []);
return ( return (
<section className="correspondents-panel column"> <section className="correspondents-panel">
<div className="column-header"> <div className="panel-section__header">
<div className="column-header__titles"> <div className="panel-section__titles">
<h2>Correspondents</h2> <h2>Correspondents</h2>
<div className="column-subtitle">{correspondents.length} total</div> <div className="panel-section__subtitle">{correspondents.length} total</div>
</div> </div>
<div className="header-actions correspondents-actions"> <div className="header-actions correspondents-actions">
<form className="correspondents-actions__form" onSubmit={handleCreate}> <form className="correspondents-actions__form" onSubmit={handleCreate}>
@@ -147,7 +147,7 @@ function CorrespondentsPanel({
</button> </button>
</div> </div>
</div> </div>
<div className="column-body tags-panel__body"> <div className="panel-section__body tags-panel__body">
{correspondents.length === 0 ? ( {correspondents.length === 0 ? (
<div className="empty-state">No correspondents created yet.</div> <div className="empty-state">No correspondents created yet.</div>
) : ( ) : (
+382 -58
View File
@@ -1,11 +1,20 @@
import React, { useCallback, useEffect, useMemo, useState } from 'react'; import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { createPortal } from 'react-dom'; import {
import { DownloadIcon, EditIcon, ArrowLeftIcon, ArrowRightIcon } from '../ui/icons'; DownloadIcon,
EditIcon,
ArrowLeftIcon,
ArrowRightIcon,
ChevronsRightIcon,
AnalyzeIcon,
WindowMaximizeIcon,
TextScanIcon,
} from '../ui/icons';
import { getTagColorStyle } from '../utils/colors'; import { getTagColorStyle } from '../utils/colors';
import { formatFileSize } from '../utils/format'; import { formatFileSize } from '../utils/format';
import { resolveDocumentAssetUrl, createAssetView } from '../asset_manager'; import { resolveDocumentAssetUrl, createAssetView } from '../asset_manager';
import { useAssetNavigator } from '../hooks/useAssetNavigator'; import { useAssetNavigator } from '../hooks/useAssetNavigator';
import { CORRESPONDENT_ROLES } from '../constants/correspondents'; import { CORRESPONDENT_ROLES } from '../constants/correspondents';
import PreviewZoomOverlay from './PreviewZoomOverlay';
const MAX_PREVIEW_STACK_ITEMS = 15; const MAX_PREVIEW_STACK_ITEMS = 15;
@@ -208,6 +217,7 @@ const PreviewStack = ({
emptyMessage = 'Preview unavailable', emptyMessage = 'Preview unavailable',
onItemActivate, onItemActivate,
onOpenPreview, onOpenPreview,
onZoomPreview,
activeItemId = null, activeItemId = null,
}) => { }) => {
if (!items.length) { if (!items.length) {
@@ -240,7 +250,11 @@ const PreviewStack = ({
zIndex: preparedItems.length - index, zIndex: preparedItems.length - index,
transform, transform,
}} }}
aria-hidden={hasMultiple && !onItemActivate && !onOpenPreview ? 'true' : undefined} aria-hidden={
hasMultiple && !onItemActivate && !onOpenPreview && !onZoomPreview
? 'true'
: undefined
}
> >
<img <img
src={entry.url} src={entry.url}
@@ -248,22 +262,34 @@ const PreviewStack = ({
className="preview-stack__image" className="preview-stack__image"
onClick={(event) => { onClick={(event) => {
event.stopPropagation(); event.stopPropagation();
if (isFront && onOpenPreview) { if (isFront) {
if (onZoomPreview) {
onZoomPreview(entry);
} else if (onOpenPreview) {
onOpenPreview(entry.id); onOpenPreview(entry.id);
} else if (onItemActivate) { } else if (onItemActivate) {
onItemActivate(entry.id); onItemActivate(entry.id);
} }
} else if (onItemActivate) {
onItemActivate(entry.id);
}
}} }}
onKeyDown={(event) => { onKeyDown={(event) => {
if (!onItemActivate && !onOpenPreview) return; if (!onItemActivate && !onOpenPreview && !onZoomPreview) return;
if (event.key === 'Enter' || event.key === ' ') { if (event.key === 'Enter' || event.key === ' ') {
event.preventDefault(); event.preventDefault();
event.stopPropagation(); event.stopPropagation();
if (isFront && onOpenPreview) { if (isFront) {
if (onZoomPreview) {
onZoomPreview(entry);
} else if (onOpenPreview) {
onOpenPreview(entry.id); onOpenPreview(entry.id);
} else { } else {
onItemActivate?.(entry.id); onItemActivate?.(entry.id);
} }
} else {
onItemActivate?.(entry.id);
}
} }
}} }}
/> />
@@ -297,9 +323,26 @@ const DetailPanel = ({
onCorrespondentAdd, onCorrespondentAdd,
onCorrespondentRemove, onCorrespondentRemove,
resolveApiPath, resolveApiPath,
onFolderNavigate = null,
resolveFolderPath = null,
onClose = () => {},
}) => { }) => {
const selectedCount = selectedDocuments.length; const selectedCount = selectedDocuments.length;
const singleDoc = selectedCount === 1 ? selectedDocuments[0] : null; const singleDoc = selectedCount === 1 ? selectedDocuments[0] : null;
const singleDocId = singleDoc?.id || null;
const selectionKey = useMemo(
() => selectedDocuments.map((doc) => doc?.id ?? '').join('|'),
[selectedDocuments],
);
const singleDownloadHref = useMemo(() => {
if (!singleDoc) return null;
const downloadPath = singleDoc.current_version?.download_path;
if (!downloadPath || !resolveApiPath) {
return null;
}
return resolveApiPath(downloadPath);
}, [singleDoc, resolveApiPath]);
const [titleEditDocId, setTitleEditDocId] = useState(null); const [titleEditDocId, setTitleEditDocId] = useState(null);
const [titleDraft, setTitleDraft] = useState(''); const [titleDraft, setTitleDraft] = useState('');
@@ -309,6 +352,7 @@ const DetailPanel = ({
const [ocrUrl, setOcrUrl] = useState(null); const [ocrUrl, setOcrUrl] = useState(null);
const [ocrLoading, setOcrLoading] = useState(false); const [ocrLoading, setOcrLoading] = useState(false);
const [ocrError, setOcrError] = useState(null); const [ocrError, setOcrError] = useState(null);
const [zoomedPreview, setZoomedPreview] = useState(null);
useEffect(() => { useEffect(() => {
if (!singleDoc) { if (!singleDoc) {
@@ -338,6 +382,10 @@ const DetailPanel = ({
setOcrUrl(null); setOcrUrl(null);
}, [singleDoc?.id]); }, [singleDoc?.id]);
useEffect(() => {
setZoomedPreview(null);
}, [selectionKey]);
const startTitleEdit = useCallback(() => { const startTitleEdit = useCallback(() => {
if (!singleDoc) return; if (!singleDoc) return;
setTitleEditDocId(singleDoc.id); setTitleEditDocId(singleDoc.id);
@@ -500,6 +548,7 @@ const DetailPanel = ({
}, [selectedDocuments]); }, [selectedDocuments]);
const stackTopDocument = stackDocuments[0] || null; const stackTopDocument = stackDocuments[0] || null;
const stackTopDocId = stackTopDocument?.id || null;
const stackPreviewNavigator = useAssetNavigator({ const stackPreviewNavigator = useAssetNavigator({
document: stackTopDocument, document: stackTopDocument,
assetType: 'preview', assetType: 'preview',
@@ -623,6 +672,20 @@ const DetailPanel = ({
return sortCorrespondents(singleDoc.correspondents || []); return sortCorrespondents(singleDoc.correspondents || []);
}, [singleDoc]); }, [singleDoc]);
const singleFolderPath = useMemo(() => {
if (!singleDoc?.folder_id) {
return null;
}
if (typeof resolveFolderPath !== 'function') {
return null;
}
const segments = resolveFolderPath(singleDoc.folder_id);
if (!Array.isArray(segments) || !segments.some((segment) => segment?.id && segment.id !== 'root')) {
return null;
}
return segments;
}, [singleDoc?.folder_id, resolveFolderPath]);
const bulkCorrespondents = useMemo(() => { const bulkCorrespondents = useMemo(() => {
if (selectedDocuments.length <= 1) { if (selectedDocuments.length <= 1) {
const doc = selectedDocuments[0]; const doc = selectedDocuments[0];
@@ -699,15 +762,178 @@ const DetailPanel = ({
[bulkCorrespondents, onBulkCorrespondentRemove, onCorrespondentRemove, selectedDocuments], [bulkCorrespondents, onBulkCorrespondentRemove, onCorrespondentRemove, selectedDocuments],
); );
const openZoomPreview = useCallback((config) => {
if (!config) return;
setZoomedPreview({
mode: config.mode,
docId: config.docId ?? null,
});
}, []);
const closeZoomPreview = useCallback(() => {
setZoomedPreview(null);
}, []);
const handleSingleZoom = useCallback(
(entry) => {
if (!singleHasPreview) return;
const targetId = entry?.id ?? singleDocId;
if (!targetId) return;
openZoomPreview({ mode: 'single', docId: targetId });
},
[openZoomPreview, singleHasPreview, singleDocId],
);
const handleStackZoom = useCallback(
(entry) => {
if (!stackTopDocId || entry?.id !== stackTopDocId) return;
if (!topHasPreview) return;
openZoomPreview({ mode: 'stack', docId: stackTopDocId });
},
[openZoomPreview, stackTopDocId, topHasPreview],
);
const zoomDisplay = useMemo(() => {
if (!zoomedPreview) {
return null;
}
if (
zoomedPreview.mode === 'single' &&
singleDocId &&
singleDoc &&
singleHasPreview &&
zoomedPreview.docId === singleDocId
) {
return {
url: singlePreviewNavigator.currentUrl,
alt: singleDoc.title || singleDoc.original_name || 'Document preview',
canGoPrev:
singleEffectiveCardinality > 1 && Boolean(singlePreviewNavigator.canGoPrev),
canGoNext:
singleEffectiveCardinality > 1 && Boolean(singlePreviewNavigator.canGoNext),
goPrev: singlePreviewNavigator.goPrev,
goNext: singlePreviewNavigator.goNext,
};
}
if (
zoomedPreview.mode === 'stack' &&
stackTopDocId &&
stackTopDocument &&
zoomedPreview.docId === stackTopDocId &&
topHasPreview
) {
return {
url: stackPreviewNavigator.currentUrl,
alt: stackTopDocument.title || stackTopDocument.original_name || 'Document preview',
canGoPrev:
topEffectiveCardinality > 1 && Boolean(stackPreviewNavigator.canGoPrev),
canGoNext:
topEffectiveCardinality > 1 && Boolean(stackPreviewNavigator.canGoNext),
goPrev: stackPreviewNavigator.goPrev,
goNext: stackPreviewNavigator.goNext,
};
}
return null;
}, [
zoomedPreview,
singleDoc,
singleDocId,
singleHasPreview,
singlePreviewNavigator.currentUrl,
singlePreviewNavigator.canGoPrev,
singlePreviewNavigator.canGoNext,
singlePreviewNavigator.goPrev,
singlePreviewNavigator.goNext,
singleEffectiveCardinality,
stackTopDocument,
stackTopDocId,
topHasPreview,
stackPreviewNavigator.currentUrl,
stackPreviewNavigator.canGoPrev,
stackPreviewNavigator.canGoNext,
stackPreviewNavigator.goPrev,
stackPreviewNavigator.goNext,
topEffectiveCardinality,
]);
useEffect(() => {
if (zoomedPreview && !zoomDisplay) {
setZoomedPreview(null);
}
}, [zoomedPreview, zoomDisplay]);
useEffect(() => {
if (typeof ensureAssetUrl !== 'function') {
return;
}
const warmNavigator = (navigator) => {
const {
documentId,
asset,
ordinal,
canGoPrev,
canGoNext,
cardinality,
} = navigator;
if (!documentId || !asset || !Number.isFinite(ordinal)) {
return;
}
const requests = [];
if (canGoPrev) {
const prevOrdinal = Math.max(1, ordinal - 1);
if (!cardinality || prevOrdinal <= cardinality) {
requests.push(
ensureAssetUrl(documentId, asset, {
start: prevOrdinal,
limit: 1,
objectOrdinal: prevOrdinal,
}),
);
}
}
if (canGoNext) {
const nextOrdinal = ordinal + 1;
if (!cardinality || nextOrdinal <= cardinality) {
requests.push(
ensureAssetUrl(documentId, asset, {
start: nextOrdinal,
limit: 1,
objectOrdinal: nextOrdinal,
}),
);
}
}
requests.forEach((promise) => promise?.catch?.(() => {}));
};
warmNavigator(singlePreviewNavigator);
warmNavigator(stackPreviewNavigator);
}, [
ensureAssetUrl,
singlePreviewNavigator.documentId,
singlePreviewNavigator.asset,
singlePreviewNavigator.ordinal,
singlePreviewNavigator.canGoPrev,
singlePreviewNavigator.canGoNext,
stackPreviewNavigator.documentId,
stackPreviewNavigator.asset,
stackPreviewNavigator.ordinal,
stackPreviewNavigator.canGoPrev,
stackPreviewNavigator.canGoNext,
]);
const renderSingle = () => { const renderSingle = () => {
if (!singleDoc) { if (!singleDoc) {
return <p className="meta">Select a document to view metadata, tags and actions.</p>; return <p className="meta">Select a document to view metadata, tags and actions.</p>;
} }
const displayName = singleDoc.title || singleDoc.original_name; const displayName = singleDoc.title || singleDoc.original_name;
const downloadHref = singleDoc.current_version?.download_path
? resolveApiPath?.(singleDoc.current_version.download_path)
: null;
const isEditingTitle = titleEditDocId === singleDoc.id; const isEditingTitle = titleEditDocId === singleDoc.id;
const sizeBytes = Number(singleDoc.current_version?.size_bytes) || 0; const sizeBytes = Number(singleDoc.current_version?.size_bytes) || 0;
const sizeLabel = sizeBytes > 0 ? formatFileSize(sizeBytes) : '—'; const sizeLabel = sizeBytes > 0 ? formatFileSize(sizeBytes) : '—';
@@ -743,6 +969,7 @@ const DetailPanel = ({
emptyMessage="Preview loading…" emptyMessage="Preview loading…"
onItemActivate={handlePreviewActivate} onItemActivate={handlePreviewActivate}
onOpenPreview={onOpenPreview} onOpenPreview={onOpenPreview}
onZoomPreview={handleSingleZoom}
activeItemId={activePreviewId} activeItemId={activePreviewId}
/> />
{hasPreviewImage && (effectiveCardinality > 1 || canGoPrev || canGoNext) ? ( {hasPreviewImage && (effectiveCardinality > 1 || canGoPrev || canGoNext) ? (
@@ -852,49 +1079,58 @@ const DetailPanel = ({
<strong>Pages:</strong> {pageCountValue} <strong>Pages:</strong> {pageCountValue}
</div> </div>
) : null} ) : null}
{singleFolderPath?.length ? (
<div>
<strong>Folder:</strong>{' '}
<span className="detail-folder-path">
{singleFolderPath.map((segment, index) => {
const label = segment?.name || '…';
const targetId = segment?.id || null;
const key = `${targetId || label}-${index}`;
const isClickable = Boolean(targetId) && typeof onFolderNavigate === 'function';
const href = !isClickable
? null
: targetId === 'root'
? '/documents'
: `/documents/folder/${targetId}`;
return (
<React.Fragment key={key}>
{index > 0 ? <span className="detail-folder-path__separator">/</span> : null}
{isClickable ? (
<a
href={href}
className="detail-folder-path__link"
onClick={(event) => {
if (
event.button !== 0 ||
event.metaKey ||
event.ctrlKey ||
event.shiftKey ||
event.altKey
) {
return;
}
event.preventDefault();
event.stopPropagation();
onFolderNavigate(targetId);
}}
>
{label}
</a>
) : (
<span className="detail-folder-path__segment">{label}</span>
)}
</React.Fragment>
);
})}
</span>
</div>
) : null}
<div> <div>
<strong>Original filename:</strong>{' '} <strong>Original filename:</strong>{' '}
{singleDoc.original_name} {singleDoc.original_name}
</div> </div>
</div> </div>
<div className="detail-actions">
<a
className="button-link with-icon"
href={downloadHref || '#'}
target="_blank"
rel="noopener noreferrer"
aria-disabled={!downloadHref}
onClick={(event) => {
if (!downloadHref) {
event.preventDefault();
}
}}
>
<DownloadIcon className="icon-inline" />
<span>Download</span>
</a>
<button
type="button"
className="secondary"
onClick={() => onOpenPreview(singleDoc.id)}
>
Open preview
</button>
<button
type="button"
className="secondary"
onClick={() => onRegenerateThumbnails(singleDoc.id)}
>
Re-run analysis
</button>
</div>
{hasOcrAsset ? (
<div className="detail-ocr-trigger">
<button type="button" className="secondary" onClick={openOcrModal}>
View OCR text
</button>
</div>
) : null}
<TagSection <TagSection
title="Tags" title="Tags"
tags={tagsForDoc.map((tag) => ({ tags={tagsForDoc.map((tag) => ({
@@ -931,7 +1167,7 @@ const DetailPanel = ({
{metadata && ( {metadata && (
<div> <div>
<dt>Metadata</dt> <dt>Metadata</dt>
<pre>{JSON.stringify(metadata, null, 2)}</pre> <pre className="detail-metadata__block">{JSON.stringify(metadata, null, 2)}</pre>
</div> </div>
)} )}
{hasOcrAsset && ocrOpen {hasOcrAsset && ocrOpen
@@ -1002,6 +1238,7 @@ const DetailPanel = ({
emptyMessage="No previews available." emptyMessage="No previews available."
onItemActivate={handlePreviewActivate} onItemActivate={handlePreviewActivate}
onOpenPreview={onOpenPreview} onOpenPreview={onOpenPreview}
onZoomPreview={handleStackZoom}
activeItemId={activePreviewId} activeItemId={activePreviewId}
/> />
{topDocIdLocal && topHasPreview && (topCardinalityLocal > 1 || topCanGoPrev || topCanGoNext) ? ( {topDocIdLocal && topHasPreview && (topCardinalityLocal > 1 || topCanGoPrev || topCanGoNext) ? (
@@ -1074,23 +1311,110 @@ const DetailPanel = ({
showCount showCount
className="bulk-correspondents" className="bulk-correspondents"
/> />
<button
type="button"
className="secondary"
onClick={() => onBulkReanalyze?.()}
>
Re-analyze selection
</button>
</> </>
); );
}; };
const isBulkSelection = selectedCount > 1;
const showOcrAction = Boolean(singleDoc && hasOcrAsset);
return ( return (
<aside className="detail-panel column"> <>
<div className="column-body scrollable"> <aside className="detail-panel panel">
<div className="panel-header">
<div className="panel-actions">
<button
type="button"
className="icon-button ghost"
onClick={onClose}
aria-label="Close detail panel"
title="Close detail panel"
>
<ChevronsRightIcon />
</button>
<div className="spacer" />
{isBulkSelection && onBulkReanalyze ? (
<button
type="button"
className="icon-button ghost"
onClick={(event) => {
event.stopPropagation();
onBulkReanalyze();
}}
aria-label="Re-run analysis for selection"
title="Re-run analysis for selection"
>
<AnalyzeIcon />
</button>
) : null}
{singleDoc && singleDownloadHref ? (
<a
className="icon-button"
href={singleDownloadHref}
target="_blank"
rel="noopener noreferrer"
aria-label="Download document"
title="Download document"
onClick={(event) => event.stopPropagation()}
>
<DownloadIcon />
</a>
) : null}
{singleDoc ? (
<button
type="button"
className="icon-button ghost"
onClick={(event) => {
event.stopPropagation();
onOpenPreview(singleDoc.id);
}}
aria-label="Open preview"
title="Open preview"
disabled={!singleHasPreview}
>
<WindowMaximizeIcon />
</button>
) : null}
{showOcrAction ? (
<button
type="button"
className="icon-button ghost"
onClick={(event) => {
event.stopPropagation();
openOcrModal();
}}
aria-label="View OCR text"
title="View OCR text"
>
<TextScanIcon />
</button>
) : null}
{singleDoc ? (
<button
type="button"
className="icon-button ghost"
onClick={(event) => {
event.stopPropagation();
onRegenerateThumbnails(singleDoc.id);
}}
aria-label="Re-run analysis"
title="Re-run analysis"
>
<AnalyzeIcon />
</button>
) : null}
</div>
</div>
<div className="panel-body">
{selectedCount <= 1 ? renderSingle() : renderBulk()} {selectedCount <= 1 ? renderSingle() : renderBulk()}
</div> </div>
</aside> </aside>
<PreviewZoomOverlay
open={Boolean(zoomDisplay?.url)}
display={zoomDisplay}
onClose={closeZoomPreview}
/>
</>
); );
}; };
+262
View File
@@ -0,0 +1,262 @@
import React, { useEffect, useRef, useState } from 'react';
import { createPortal } from 'react-dom';
import { ArrowLeftIcon, ArrowRightIcon } from '../ui/icons';
const noop = () => {};
const clamp = (value, min, max) => {
if (value < min) return min;
if (value > max) return max;
return value;
};
const ensureDocumentRoot = () => {
if (typeof document === 'undefined') {
return null;
}
return document.body;
};
const PreviewZoomOverlay = ({
open = false,
display = null,
onClose = noop,
}) => {
const portalTarget = ensureDocumentRoot();
const [isNativeScale, setIsNativeScale] = useState(false);
const [naturalSize, setNaturalSize] = useState({ width: null, height: null });
const scrollRef = useRef(null);
const imageRef = useRef(null);
const focusRef = useRef(null);
const previouslyFocusedRef = useRef(null);
useEffect(() => {
setIsNativeScale(false);
setNaturalSize({ width: null, height: null });
focusRef.current = null;
const scrollEl = scrollRef.current;
if (scrollEl) {
scrollEl.scrollLeft = 0;
scrollEl.scrollTop = 0;
}
}, [open]);
useEffect(() => {
if (!open || !isNativeScale) {
return;
}
const scrollEl = scrollRef.current;
const imageEl = imageRef.current;
if (!scrollEl || !imageEl) {
return;
}
const imageWidth = imageEl.naturalWidth || imageEl.clientWidth;
const imageHeight = imageEl.naturalHeight || imageEl.clientHeight;
if (!(imageWidth > 0 && imageHeight > 0)) {
return;
}
const target = focusRef.current || { xRatio: 0.5, yRatio: 0.5 };
const maxScrollLeft = Math.max(0, imageWidth - scrollEl.clientWidth);
const maxScrollTop = Math.max(0, imageHeight - scrollEl.clientHeight);
const desiredLeft = target.xRatio * imageWidth - scrollEl.clientWidth / 2;
const desiredTop = target.yRatio * imageHeight - scrollEl.clientHeight / 2;
scrollEl.scrollLeft = clamp(desiredLeft, 0, maxScrollLeft);
scrollEl.scrollTop = clamp(desiredTop, 0, maxScrollTop);
}, [open, isNativeScale, naturalSize.width, naturalSize.height]);
useEffect(() => {
if (!open) {
if (previouslyFocusedRef.current && typeof previouslyFocusedRef.current.focus === 'function') {
previouslyFocusedRef.current.focus();
}
previouslyFocusedRef.current = null;
return undefined;
}
if (typeof document !== 'undefined') {
const active = document.activeElement;
if (active && typeof active.focus === 'function') {
previouslyFocusedRef.current = active;
} else {
previouslyFocusedRef.current = null;
}
}
const scrollEl = scrollRef.current;
if (!scrollEl) {
return undefined;
}
const frame = requestAnimationFrame(() => {
scrollEl.focus();
});
return () => {
cancelAnimationFrame(frame);
if (previouslyFocusedRef.current && typeof previouslyFocusedRef.current.focus === 'function') {
previouslyFocusedRef.current.focus();
previouslyFocusedRef.current = null;
}
};
}, [open]);
const handleKeyDown = (event) => {
event.stopPropagation();
if (!open) {
return;
}
if (event.key === 'Escape') {
event.preventDefault();
onClose();
return;
}
if (event.key === 'ArrowLeft') {
if (display?.canGoPrev && display?.goPrev) {
event.preventDefault();
display.goPrev();
}
return;
}
if (event.key === 'ArrowRight') {
if (display?.canGoNext && display?.goNext) {
event.preventDefault();
display.goNext();
}
}
};
if (!open || !display?.url || !portalTarget) {
return null;
}
const navVisible = Boolean(display?.canGoPrev || display?.canGoNext);
const stageClassName = [
'preview-zoom__stage',
]
.filter(Boolean)
.join(' ');
const containerClassName = [
'preview-zoom__scroll',
isNativeScale ? 'preview-zoom__scroll--native' : '',
]
.filter(Boolean)
.join(' ');
const imageStyle = isNativeScale
? {
cursor: 'zoom-out',
width: naturalSize.width ? `${naturalSize.width}px` : 'auto',
height: naturalSize.height ? `${naturalSize.height}px` : 'auto',
maxWidth: 'none',
maxHeight: 'none',
}
: {
cursor: 'zoom-in',
maxWidth: '95vw',
maxHeight: '95vh',
};
return createPortal(
(
<div
className="preview-zoom-backdrop"
role="dialog"
aria-modal="true"
aria-label="Enlarged document preview"
onClick={onClose}
>
<div
className={stageClassName}
onClick={(event) => event.stopPropagation()}
onKeyDown={handleKeyDown}
>
<div
className={containerClassName}
ref={scrollRef}
tabIndex={-1}
>
<img
src={display.url}
alt={display.alt || 'Document preview'}
className="preview-zoom__image"
ref={imageRef}
draggable={false}
onLoad={(event) => {
setNaturalSize({
width: event.currentTarget.naturalWidth || null,
height: event.currentTarget.naturalHeight || null,
});
}}
onClick={(event) => {
event.stopPropagation();
if (!isNativeScale) {
const img = imageRef.current;
if (img) {
const rect = img.getBoundingClientRect();
const xRatio = rect.width > 0 ? (event.clientX - rect.left) / rect.width : 0.5;
const yRatio = rect.height > 0 ? (event.clientY - rect.top) / rect.height : 0.5;
focusRef.current = {
xRatio: clamp(xRatio, 0, 1),
yRatio: clamp(yRatio, 0, 1),
};
} else {
focusRef.current = null;
}
} else {
focusRef.current = null;
}
setIsNativeScale((current) => !current);
}}
style={imageStyle}
/>
</div>
{navVisible ? (
<div className="preview-zoom__nav">
<button
type="button"
className="preview-zoom__nav-button"
onClick={(event) => {
event.stopPropagation();
if (display?.canGoPrev && display?.goPrev) {
display.goPrev();
}
}}
aria-label="Previous preview"
disabled={!display?.canGoPrev}
>
<ArrowLeftIcon />
</button>
<button
type="button"
className="preview-zoom__nav-button"
onClick={(event) => {
event.stopPropagation();
if (display?.canGoNext && display?.goNext) {
display.goNext();
}
}}
aria-label="Next preview"
disabled={!display?.canGoNext}
>
<ArrowRightIcon />
</button>
</div>
) : null}
</div>
</div>
),
portalTarget,
);
};
export default PreviewZoomOverlay;
+147 -89
View File
@@ -1,7 +1,7 @@
import React, { useCallback, useEffect, useMemo, useRef } from 'react'; import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { getAssetFromVersion, resolveDocumentAssetUrl, createAssetView } from '../asset_manager'; import { getAssetFromVersion, resolveDocumentAssetUrl, createAssetView } from '../asset_manager';
import { getTagColorStyle } from '../utils/colors'; import { getTagColorStyle } from '../utils/colors';
import { DownloadIcon, EditIcon, ViewListIcon, ViewGridIcon, FolderIcon } from '../ui/icons'; import { DownloadIcon, EditIcon, ViewListIcon, ViewGridIcon, FolderIcon, TrashIcon } from '../ui/icons';
const TAG_MIME_TYPES = ['application/x-papercrate-tag', 'text/papercrate-tag']; const TAG_MIME_TYPES = ['application/x-papercrate-tag', 'text/papercrate-tag'];
const DEFAULT_GRID_ICON_SIZE = 96; const DEFAULT_GRID_ICON_SIZE = 96;
@@ -13,13 +13,62 @@ const getPageCount = (doc) =>
? doc.current_version.metadata.page_count ? doc.current_version.metadata.page_count
: null; : null;
// Detects when an element becomes visible within a scroll container.
const useLazyVisibility = (rootRef, resetKey) => {
const targetRef = useRef(null);
const [isVisible, setIsVisible] = useState(false);
useEffect(() => {
setIsVisible(false);
}, [resetKey]);
const rootNode = rootRef?.current || null;
useEffect(() => {
if (isVisible) {
return undefined;
}
const element = targetRef.current;
if (!element) {
return undefined;
}
if (typeof window === 'undefined' || typeof IntersectionObserver === 'undefined') {
setIsVisible(true);
return undefined;
}
const observer = new IntersectionObserver(
(entries) => {
entries.forEach((entry) => {
if (entry.isIntersecting) {
setIsVisible(true);
observer.disconnect();
}
});
},
{
root: rootNode,
rootMargin: '200px 0px',
threshold: 0.01,
},
);
observer.observe(element);
return () => observer.disconnect();
}, [isVisible, rootNode, resetKey]);
return { ref: targetRef, isVisible };
};
const DocumentThumbnailImage = ({ const DocumentThumbnailImage = ({
document, document,
ensureAssetUrl, ensureAssetUrl,
getDocumentAsset, getDocumentAsset,
alt, alt,
maxSize = LIST_ICON_SIZE, maxSize = LIST_ICON_SIZE,
scrollRootRef = null,
}) => { }) => {
const { ref: visibilityRef, isVisible } = useLazyVisibility(scrollRootRef, document?.id);
const resolvedMaxSize = Math.max(1, Math.round(maxSize || 1)); const resolvedMaxSize = Math.max(1, Math.round(maxSize || 1));
const thumbnailAsset = useMemo( const thumbnailAsset = useMemo(
() => getAssetFromVersion(document?.current_version, 'thumbnail'), () => getAssetFromVersion(document?.current_version, 'thumbnail'),
@@ -45,14 +94,15 @@ const DocumentThumbnailImage = ({
() => ({ width: `${dimensions.width}px`, height: `${dimensions.height}px` }), () => ({ width: `${dimensions.width}px`, height: `${dimensions.height}px` }),
[dimensions.height, dimensions.width], [dimensions.height, dimensions.width],
); );
const url = useMemo( const url = useMemo(() => {
() => if (!isVisible) {
resolveDocumentAssetUrl(document, 'thumbnail', { return null;
}
return resolveDocumentAssetUrl(document, 'thumbnail', {
ensureAssetUrl, ensureAssetUrl,
getAsset: getDocumentAsset, getAsset: getDocumentAsset,
}), });
[document, ensureAssetUrl, getDocumentAsset], }, [document, ensureAssetUrl, getDocumentAsset, isVisible]);
);
const pageCount = getPageCount(document); const pageCount = getPageCount(document);
const showMultiPageBadge = Number.isFinite(pageCount) && pageCount > 1; const showMultiPageBadge = Number.isFinite(pageCount) && pageCount > 1;
@@ -62,13 +112,15 @@ const DocumentThumbnailImage = ({
} }
return ( return (
<div className="document-thumbnail-wrapper"> <div className="document-thumbnail-wrapper" ref={visibilityRef}>
<div className={innerClasses.join(' ')} style={innerStyle}> <div className={innerClasses.join(' ')} style={innerStyle}>
{url ? ( {url ? (
<img <img
src={url} src={url}
alt={alt || ''} alt={alt || ''}
className="document-thumbnail" className="document-thumbnail"
loading="lazy"
decoding="async"
draggable={false} draggable={false}
onDragStart={(event) => event.preventDefault()} onDragStart={(event) => event.preventDefault()}
/> />
@@ -125,6 +177,7 @@ const DocumentsTable = ({
viewMode = 'list', viewMode = 'list',
onViewModeChange, onViewModeChange,
onClearSelection, onClearSelection,
showHeader = true,
}) => { }) => {
const showingSearchResults = searchResults !== null; const showingSearchResults = searchResults !== null;
const rows = showingSearchResults ? searchResults : documents; const rows = showingSearchResults ? searchResults : documents;
@@ -142,6 +195,18 @@ const DocumentsTable = ({
[draggingDocumentIds], [draggingDocumentIds],
); );
const scrollRef = useRef(null); const scrollRef = useRef(null);
const [, forceVisibilityTick] = useState(0);
const lastScrollNodeRef = useRef(null);
const assignScrollRef = useCallback((node) => {
if (lastScrollNodeRef.current === node) {
return;
}
lastScrollNodeRef.current = node;
scrollRef.current = node;
if (node) {
forceVisibilityTick((value) => value + 1);
}
}, []);
const isGridView = viewMode === 'grid'; const isGridView = viewMode === 'grid';
const gridIconSize = DEFAULT_GRID_ICON_SIZE; const gridIconSize = DEFAULT_GRID_ICON_SIZE;
const handleSetViewMode = useCallback( const handleSetViewMode = useCallback(
@@ -156,6 +221,11 @@ const DocumentsTable = ({
}, },
[onViewModeChange], [onViewModeChange],
); );
useEffect(() => {
if (scrollRef.current) {
scrollRef.current.scrollTop = 0;
}
}, [viewMode]);
const isTagDragEvent = useCallback((event) => { const isTagDragEvent = useCallback((event) => {
const types = Array.from(event.dataTransfer?.types || []); const types = Array.from(event.dataTransfer?.types || []);
return TAG_MIME_TYPES.some((type) => types.includes(type)); return TAG_MIME_TYPES.some((type) => types.includes(type));
@@ -263,16 +333,6 @@ const DocumentsTable = ({
[isTagDragEvent, onDocumentTagDrop], [isTagDragEvent, onDocumentTagDrop],
); );
const handleGridBackgroundClick = useCallback(
(event) => {
if (event.target !== event.currentTarget) {
return;
}
onClearSelection?.();
},
[onClearSelection],
);
const showDefaultEmptyState = !showingSearchResults && !subfolders.length && rows.length === 0; const showDefaultEmptyState = !showingSearchResults && !subfolders.length && rows.length === 0;
const showListSearchEmptyState = const showListSearchEmptyState =
showingSearchResults && rows.length === 0 && !isGridView && !isSearchLoading; showingSearchResults && rows.length === 0 && !isGridView && !isSearchLoading;
@@ -282,35 +342,14 @@ const DocumentsTable = ({
return ( return (
<section <section
className={`documents-panel column documents-panel--view-${isGridView ? 'grid' : 'list'}`} className={`documents-panel documents-panel--view-${isGridView ? 'grid' : 'list'}`}
> >
<div className="column-header"> {showHeader ? (
<div className="column-header__titles"> <div className="panel-section__header">
<nav className="breadcrumb" aria-label="Folder breadcrumbs"> <div className="panel-section__titles">
{breadcrumbs.map((crumb, index) => { <h2>{currentFolderName}</h2>
const isLast = index === breadcrumbs.length - 1;
return (
<span key={crumb.id} className="breadcrumb-item">
{isLast ? (
<span className="breadcrumb-current">{crumb.name}</span>
) : (
<a
href="#"
onClick={(event) => {
event.preventDefault();
onFolderSelect(crumb.id);
}}
>
{crumb.name}
</a>
)}
{!isLast && <span className="breadcrumb-separator"></span>}
</span>
);
})}
</nav>
{showingSearchResults && ( {showingSearchResults && (
<div className="column-subtitle">Search results</div> <div className="panel-section__subtitle">Search results</div>
)} )}
</div> </div>
<div className="header-actions"> <div className="header-actions">
@@ -349,6 +388,7 @@ const DocumentsTable = ({
</button> </button>
</div> </div>
</div> </div>
) : null}
{showDefaultEmptyState && ( {showDefaultEmptyState && (
<div className="empty-state"> <div className="empty-state">
Drop files anywhere or onto a folder to upload documents. Drop files anywhere or onto a folder to upload documents.
@@ -359,9 +399,9 @@ const DocumentsTable = ({
No documents match the current filters. No documents match the current filters.
</div> </div>
)} )}
<div className="column-body"> <div className="panel-section__body">
<div <div
ref={scrollRef} ref={assignScrollRef}
className="documents-scroll" className="documents-scroll"
onFocus={(event) => { onFocus={(event) => {
if (event.target === scrollRef.current) { if (event.target === scrollRef.current) {
@@ -376,13 +416,22 @@ const DocumentsTable = ({
onDocumentListKeyDown(event); onDocumentListKeyDown(event);
} }
}} }}
onClick={(event) => {
if (event.target === event.currentTarget) {
onClearSelection?.();
}
}}
aria-activedescendant={isGridView ? undefined : activeDescendantId} aria-activedescendant={isGridView ? undefined : activeDescendantId}
> >
{showDefaultEmptyState ? null : isGridView ? ( {showDefaultEmptyState ? null : isGridView ? (
<div <div
className="documents-grid" className="documents-grid"
role="list" role="list"
onClick={handleGridBackgroundClick} onClick={(event) => {
if (event.target === event.currentTarget) {
onClearSelection?.();
}
}}
style={{ '--documents-grid-icon-size': `${gridIconSize}px` }} style={{ '--documents-grid-icon-size': `${gridIconSize}px` }}
> >
{!showingSearchResults && {!showingSearchResults &&
@@ -477,6 +526,7 @@ const DocumentsTable = ({
getDocumentAsset={getDocumentAsset} getDocumentAsset={getDocumentAsset}
alt={`Thumbnail for ${doc.title || doc.original_name}`} alt={`Thumbnail for ${doc.title || doc.original_name}`}
maxSize={gridIconSize} maxSize={gridIconSize}
scrollRootRef={scrollRef}
/> />
<div className="document-card__meta"> <div className="document-card__meta">
<div <div
@@ -619,13 +669,20 @@ const DocumentsTable = ({
<td className="doc-list__name"> <td className="doc-list__name">
<div className="doc-list__name-content"> <div className="doc-list__name-content">
<span>{folder.name}</span> <span>{folder.name}</span>
{folder.id !== 'root' && ( </div>
</td>
<td>Folder</td>
<td></td>
<td className="actions">
<div className="action-buttons">
{folder.id !== 'root' && onFolderRename && (
<button <button
type="button" type="button"
className="icon-button ghost doc-list__icon-button" className="icon-button ghost"
title="Rename"
aria-label={`Rename folder ${folder.name}`}
onClick={(event) => { onClick={(event) => {
event.stopPropagation(); event.stopPropagation();
if (!onFolderRename) return;
const nextName = window.prompt('Rename folder', folder.name || ''); const nextName = window.prompt('Rename folder', folder.name || '');
if (!nextName) { if (!nextName) {
return; return;
@@ -636,27 +693,23 @@ const DocumentsTable = ({
} }
onFolderRename(folder.id, trimmed); onFolderRename(folder.id, trimmed);
}} }}
title="Rename folder"
aria-label={`Rename folder ${folder.name}`}
> >
<EditIcon className="doc-list__icon" size={16} /> <EditIcon className="icon-inline" />
</button> </button>
)} )}
</div>
</td>
<td>Folder</td>
<td></td>
<td className="actions">
<button <button
type="button" type="button"
className="icon-button danger" className="icon-button danger"
title="Delete"
aria-label={`Delete folder ${folder.name}`}
onClick={(event) => { onClick={(event) => {
event.stopPropagation(); event.stopPropagation();
onFolderDelete(folder.id); onFolderDelete(folder.id);
}} }}
> >
Delete <TrashIcon className="icon-inline" />
</button> </button>
</div>
</td> </td>
</tr> </tr>
); );
@@ -690,36 +743,13 @@ const DocumentsTable = ({
ensureAssetUrl={ensureAssetUrl} ensureAssetUrl={ensureAssetUrl}
getDocumentAsset={getDocumentAsset} getDocumentAsset={getDocumentAsset}
alt={`Thumbnail for ${doc.title || doc.original_name}`} alt={`Thumbnail for ${doc.title || doc.original_name}`}
scrollRootRef={scrollRef}
/> />
</td> </td>
<td className="doc-list__name"> <td className="doc-list__name">
<div className="doc-name"> <div className="doc-name">
<div className="doc-list__name-content"> <div className="doc-list__name-content">
<span className="doc-name__title">{doc.title || doc.original_name}</span> <span className="doc-name__title">{doc.title || doc.original_name}</span>
<button
type="button"
className="icon-button ghost doc-list__icon-button"
onClick={(event) => {
event.stopPropagation();
if (!onDocumentRename) return;
const nextName = window.prompt(
'Rename document',
doc.title || doc.original_name || '',
);
if (!nextName) {
return;
}
const trimmed = nextName.trim();
if (!trimmed || trimmed === (doc.title || doc.original_name)) {
return;
}
onDocumentRename(doc.id, trimmed);
}}
title="Rename document"
aria-label={`Rename document ${doc.title || doc.original_name}`}
>
<EditIcon className="doc-list__icon" size={16} />
</button>
</div> </div>
{(doc.tags || []).length > 0 && ( {(doc.tags || []).length > 0 && (
<div className="doc-name__tags"> <div className="doc-name__tags">
@@ -788,31 +818,59 @@ const DocumentsTable = ({
</td> </td>
<td className="actions"> <td className="actions">
<div className="action-buttons"> <div className="action-buttons">
{onDocumentRename && (
<button
type="button"
className="icon-button ghost"
title="Rename"
aria-label={`Rename document ${doc.title || doc.original_name}`}
onClick={(event) => {
event.stopPropagation();
const nextName = window.prompt(
'Rename document',
doc.title || doc.original_name || '',
);
if (!nextName) {
return;
}
const trimmed = nextName.trim();
if (!trimmed || trimmed === (doc.title || doc.original_name)) {
return;
}
onDocumentRename(doc.id, trimmed);
}}
>
<EditIcon className="icon-inline" />
</button>
)}
{downloadHref ? ( {downloadHref ? (
<a <a
className="button-link with-icon" className="icon-button"
href={downloadHref} href={downloadHref}
target="_blank" target="_blank"
rel="noopener noreferrer" rel="noopener noreferrer"
title="Download"
aria-label="Download document"
onClick={(event) => event.stopPropagation()} onClick={(event) => event.stopPropagation()}
onAuxClick={(event) => event.stopPropagation()} onAuxClick={(event) => event.stopPropagation()}
onContextMenu={(event) => event.stopPropagation()} onContextMenu={(event) => event.stopPropagation()}
> >
<DownloadIcon className="icon-inline" /> <DownloadIcon className="icon-inline" />
<span>Download</span>
</a> </a>
) : ( ) : (
<span className="meta">No download</span> <span className="meta">No download</span>
)} )}
<button <button
type="button" type="button"
className="danger" className="icon-button danger"
title="Delete"
aria-label="Delete document"
onClick={(event) => { onClick={(event) => {
event.stopPropagation(); event.stopPropagation();
onDocumentDelete?.(doc.id); onDocumentDelete?.(doc.id);
}} }}
> >
Delete <TrashIcon className="icon-inline" />
</button> </button>
</div> </div>
</td> </td>
+565 -151
View File
@@ -1,3 +1,5 @@
import '@fontsource/inter/400.css';
import React, { import React, {
useCallback, useCallback,
useContext, useContext,
@@ -30,6 +32,16 @@ import CorrespondentsPanel from './correspondents/CorrespondentsPanel';
import { CORRESPONDENT_ROLES } from './constants/correspondents'; import { CORRESPONDENT_ROLES } from './constants/correspondents';
import TagManager from './tag_manager'; import TagManager from './tag_manager';
import Sidebar from './sidebar/Sidebar'; import Sidebar from './sidebar/Sidebar';
import {
ChevronsRightIcon,
ChevronsLeftIcon,
ViewListIcon,
ViewGridIcon,
FolderPlusIcon,
RefreshIcon,
ArrowUpIcon,
MinusVerticalIcon,
} from './ui/icons';
import DocumentsTable from './documents/DocumentsTable'; import DocumentsTable from './documents/DocumentsTable';
import { AppShellContext, useAppShell } from './appShellContext'; import { AppShellContext, useAppShell } from './appShellContext';
import DocumentViewerRoute from './routes/DocumentViewerRoute'; import DocumentViewerRoute from './routes/DocumentViewerRoute';
@@ -309,9 +321,9 @@ const LoginView = ({
const DocumentsLayout = ({ sidebarProps, children }) => ( const DocumentsLayout = ({ sidebarProps, children, sidebarCollapsed }) => (
<main className="documents-main"> <main className={`documents-main${sidebarCollapsed ? ' documents-main--sidebar-collapsed' : ''}`}>
<Sidebar {...sidebarProps} /> {!sidebarCollapsed ? <Sidebar {...sidebarProps} /> : null}
{children} {children}
</main> </main>
); );
@@ -335,6 +347,9 @@ const AppLayout = () => {
({ message, variant }) => setStatusMessage(message, variant), ({ message, variant }) => setStatusMessage(message, variant),
[setStatusMessage], [setStatusMessage],
); );
const [sidebarCollapsed, setSidebarCollapsed] = useState(false);
const collapseSidebar = useCallback(() => setSidebarCollapsed(true), []);
const expandSidebar = useCallback(() => setSidebarCollapsed(false), []);
const reportApiError = useApiError({ const reportApiError = useApiError({
onReport: handleApiReport, onReport: handleApiReport,
}); });
@@ -345,6 +360,8 @@ const AppLayout = () => {
); );
const [loading, setLoading] = useState(false); const [loading, setLoading] = useState(false);
const [isCreateFolderModalOpen, setCreateFolderModalOpen] = useState(false); const [isCreateFolderModalOpen, setCreateFolderModalOpen] = useState(false);
const [isTagsModalOpen, setTagsModalOpen] = useState(false);
const [isCorrespondentsModalOpen, setCorrespondentsModalOpen] = useState(false);
const [newFolderName, setNewFolderName] = useState(''); const [newFolderName, setNewFolderName] = useState('');
const [createFolderError, setCreateFolderError] = useState(''); const [createFolderError, setCreateFolderError] = useState('');
const [creatingFolder, setCreatingFolder] = useState(false); const [creatingFolder, setCreatingFolder] = useState(false);
@@ -366,15 +383,11 @@ const AppLayout = () => {
const stored = window.localStorage.getItem('papercrate_view_mode'); const stored = window.localStorage.getItem('papercrate_view_mode');
return stored === 'grid' ? 'grid' : 'list'; return stored === 'grid' ? 'grid' : 'list';
}); });
const initialRowSelection = routeDocumentId const initialRowSelection = [];
? [resolveDocumentRowKey(routeDocumentId)]
: [];
const [selectedRowKeys, setSelectedRowKeys] = useState(initialRowSelection); const [selectedRowKeys, setSelectedRowKeys] = useState(initialRowSelection);
const [selectionOrder, setSelectionOrder] = useState(initialRowSelection); const [selectionOrder, setSelectionOrder] = useState(initialRowSelection);
const [focusedDocumentId, setFocusedDocumentId] = useState(routeDocumentId); const [focusedDocumentId, setFocusedDocumentId] = useState(null);
const [focusedRowKey, setFocusedRowKey] = useState(() => const [focusedRowKey, setFocusedRowKey] = useState(null);
routeDocumentId ? resolveDocumentRowKey(routeDocumentId) : null,
);
const tokenRef = useRef(token); const tokenRef = useRef(token);
const refreshPromiseRef = useRef(null); const refreshPromiseRef = useRef(null);
const breadcrumbFetchRef = useRef(new Set()); const breadcrumbFetchRef = useRef(new Set());
@@ -423,13 +436,9 @@ const AppLayout = () => {
const documentsRouteMatch = useMatch('/documents'); const documentsRouteMatch = useMatch('/documents');
const documentsFolderRouteMatch = useMatch('/documents/folder/:folderId'); const documentsFolderRouteMatch = useMatch('/documents/folder/:folderId');
const documentsDetailRouteMatch = useMatch('/documents/:documentId'); const documentsDetailRouteMatch = useMatch('/documents/:documentId');
const tagsRouteMatch = useMatch('/tags');
const correspondentsRouteMatch = useMatch('/correspondents');
const isDocumentsRoute = Boolean( const isDocumentsRoute = Boolean(
documentsRouteMatch || documentsFolderRouteMatch || documentsDetailRouteMatch, documentsRouteMatch || documentsFolderRouteMatch || documentsDetailRouteMatch,
); );
const isTagsRoute = Boolean(tagsRouteMatch);
const isCorrespondentsRoute = Boolean(correspondentsRouteMatch);
const toggleTagFilter = useCallback((tagId) => { const toggleTagFilter = useCallback((tagId) => {
if (!tagId) return; if (!tagId) return;
setActiveTagFilters((previous) => setActiveTagFilters((previous) =>
@@ -455,6 +464,10 @@ const AppLayout = () => {
setSearchLoading(false); setSearchLoading(false);
}, []); }, []);
const handleSearchChange = useCallback((value) => {
setSearchQuery(value);
}, []);
const handleSearchSubmit = useCallback(() => { const handleSearchSubmit = useCallback(() => {
if (!navigate) return; if (!navigate) return;
const targetFolder = selectedFolder && selectedFolder !== 'root' ? selectedFolder : 'root'; const targetFolder = selectedFolder && selectedFolder !== 'root' ? selectedFolder : 'root';
@@ -581,6 +594,7 @@ const AppLayout = () => {
const selectionInitializedRef = useRef(false); const selectionInitializedRef = useRef(false);
const dragCounterRef = useRef(0); const dragCounterRef = useRef(0);
const prefetchedFoldersRef = useRef(new Set(['root'])); const prefetchedFoldersRef = useRef(new Set(['root']));
const detailFolderFetchRef = useRef(new Set());
const selectionAnchorRef = useRef(initialRowSelection[initialRowSelection.length - 1] || null); const selectionAnchorRef = useRef(initialRowSelection[initialRowSelection.length - 1] || null);
const selectionOrderRef = useRef(initialRowSelection); const selectionOrderRef = useRef(initialRowSelection);
@@ -630,6 +644,7 @@ const AppLayout = () => {
dragCounterRef.current = 0; dragCounterRef.current = 0;
prefetchedFoldersRef.current = new Set(['root']); prefetchedFoldersRef.current = new Set(['root']);
breadcrumbFetchRef.current = new Set(); breadcrumbFetchRef.current = new Set();
detailFolderFetchRef.current = new Set();
bootstrapInitializedRef.current = false; bootstrapInitializedRef.current = false;
selectionInitializedRef.current = false; selectionInitializedRef.current = false;
}, [assetManager]); }, [assetManager]);
@@ -814,14 +829,7 @@ const AppLayout = () => {
if (selectionInitializedRef.current) { if (selectionInitializedRef.current) {
nextDocKeys = previousDocKeys.filter((key) => availableDocKeySet.has(key)); nextDocKeys = previousDocKeys.filter((key) => availableDocKeySet.has(key));
} else { } else {
const filtered = previousDocKeys.filter((key) => availableDocKeySet.has(key)); nextDocKeys = previousDocKeys.filter((key) => availableDocKeySet.has(key));
if (filtered.length) {
nextDocKeys = filtered;
} else if (availableDocKeys.length) {
nextDocKeys = [availableDocKeys[0]];
} else {
nextDocKeys = [];
}
} }
mergedSelection = [...previousFolderKeys, ...nextDocKeys]; mergedSelection = [...previousFolderKeys, ...nextDocKeys];
@@ -1862,19 +1870,134 @@ const AppLayout = () => {
greedyPrefetchFolders(pendingIds).catch(() => {}); greedyPrefetchFolders(pendingIds).catch(() => {});
}, [folderContents, greedyPrefetchFolders]); }, [folderContents, greedyPrefetchFolders]);
const expandFolderAncestors = useCallback(
(targetId) => {
if (!targetId || targetId === 'root') {
setFolderNodes((prev) => {
if (prev.get('root')?.expanded) {
return prev;
}
const next = new Map(prev);
const rootNode = next.get('root');
if (rootNode) {
next.set('root', { ...rootNode, expanded: true });
}
return next;
});
return;
}
setFolderNodes((prev) => {
const next = new Map(prev);
let currentId = targetId;
let guard = 0;
while (currentId && !next.has(currentId) && guard < 32) {
guard += 1;
const node = prev.get(currentId);
if (!node) {
break;
}
currentId = node.parentId ?? 'root';
}
currentId = targetId;
guard = 0;
while (currentId && guard < 32) {
guard += 1;
const node = next.get(currentId);
if (!node) {
break;
}
if (!node.expanded && currentId !== targetId) {
next.set(currentId, { ...node, expanded: true });
}
currentId = node.parentId ?? 'root';
if (!currentId || currentId === 'root') {
const rootNode = next.get('root');
if (rootNode && !rootNode.expanded) {
next.set('root', { ...rootNode, expanded: true });
}
break;
}
}
return next;
});
},
[]);
const ensureFolderAncestorsLoaded = useCallback(
async (targetId) => {
if (!targetId || targetId === 'root') {
return;
}
const visited = new Set();
const stack = [];
let currentId = targetId;
let guard = 0;
while (currentId && currentId !== 'root' && guard < 32) {
guard += 1;
if (visited.has(currentId)) {
break;
}
visited.add(currentId);
const node = folderNodes.get(currentId);
if (!node) {
stack.push(currentId);
break;
}
const parentId = node.parentId ?? 'root';
if (!parentId || parentId === 'root') {
break;
}
stack.push(parentId);
currentId = parentId;
}
while (stack.length) {
const ancestorId = stack.pop();
if (!ancestorId || ancestorId === 'root') {
continue;
}
if (!folderNodes.has(ancestorId)) {
try {
await ensureFolderData(ancestorId, { includeDocuments: false, force: false });
} catch (error) {
console.warn('Failed to ensure ancestor folder for navigation', ancestorId, error);
}
}
}
},
[folderNodes, ensureFolderData],
);
const selectFolder = useCallback( const selectFolder = useCallback(
async (folderId, { replace = false, immediate = false } = {}) => { async (folderId, { replace = false, immediate = false } = {}) => {
const targetId = folderId && folderId !== 'root' ? folderId : 'root'; const targetId = folderId && folderId !== 'root' ? folderId : 'root';
await ensureFolderAncestorsLoaded(targetId);
expandFolderAncestors(targetId);
if (!navigate || immediate) { if (!navigate || immediate) {
await loadFolder(targetId, { preserveSearch: isFilterActive }); await loadFolder(targetId, { preserveSearch: isFilterActive });
setSelectedFolder(targetId);
return; return;
} }
const path = targetId === 'root' ? '/documents' : `/documents/folder/${targetId}`; const path = targetId === 'root' ? '/documents' : `/documents/folder/${targetId}`;
navigate(path, { replace }); navigate(path, { replace });
}, },
[loadFolder, navigate, isFilterActive], [
ensureFolderAncestorsLoaded,
expandFolderAncestors,
navigate,
loadFolder,
isFilterActive,
setSelectedFolder,
],
); );
const initializeAfterLogin = useCallback(async () => { const initializeAfterLogin = useCallback(async () => {
@@ -3682,6 +3805,24 @@ const AppLayout = () => {
setCreateFolderError(''); setCreateFolderError('');
}, [creatingFolder]); }, [creatingFolder]);
const openTagsModal = useCallback(() => {
setCorrespondentsModalOpen(false);
setTagsModalOpen(true);
}, []);
const closeTagsModal = useCallback(() => {
setTagsModalOpen(false);
}, []);
const openCorrespondentsModal = useCallback(() => {
setTagsModalOpen(false);
setCorrespondentsModalOpen(true);
}, []);
const closeCorrespondentsModal = useCallback(() => {
setCorrespondentsModalOpen(false);
}, []);
const handleCreateFolderSubmit = useCallback( const handleCreateFolderSubmit = useCallback(
async (event) => { async (event) => {
event.preventDefault(); event.preventDefault();
@@ -3742,6 +3883,31 @@ const AppLayout = () => {
}; };
}, [isCreateFolderModalOpen, closeCreateFolderModal]); }, [isCreateFolderModalOpen, closeCreateFolderModal]);
useEffect(() => {
setTagsModalOpen(false);
setCorrespondentsModalOpen(false);
}, [location.pathname]);
useEffect(() => {
if (!isTagsModalOpen && !isCorrespondentsModalOpen) {
return;
}
const handleKeyDown = (event) => {
if (event.key === 'Escape') {
event.preventDefault();
if (isTagsModalOpen) {
closeTagsModal();
} else if (isCorrespondentsModalOpen) {
closeCorrespondentsModal();
}
}
};
window.addEventListener('keydown', handleKeyDown);
return () => {
window.removeEventListener('keydown', handleKeyDown);
};
}, [isTagsModalOpen, isCorrespondentsModalOpen, closeTagsModal, closeCorrespondentsModal]);
useEffect(() => { useEffect(() => {
if (!token) return undefined; if (!token) return undefined;
@@ -4401,6 +4567,95 @@ const AppLayout = () => {
}); });
}, [missingBreadcrumbAncestors, ensureFolderData]); }, [missingBreadcrumbAncestors, ensureFolderData]);
useEffect(() => {
if (!orderedSelectedDocuments.length) {
return;
}
const visited = new Set();
orderedSelectedDocuments.forEach((doc) => {
const folderId = doc?.folder_id;
if (!folderId) {
return;
}
let currentId = folderId;
let guard = 0;
while (currentId && currentId !== 'root' && guard < 32) {
guard += 1;
if (visited.has(currentId)) {
break;
}
visited.add(currentId);
const node = folderNodes.get(currentId);
if (!node) {
if (!detailFolderFetchRef.current.has(currentId)) {
detailFolderFetchRef.current.add(currentId);
ensureFolderData(currentId, { force: false, includeDocuments: false })
.catch((error) => {
console.warn('Failed to preload folder metadata for detail path', currentId, error);
})
.finally(() => {
detailFolderFetchRef.current.delete(currentId);
});
}
break;
}
const parentId = node.parentId ?? 'root';
if (!parentId || parentId === 'root') {
break;
}
currentId = parentId;
}
});
}, [orderedSelectedDocuments, folderNodes, ensureFolderData]);
const resolveFolderPath = useCallback(
(folderId) => {
if (!folderId || folderId === 'root') {
return [];
}
const segments = [];
const visited = new Set();
let currentId = folderId;
let guard = 0;
while (currentId && guard < 32 && !visited.has(currentId)) {
guard += 1;
visited.add(currentId);
if (currentId === 'root') {
break;
}
const node = folderNodes.get(currentId);
if (!node) {
segments.push({ id: currentId, name: '…' });
break;
}
segments.push({ id: node.id, name: node.name || 'Folder' });
const parentId = node.parentId ?? 'root';
if (!parentId || parentId === 'root') {
segments.push({ id: 'root', name: DEFAULT_FOLDER_NAME });
break;
}
currentId = parentId;
}
if (!segments.some((segment) => segment.id === 'root')) {
segments.push({ id: 'root', name: DEFAULT_FOLDER_NAME });
}
return segments.reverse();
},
[folderNodes],
);
const selectedPreviewEntry = useMemo(() => { const selectedPreviewEntry = useMemo(() => {
if (!selectedDocument) { if (!selectedDocument) {
return null; return null;
@@ -4442,6 +4697,17 @@ const AppLayout = () => {
correspondents, correspondents,
activeCorrespondentIds: activeCorrespondentFilters, activeCorrespondentIds: activeCorrespondentFilters,
onToggleCorrespondentFilter: toggleCorrespondentFilter, onToggleCorrespondentFilter: toggleCorrespondentFilter,
appStatus,
loading,
previewActive,
searchQuery,
onSearchChange: handleSearchChange,
onSearchSubmit: handleSearchSubmit,
onSearchClear: clearFilters,
isFilterActive,
onLogout: handleLogout,
status,
onCollapse: collapseSidebar,
}; };
const resolveThumbnailUrlForDoc = useCallback( const resolveThumbnailUrlForDoc = useCallback(
@@ -4538,6 +4804,9 @@ const AppLayout = () => {
onCorrespondentAdd: handleCorrespondentAdd, onCorrespondentAdd: handleCorrespondentAdd,
onCorrespondentRemove: handleCorrespondentRemove, onCorrespondentRemove: handleCorrespondentRemove,
resolveApiPath, resolveApiPath,
onFolderNavigate: selectFolder,
onClose: clearDocumentSelection,
resolveFolderPath,
}; };
const skeuoWorkspaceProps = useMemo( const skeuoWorkspaceProps = useMemo(
@@ -4585,7 +4854,6 @@ const AppLayout = () => {
tags, tags,
refreshTags, refreshTags,
handleTagUpdate, handleTagUpdate,
handleTagCreate,
handleTagDelete, handleTagDelete,
handleDocumentTagAttach, handleDocumentTagAttach,
correspondents, correspondents,
@@ -4610,6 +4878,8 @@ const AppLayout = () => {
ensurePreviewData, ensurePreviewData,
notifyApiError, notifyApiError,
resolveApiPath, resolveApiPath,
openTagsModal,
openCorrespondentsModal,
}), }),
[ [
token, token,
@@ -4622,7 +4892,6 @@ const AppLayout = () => {
tags, tags,
refreshTags, refreshTags,
handleTagUpdate, handleTagUpdate,
handleTagCreate,
handleTagDelete, handleTagDelete,
handleDocumentTagAttach, handleDocumentTagAttach,
correspondents, correspondents,
@@ -4647,15 +4916,22 @@ const AppLayout = () => {
ensurePreviewData, ensurePreviewData,
notifyApiError, notifyApiError,
resolveApiPath, resolveApiPath,
openTagsModal,
openCorrespondentsModal,
], ],
); );
if (['logged-out', 'authenticating', 'selecting-tenant'].includes(appStatus)) { if (['logged-out', 'authenticating', 'selecting-tenant'].includes(appStatus)) {
const shouldRememberLastLocation = appStatus !== 'logged-out';
return ( return (
<Navigate <Navigate
to="/account/login" to="/account/login"
replace replace
state={{ from: location.pathname + location.search }} state={
shouldRememberLastLocation
? { from: location.pathname + location.search }
: undefined
}
/> />
); );
} }
@@ -4667,81 +4943,6 @@ const AppLayout = () => {
active={dropOverlayState.active} active={dropOverlayState.active}
folderName={dropOverlayState.folderName} folderName={dropOverlayState.folderName}
/> />
<header className="app-bar">
<div className="app-bar__main">
<div className="app-bar__meta">
<h1>Papercrate</h1>
<span className="app-bar__hint">
{appStatus === 'bootstrapping' && loading
? 'Loading your library…'
: previewActive
? 'Viewing document preview. Press ← Back to return to the library.'
: 'Drag files here to upload.'}
</span>
</div>
<div className="app-bar__search">
<input
type="search"
value={searchQuery}
onChange={(event) => setSearchQuery(event.target.value)}
placeholder="Search documents"
aria-label="Search documents"
onKeyDown={(event) => {
if (event.key === 'Enter') {
event.preventDefault();
handleSearchSubmit();
}
}}
/>
{isFilterActive && (
<button
type="button"
className="app-bar__search-clear"
onClick={clearFilters}
>
Clear
</button>
)}
</div>
<div className="app-bar__right">
<div className="app-bar__links">
<button
type="button"
className={`app-bar__link${isDocumentsRoute ? ' active' : ''}`}
onClick={() => navigate('/documents')}
>
Documents
</button>
<button
type="button"
className={`app-bar__link${isTagsRoute ? ' active' : ''}`}
onClick={() => navigate('/tags')}
>
Tags
<span className="app-bar__link-count">{tags.length}</span>
</button>
<button
type="button"
className={`app-bar__link${isCorrespondentsRoute ? ' active' : ''}`}
onClick={() => navigate('/correspondents')}
>
Correspondents
<span className="app-bar__link-count">{correspondents.length}</span>
</button>
</div>
{status && (
<div className="app-bar__status">
<StatusBanner status={status} />
</div>
)}
<div className="app-bar__actions">
<button className="secondary" onClick={handleLogout}>
Log out
</button>
</div>
</div>
</div>
</header>
<Outlet /> <Outlet />
{isCreateFolderModalOpen && ( {isCreateFolderModalOpen && (
<div <div
@@ -4791,6 +4992,74 @@ const AppLayout = () => {
</div> </div>
</div> </div>
)} )}
{isTagsModalOpen && (
<div
className="modal-backdrop"
role="presentation"
onClick={closeTagsModal}
>
<div
className="modal modal--panel"
role="dialog"
aria-modal="true"
aria-labelledby="tags-modal-title"
onClick={(event) => event.stopPropagation()}
>
<div className="panel-modal__header">
<h3 id="tags-modal-title">Manage Tags</h3>
<button type="button" className="secondary" onClick={closeTagsModal}>
Close
</button>
</div>
<div className="panel-modal__body">
<TagsPanel
tags={tags}
onRefresh={refreshTags}
onCreateTag={handleTagCreate}
onUpdateTag={handleTagUpdate}
onDeleteTag={handleTagDelete}
onNotify={setStatusMessage}
/>
</div>
</div>
</div>
)}
{isCorrespondentsModalOpen && (
<div
className="modal-backdrop"
role="presentation"
onClick={closeCorrespondentsModal}
>
<div
className="modal modal--panel"
role="dialog"
aria-modal="true"
aria-labelledby="correspondents-modal-title"
onClick={(event) => event.stopPropagation()}
>
<div className="panel-modal__header">
<h3 id="correspondents-modal-title">Manage Correspondents</h3>
<button
type="button"
className="secondary"
onClick={closeCorrespondentsModal}
>
Close
</button>
</div>
<div className="panel-modal__body">
<CorrespondentsPanel
correspondents={correspondents}
onRefresh={refreshCorrespondents}
onCreate={handleCorrespondentCreate}
onUpdate={handleCorrespondentUpdate}
onDelete={handleCorrespondentDelete}
onNotify={setStatusMessage}
/>
</div>
</div>
</div>
)}
</div> </div>
</AppShellContext.Provider> </AppShellContext.Provider>
); );
@@ -4803,20 +5072,212 @@ const DocumentsRoute = () => {
detailPanelProps, detailPanelProps,
workspaceMode, workspaceMode,
skeuoWorkspaceProps, skeuoWorkspaceProps,
openTagsModal,
openCorrespondentsModal,
exitSkeuoWorkspace,
} = useAppShell(); } = useAppShell();
const navigate = useNavigate();
const [sidebarCollapsed, setSidebarCollapsed] = useState(false);
const collapseSidebar = useCallback(() => setSidebarCollapsed(true), []);
const expandSidebar = useCallback(() => setSidebarCollapsed(false), []);
const sidebarPropsWithActions = useMemo(
() => ({
...sidebarProps,
onManageTags: openTagsModal,
onManageCorrespondents: openCorrespondentsModal,
onCollapse: collapseSidebar,
}),
[sidebarProps, openTagsModal, openCorrespondentsModal, collapseSidebar],
);
const {
currentFolderName,
viewMode,
onViewModeChange,
onRequestCreateFolder,
creatingFolder,
onRefresh,
onShowSkeuoWorkspace,
searchResults,
breadcrumbs,
} = documentsTableProps;
const isGridView = viewMode === 'grid';
const showingSearchResults = Array.isArray(searchResults);
const headerTitle = showingSearchResults ? 'Search results' : currentFolderName;
const headerSubtitle = showingSearchResults
? `${searchResults.length} matching document${searchResults.length === 1 ? '' : 's'}`
: null;
const parentBreadcrumb = breadcrumbs && breadcrumbs.length > 1 ? breadcrumbs[breadcrumbs.length - 2] : null;
const handleNavigateParent = parentBreadcrumb
? () => {
const target = parentBreadcrumb.id === 'root'
? '/documents'
: `/documents/folder/${parentBreadcrumb.id}`;
navigate(target);
}
: null;
const detailHasContent = detailPanelProps.selectedDocuments?.length > 0;
const toggleSidebar = sidebarCollapsed ? expandSidebar : collapseSidebar;
const ToggleIcon = sidebarCollapsed ? ChevronsRightIcon : ChevronsLeftIcon;
const toggleLabel = sidebarCollapsed ? 'Expand sidebar' : 'Collapse sidebar';
if (workspaceMode === 'skeuo') { if (workspaceMode === 'skeuo') {
return ( return (
<DocumentsLayout sidebarProps={sidebarProps}> <DocumentsLayout
sidebarProps={sidebarPropsWithActions}
sidebarCollapsed={sidebarCollapsed}
>
<div className="main-content">
<div className="panel-header main-content__header">
<div className="panel-actions main-content__actions">
{sidebarCollapsed ? (
<button
type="button"
className="icon-button ghost"
onClick={toggleSidebar}
aria-label={toggleLabel}
title={toggleLabel}
>
<ToggleIcon />
</button>
) : null}
{parentBreadcrumb ? (
<button
type="button"
className="icon-button ghost"
onClick={handleNavigateParent}
aria-label="Go to parent folder"
title="Go to parent folder"
>
<ArrowUpIcon />
</button>
) : null}
<h2 className="main-content__title">
{headerTitle}
{headerSubtitle ? (
<span className="main-content__subtitle">{headerSubtitle}</span>
) : null}
</h2>
<div className="spacer" />
<button
type="button"
className="icon-button ghost"
onClick={skeuoWorkspaceProps.onRefresh}
aria-label="Refresh"
title="Refresh"
>
<RefreshIcon />
</button>
<button type="button" className="secondary" onClick={exitSkeuoWorkspace}>
Back to List
</button>
</div>
</div>
<div className="main-content__body">
<SkeuomorphicWorkspace {...skeuoWorkspaceProps} /> <SkeuomorphicWorkspace {...skeuoWorkspaceProps} />
</div>
</div>
</DocumentsLayout> </DocumentsLayout>
); );
} }
return ( return (
<DocumentsLayout sidebarProps={sidebarProps}> <DocumentsLayout
<DocumentsTable {...documentsTableProps} /> sidebarProps={sidebarPropsWithActions}
sidebarCollapsed={sidebarCollapsed}
>
<div className={`main-content main-content--documents${detailHasContent ? ' main-content--has-detail' : ''}`}>
<div className="panel-header main-content__header">
<div className="panel-actions main-content__actions">
{sidebarCollapsed ? (
<button
type="button"
className="icon-button ghost"
onClick={toggleSidebar}
aria-label={toggleLabel}
title={toggleLabel}
>
<ToggleIcon />
</button>
) : null}
{parentBreadcrumb ? (
<button
type="button"
className="icon-button ghost"
onClick={handleNavigateParent}
aria-label="Go to parent folder"
title="Go to parent folder"
>
<ArrowUpIcon />
</button>
) : null}
<h2 className="main-content__title">
{headerTitle}
{headerSubtitle ? (
<span className="main-content__subtitle">{headerSubtitle}</span>
) : null}
</h2>
<div className="spacer" />
<div className="view-toggle" role="group" aria-label="Change view">
<button
type="button"
className={`view-toggle__button${isGridView ? '' : ' active'}`}
onClick={() => onViewModeChange?.('list')}
aria-pressed={!isGridView}
title="List view"
>
<ViewListIcon className="view-toggle__icon" size={18} />
</button>
<button
type="button"
className={`view-toggle__button${isGridView ? ' active' : ''}`}
onClick={() => onViewModeChange?.('grid')}
aria-pressed={isGridView}
title="Icons view"
>
<ViewGridIcon className="view-toggle__icon" size={18} />
</button>
</div>
<span className="main-content__actions-divider" aria-hidden="true">
<MinusVerticalIcon />
</span>
<button
type="button"
className="icon-button ghost"
onClick={onRequestCreateFolder}
disabled={creatingFolder}
aria-label={creatingFolder ? 'Creating folder…' : 'Create folder'}
title={creatingFolder ? 'Creating folder…' : 'Create folder'}
>
<FolderPlusIcon />
</button>
<button
type="button"
className="icon-button ghost"
onClick={onRefresh}
aria-label="Refresh"
title="Refresh"
>
<RefreshIcon />
</button>
<button className="secondary" type="button" onClick={onShowSkeuoWorkspace}>
Desk View
</button>
</div>
</div>
<div
className={`main-content__body main-content__body--documents${detailHasContent ? ' main-content__body--has-detail' : ''}`}
>
<DocumentsTable {...documentsTableProps} showHeader={false} />
</div>
{detailHasContent ? (
<DetailPanel {...detailPanelProps} /> <DetailPanel {...detailPanelProps} />
) : null}
</div>
</DocumentsLayout> </DocumentsLayout>
); );
}; };
@@ -4951,51 +5412,6 @@ const LoginRoute = () => {
); );
}; };
function TagsRoute() {
const {
tags,
refreshTags,
handleTagUpdate,
handleTagDelete,
setStatusMessage,
} = useAppShell();
return (
<main className="panels-main">
<TagsPanel
tags={tags}
onRefresh={refreshTags}
onUpdateTag={handleTagUpdate}
onDeleteTag={handleTagDelete}
onNotify={setStatusMessage}
/>
</main>
);
}
function CorrespondentsRoute() {
const {
correspondents,
refreshCorrespondents,
handleCorrespondentCreate,
handleCorrespondentUpdate,
handleCorrespondentDelete,
setStatusMessage,
} = useAppShell();
return (
<main className="panels-main">
<CorrespondentsPanel
correspondents={correspondents}
onRefresh={refreshCorrespondents}
onCreate={handleCorrespondentCreate}
onUpdate={handleCorrespondentUpdate}
onDelete={handleCorrespondentDelete}
onNotify={setStatusMessage}
/>
</main>
);
}
const AppRouter = () => ( const AppRouter = () => (
<Routes> <Routes>
<Route path="/account/login" element={<LoginRoute />} /> <Route path="/account/login" element={<LoginRoute />} />
@@ -5004,8 +5420,6 @@ const AppRouter = () => (
<Route path="/documents" element={<DocumentsRoute />} /> <Route path="/documents" element={<DocumentsRoute />} />
<Route path="/documents/folder/:folderId" element={<DocumentsRoute />} /> <Route path="/documents/folder/:folderId" element={<DocumentsRoute />} />
<Route path="/documents/:documentId" element={<DocumentViewerRoute />} /> <Route path="/documents/:documentId" element={<DocumentViewerRoute />} />
<Route path="/tags" element={<TagsRoute />} />
<Route path="/correspondents" element={<CorrespondentsRoute />} />
<Route path="*" element={<Navigate to="/documents" replace />} /> <Route path="*" element={<Navigate to="/documents" replace />} />
</Route> </Route>
</Routes> </Routes>
+103 -14
View File
@@ -1,5 +1,5 @@
import React, { useCallback, useMemo } from 'react'; import React, { useCallback, useMemo } from 'react';
import { ChevronIcon, TrashIcon, EditIcon, FolderIcon } from '../ui/icons'; import { ChevronIcon, TrashIcon, EditIcon, FolderIcon, ChevronsLeftIcon } from '../ui/icons';
import { getTagColorStyle } from '../utils/colors'; import { getTagColorStyle } from '../utils/colors';
@@ -136,6 +136,19 @@ const Sidebar = ({
correspondents = [], correspondents = [],
activeCorrespondentIds = [], activeCorrespondentIds = [],
onToggleCorrespondentFilter, onToggleCorrespondentFilter,
onManageTags,
onManageCorrespondents,
searchQuery = '',
onSearchChange,
onSearchSubmit,
onSearchClear,
isFilterActive,
appStatus,
loading,
previewActive,
onLogout,
status,
onCollapse,
}) => { }) => {
const sortedCorrespondents = useMemo( const sortedCorrespondents = useMemo(
() => () =>
@@ -150,6 +163,27 @@ const Sidebar = ({
); );
const handleToggleTag = onToggleTagFilter || (() => {}); const handleToggleTag = onToggleTagFilter || (() => {});
const activeTagSet = new Set(activeTagIds); const activeTagSet = new Set(activeTagIds);
const handleManageTags = onManageTags || (() => {});
const handleManageCorrespondents = onManageCorrespondents || (() => {});
const handleSearchInputChange = useCallback(
(event) => {
onSearchChange?.(event.target.value);
},
[onSearchChange],
);
const handleSearchFormSubmit = useCallback(
(event) => {
event.preventDefault();
onSearchSubmit?.();
},
[onSearchSubmit],
);
const handleSearchClear = useCallback(() => {
onSearchClear?.();
}, [onSearchClear]);
const handleLogoutClick = useCallback(() => {
onLogout?.();
}, [onLogout]);
const renderNodes = useCallback( const renderNodes = useCallback(
(ids, depth) => (ids, depth) =>
@@ -193,9 +227,54 @@ const Sidebar = ({
); );
const rootNode = folderNodes.get('root'); const rootNode = folderNodes.get('root');
const hintText = appStatus === 'bootstrapping' && loading
? 'Loading your library…'
: previewActive
? 'Viewing document preview. Press ← Back to return to the library.'
: 'Drag files here to upload.';
return ( return (
<aside className="sidebar column"> <aside className="sidebar">
<div className="panel-header sidebar__header">
<div className="panel-actions">
<h1 className="sidebar__title">Papercrate</h1>
<div className="spacer" />
{onCollapse ? (
<button
type="button"
className="icon-button ghost"
onClick={onCollapse}
aria-label="Collapse sidebar"
title="Collapse sidebar"
>
<ChevronsLeftIcon />
</button>
) : null}
</div>
</div>
<div className="panel-body sidebar__body">
<span className="sidebar__hint">{hintText}</span>
{status && (
<div className="sidebar__status">
<div className={`status-banner ${status.variant}`}>{status.message}</div>
</div>
)}
{onSearchChange && (
<form className="sidebar__search" onSubmit={handleSearchFormSubmit}>
<input
type="search"
value={searchQuery}
onChange={handleSearchInputChange}
placeholder="Search documents"
aria-label="Search documents"
/>
{isFilterActive && (
<button type="button" onClick={handleSearchClear}>
Clear
</button>
)}
</form>
)}
<div className="sidebar-section sidebar-section--folders"> <div className="sidebar-section sidebar-section--folders">
<div className="sidebar-section__header"> <div className="sidebar-section__header">
<h3>Folders</h3> <h3>Folders</h3>
@@ -206,8 +285,14 @@ const Sidebar = ({
</div> </div>
<div className="sidebar-section"> <div className="sidebar-section">
<div className="sidebar-section__header"> <div className="sidebar-section__header">
<button
type="button"
className="sidebar-section__title"
onClick={handleManageTags}
>
<h3>Tags</h3> <h3>Tags</h3>
<span className="meta">{tags.length}</span> <span className="meta">{tags.length}</span>
</button>
</div> </div>
<div <div
className={`sidebar-tag-cloud${ className={`sidebar-tag-cloud${
@@ -215,8 +300,7 @@ const Sidebar = ({
}`} }`}
role="list" role="list"
> >
{tags.length ? ( {tags.map((tag) => {
tags.map((tag) => {
const isActive = activeTagSet.has(tag.id); const isActive = activeTagSet.has(tag.id);
const style = getTagColorStyle(tag.color); const style = getTagColorStyle(tag.color);
const className = `sidebar-tag-pill${isActive ? ' active' : ''}`; const className = `sidebar-tag-pill${isActive ? ' active' : ''}`;
@@ -249,20 +333,22 @@ const Sidebar = ({
{tag.label} {tag.label}
</button> </button>
); );
}) })}
) : (
<span className="meta">No tags yet</span>
)}
</div> </div>
</div> </div>
<div className="sidebar-section"> <div className="sidebar-section">
<div className="sidebar-section__header"> <div className="sidebar-section__header">
<button
type="button"
className="sidebar-section__title"
onClick={handleManageCorrespondents}
>
<h3>Correspondents</h3> <h3>Correspondents</h3>
<span className="meta">{correspondents.length}</span> <span className="meta">{correspondents.length}</span>
</button>
</div> </div>
<ul className="sidebar-correspondent-list"> <ul className="sidebar-correspondent-list">
{sortedCorrespondents.length ? ( {sortedCorrespondents.map((correspondent) => {
sortedCorrespondents.map((correspondent) => {
const isActive = activeCorrespondentSet.has(correspondent.id); const isActive = activeCorrespondentSet.has(correspondent.id);
const className = `sidebar-correspondent-item${isActive ? ' active' : ''}`; const className = `sidebar-correspondent-item${isActive ? ' active' : ''}`;
const label = correspondent.name || 'Unnamed'; const label = correspondent.name || 'Unnamed';
@@ -287,12 +373,15 @@ const Sidebar = ({
</span> </span>
</li> </li>
); );
}) })}
) : (
<li className="meta">No correspondents yet</li>
)}
</ul> </ul>
</div> </div>
<div className="sidebar__footer">
<button className="secondary" type="button" onClick={handleLogoutClick}>
Log out
</button>
</div>
</div>
</aside> </aside>
); );
}; };
-55
View File
@@ -13,57 +13,6 @@
grid-column: 2 / -1; grid-column: 2 / -1;
min-height: 0; min-height: 0;
position: relative; position: relative;
background-color: var(--surface-subtle);
}
.skeuo-header {
display: flex;
align-items: flex-start;
justify-content: space-between;
gap: 1rem;
padding: 0.75rem 1rem 0.5rem;
background-color: var(--surface-subtle);
}
.skeuo-header__meta {
display: flex;
flex-direction: column;
gap: 0.35rem;
}
.skeuo-header__meta h2 {
margin: 0;
font-size: 1.25rem;
font-weight: 600;
}
.skeuo-breadcrumbs {
display: flex;
flex-wrap: wrap;
gap: 0.35rem;
font-size: 0.85rem;
color: var(--muted);
}
.skeuo-crumb {
display: inline-flex;
align-items: center;
gap: 0.35rem;
}
.skeuo-crumb.is-current {
color: var(--fg);
font-weight: 600;
}
.skeuo-crumb-separator {
opacity: 0.4;
}
.skeuo-header__actions {
display: flex;
align-items: center;
gap: 0.5rem;
} }
.skeuo-canvas { .skeuo-canvas {
@@ -119,10 +68,6 @@
transition: none; transition: none;
} }
.skeuo-item.is-zoomed {
cursor: pointer;
}
.skeuo-item.is-tag-target .skeuo-item__card { .skeuo-item.is-tag-target .skeuo-item__card {
outline: 1em dashed var(--accent); outline: 1em dashed var(--accent);
outline-offset: 1.41em; outline-offset: 1.41em;
+172 -138
View File
@@ -9,6 +9,7 @@ import React, {
import { resolveDocumentAssetUrl, createAssetView } from './asset_manager'; import { resolveDocumentAssetUrl, createAssetView } from './asset_manager';
import { useAssetNavigator } from './hooks/useAssetNavigator'; import { useAssetNavigator } from './hooks/useAssetNavigator';
import { ArrowLeftIcon, ArrowRightIcon } from './ui/icons'; import { ArrowLeftIcon, ArrowRightIcon } from './ui/icons';
import PreviewZoomOverlay from './detail/PreviewZoomOverlay';
import { getReadableTextColor } from './utils/colors'; import { getReadableTextColor } from './utils/colors';
import './skeuomorphic_ws.css'; import './skeuomorphic_ws.css';
@@ -28,9 +29,6 @@ const resolveSizeKey = (doc) =>
const CARD_MIN = 240; const CARD_MIN = 240;
const CARD_MAX = 340; const CARD_MAX = 340;
const EMPTY_CARD_ASPECT = 1.4; const EMPTY_CARD_ASPECT = 1.4;
const ZOOM_FILL_RATIO = 0.99;
const ZOOM_MIN_SCALE = 1.05;
const ZOOM_MAX_SCALE = 5;
const TAG_REMOVE_DISTANCE = 160; const TAG_REMOVE_DISTANCE = 160;
const DEBUG_DRAG = false; const DEBUG_DRAG = false;
@@ -52,6 +50,7 @@ const SkeuoPreviewCard = ({
getDocumentAsset, getDocumentAsset,
navScale = 1, navScale = 1,
prefetch = 3, prefetch = 3,
onNavigatorSnapshot,
}) => { }) => {
const navigator = useAssetNavigator({ const navigator = useAssetNavigator({
document: doc, document: doc,
@@ -62,6 +61,32 @@ const SkeuoPreviewCard = ({
}); });
const { currentUrl, cardinality, canGoPrev, canGoNext } = navigator; const { currentUrl, cardinality, canGoPrev, canGoNext } = navigator;
const docId = doc?.id ?? null;
useEffect(() => {
if (!onNavigatorSnapshot || !docId) {
return undefined;
}
const snapshot = {
url: currentUrl || null,
alt: title,
canGoPrev,
canGoNext,
goPrev: navigator.goPrev,
goNext: navigator.goNext,
};
onNavigatorSnapshot(docId, snapshot);
return () => onNavigatorSnapshot(docId, null);
}, [
docId,
currentUrl,
title,
canGoPrev,
canGoNext,
navigator.goPrev,
navigator.goNext,
onNavigatorSnapshot,
]);
const hasPreview = Boolean(currentUrl); const hasPreview = Boolean(currentUrl);
const cardClasses = ['skeuo-item__card']; const cardClasses = ['skeuo-item__card'];
if (!hasPreview) cardClasses.push('skeuo-item__card--empty'); if (!hasPreview) cardClasses.push('skeuo-item__card--empty');
@@ -303,7 +328,7 @@ const useDocumentDrag = ({
setDraggingId, setDraggingId,
syncLayoutSnapshot, syncLayoutSnapshot,
canvasSize, canvasSize,
toggleZoom, openOverlayForDoc,
}) => { }) => {
const dragStateRef = useRef(null); const dragStateRef = useRef(null);
@@ -330,7 +355,7 @@ const useDocumentDrag = ({
); );
const handlePointerDown = useCallback( const handlePointerDown = useCallback(
(event, docId, { lockWhenZoomed = false } = {}) => { (event, docId) => {
if (DEBUG_DRAG) { if (DEBUG_DRAG) {
console.log( console.log(
'[skeuo] handlePointerDown fired for doc', '[skeuo] handlePointerDown fired for doc',
@@ -376,7 +401,7 @@ const useDocumentDrag = ({
startY: event.clientY, startY: event.clientY,
rotation: entry?.rotation ?? 0, rotation: entry?.rotation ?? 0,
moved: false, moved: false,
locked: Boolean(lockWhenZoomed), locked: false,
width: docWidth, width: docWidth,
height: docHeight, height: docHeight,
scale: baseScale, scale: baseScale,
@@ -475,13 +500,19 @@ const useDocumentDrag = ({
const docId = state.docId; const docId = state.docId;
finishDrag(event.pointerId); finishDrag(event.pointerId);
if (!moved) { if (!moved) {
toggleZoom(docId); const originInfo = {
rotation: state.rotation || 0,
scale: state.scale || 1,
width: state.width,
height: state.height,
};
openOverlayForDoc(docId, originInfo);
} }
return; return;
} }
finishDrag(event.pointerId); finishDrag(event.pointerId);
}, },
[finishDrag, toggleZoom], [finishDrag, openOverlayForDoc],
); );
const handlePointerCancel = useCallback( const handlePointerCancel = useCallback(
@@ -547,10 +578,6 @@ const getContrastingTextColor = (hex) => getReadableTextColor(hex, { light: '#1f
const SkeuomorphicWorkspace = ({ const SkeuomorphicWorkspace = ({
documents = [], documents = [],
searchResults = null, searchResults = null,
breadcrumbs = [],
currentFolderName = 'Folder',
onExit,
onRefresh,
onDocumentOpen, onDocumentOpen,
resolveThumbnailUrl, resolveThumbnailUrl,
onAssignTagToDocument = null, onAssignTagToDocument = null,
@@ -560,7 +587,6 @@ const SkeuomorphicWorkspace = ({
activeTagIds = [], activeTagIds = [],
}) => { }) => {
const items = useMemo(() => (searchResults ? searchResults : documents), [documents, searchResults]); const items = useMemo(() => (searchResults ? searchResults : documents), [documents, searchResults]);
const showingSearchResults = searchResults !== null;
const containerRef = useRef(null); const containerRef = useRef(null);
@@ -572,7 +598,10 @@ const SkeuomorphicWorkspace = ({
const [canvasSize, setCanvasSize] = useState({ width: 0, height: 0 }); const [canvasSize, setCanvasSize] = useState({ width: 0, height: 0 });
const [draggingId, setDraggingId] = useState(null); const [draggingId, setDraggingId] = useState(null);
const [zoomedId, setZoomedId] = useState(null); const [overlayDocId, setOverlayDocId] = useState(null);
const [overlayOriginRect, setOverlayOriginRect] = useState(null);
const [overlayOriginTransform, setOverlayOriginTransform] = useState(null);
const [previewSnapshots, setPreviewSnapshots] = useState(() => new Map());
const [tagDropTargetId, setTagDropTargetId] = useState(null); const [tagDropTargetId, setTagDropTargetId] = useState(null);
const [pendingTagDocId, setPendingTagDocId] = useState(null); const [pendingTagDocId, setPendingTagDocId] = useState(null);
const [pendingRemovalTag, setPendingRemovalTag] = useState(null); const [pendingRemovalTag, setPendingRemovalTag] = useState(null);
@@ -580,6 +609,36 @@ const SkeuomorphicWorkspace = ({
const pendingDocTagDragRef = useRef(null); const pendingDocTagDragRef = useRef(null);
const docSizeMapRef = useRef(new Map()); const docSizeMapRef = useRef(new Map());
const removalCursorActiveRef = useRef(false); const removalCursorActiveRef = useRef(false);
const handleNavigatorSnapshot = useCallback((docId, snapshot) => {
if (!docId) {
return;
}
setPreviewSnapshots((previous) => {
const prevSnapshot = previous.get(docId);
if (!snapshot) {
if (!previous.has(docId)) {
return previous;
}
const next = new Map(previous);
next.delete(docId);
return next;
}
const next = new Map(previous);
const sameSnapshot =
prevSnapshot &&
prevSnapshot.url === snapshot.url &&
prevSnapshot.alt === snapshot.alt &&
prevSnapshot.canGoPrev === snapshot.canGoPrev &&
prevSnapshot.canGoNext === snapshot.canGoNext &&
prevSnapshot.goPrev === snapshot.goPrev &&
prevSnapshot.goNext === snapshot.goNext;
if (sameSnapshot) {
return previous;
}
next.set(docId, snapshot);
return next;
});
}, []);
const activeTagSet = useMemo(() => { const activeTagSet = useMemo(() => {
if (!Array.isArray(activeTagIds) || activeTagIds.length === 0) { if (!Array.isArray(activeTagIds) || activeTagIds.length === 0) {
return new Set(); return new Set();
@@ -779,70 +838,39 @@ const SkeuomorphicWorkspace = ({
docSizeMapRef.current = new Map(); docSizeMapRef.current = new Map();
}, [items]); }, [items]);
const resolveZoomMetrics = useCallback( const overlayDisplay = useMemo(() => {
(doc, cardWidth, cardHeight) => { if (!overlayDocId) {
const canvasWidth = canvasSize.width || DEFAULT_CANVAS_WIDTH; return null;
const canvasHeight = canvasSize.height || DEFAULT_CANVAS_HEIGHT;
const safeCardWidth = cardWidth || CARD_MIN;
const safeCardHeight = cardHeight || CARD_MIN;
const usableWidth = Math.max(canvasWidth - CANVAS_PADDING * 2, safeCardWidth);
const usableHeight = Math.max(canvasHeight - CANVAS_PADDING * 2, safeCardHeight);
const viewportTargetWidth = usableWidth * ZOOM_FILL_RATIO;
const viewportTargetHeight = usableHeight * ZOOM_FILL_RATIO;
let zoomWidth = safeCardWidth;
let zoomHeight = safeCardHeight;
const previewDims = doc ? resolvePreviewDimensions(doc) : null;
if (previewDims?.width && previewDims?.height) {
const previewWidth = previewDims.width;
const previewHeight = previewDims.height;
const widthScaleLimit = previewWidth > 0 ? viewportTargetWidth / previewWidth : 1;
const heightScaleLimit = previewHeight > 0 ? viewportTargetHeight / previewHeight : 1;
const scaleToFit = Math.min(1, widthScaleLimit || 1, heightScaleLimit || 1);
zoomWidth = previewWidth * scaleToFit;
zoomHeight = previewHeight * scaleToFit;
} else {
const rawScale = Math.min(
viewportTargetWidth / safeCardWidth,
viewportTargetHeight / safeCardHeight,
);
const boundedScale =
rawScale >= 1
? clamp(Math.max(rawScale, ZOOM_MIN_SCALE), ZOOM_MIN_SCALE, ZOOM_MAX_SCALE)
: rawScale;
zoomWidth = safeCardWidth * boundedScale;
zoomHeight = safeCardHeight * boundedScale;
} }
const snapshot = previewSnapshots.get(overlayDocId);
if (!Number.isFinite(zoomWidth) || zoomWidth <= 0) { if (!snapshot || !snapshot.url) {
zoomWidth = safeCardWidth; return null;
} }
if (!Number.isFinite(zoomHeight) || zoomHeight <= 0) { const doc = documentLookup.get(overlayDocId);
zoomHeight = safeCardHeight; const alt = snapshot.alt || doc?.title || doc?.original_name || 'Document preview';
}
zoomWidth = Math.max(zoomWidth, safeCardWidth);
zoomHeight = Math.max(zoomHeight, safeCardHeight);
const zoomTargetX = (canvasWidth - zoomWidth) / 2;
const zoomTargetY = (canvasHeight - zoomHeight) / 2;
const maxX = Math.max(CANVAS_PADDING, canvasWidth - zoomWidth - CANVAS_PADDING);
const maxY = Math.max(CANVAS_PADDING, canvasHeight - zoomHeight - CANVAS_PADDING);
const clampedX = clamp(zoomTargetX, CANVAS_PADDING, maxX);
const clampedY = clamp(zoomTargetY, CANVAS_PADDING, maxY);
const zoomCenterX = clampedX + zoomWidth / 2;
const zoomCenterY = clampedY + zoomHeight / 2;
return { return {
zoomWidth, url: snapshot.url,
zoomHeight, alt,
zoomCenterX, canGoPrev: snapshot.canGoPrev,
zoomCenterY, canGoNext: snapshot.canGoNext,
goPrev: snapshot.goPrev,
goNext: snapshot.goNext,
}; };
}, }, [overlayDocId, previewSnapshots, documentLookup]);
[canvasSize.width, canvasSize.height, resolvePreviewDimensions],
); const closeOverlay = useCallback(() => {
setOverlayDocId(null);
setOverlayOriginRect(null);
setOverlayOriginTransform(null);
}, []);
useEffect(() => {
if (overlayDocId && !documentLookup.has(overlayDocId)) {
setOverlayDocId(null);
setOverlayOriginRect(null);
setOverlayOriginTransform(null);
}
}, [overlayDocId, documentLookup]);
const resolveBaseMetrics = useCallback( const resolveBaseMetrics = useCallback(
(doc, cardWidth, cardHeight) => { (doc, cardWidth, cardHeight) => {
@@ -1014,17 +1042,62 @@ const SkeuomorphicWorkspace = ({
[syncLayoutSnapshot], [syncLayoutSnapshot],
); );
const toggleZoom = useCallback( const openOverlayForDoc = useCallback(
(docId) => { (docId, originInfo = null) => {
setZoomedId((current) => { if (!docId) {
if (current === docId) { return;
return null; }
const snapshot = previewSnapshots.get(docId);
if (!snapshot || !snapshot.url) {
return;
}
const container = itemRefs.current.get(docId);
const imageNode = container?.querySelector?.('.skeuo-item__card img');
if (!container || !imageNode) {
return;
}
const rect = imageNode.getBoundingClientRect();
let originTransform = null;
if (originInfo) {
const { rotation = 0, scale = 1, width: originWidth, height: originHeight } = originInfo;
originTransform = {
rotation,
scaleX: scale,
scaleY: scale,
baseWidth: originWidth,
baseHeight: originHeight,
};
}
if (!originTransform) {
const entry = layoutRef.current.get(docId) || null;
const doc = documentLookup.get(docId) || null;
const { width: cardWidth, height: cardHeight } = ensureDocumentSize(doc);
const { baseWidth, baseHeight, baseScale } = resolveBaseMetrics(doc, cardWidth, cardHeight);
const effectiveWidth = baseWidth * baseScale;
const effectiveHeight = baseHeight * baseScale;
originTransform = {
rotation: entry?.rotation ?? 0,
scaleX: baseScale,
scaleY: baseScale,
baseWidth: Number.isFinite(effectiveWidth) && effectiveWidth > 0 ? effectiveWidth : cardWidth,
baseHeight: Number.isFinite(effectiveHeight) && effectiveHeight > 0 ? effectiveHeight : cardHeight,
};
} }
bringToFront(docId); bringToFront(docId);
return docId; setOverlayOriginRect(rect);
}); setOverlayOriginTransform(originTransform);
setOverlayDocId(docId);
}, },
[bringToFront], [
bringToFront,
previewSnapshots,
itemRefs,
setOverlayOriginTransform,
ensureDocumentSize,
resolveBaseMetrics,
documentLookup,
layoutRef,
],
); );
const { handlePointerDown, handlePointerMove, handlePointerUp, handlePointerCancel } = useDocumentDrag({ const { handlePointerDown, handlePointerMove, handlePointerUp, handlePointerCancel } = useDocumentDrag({
layoutRef, layoutRef,
@@ -1036,7 +1109,7 @@ const SkeuomorphicWorkspace = ({
setDraggingId, setDraggingId,
syncLayoutSnapshot, syncLayoutSnapshot,
canvasSize, canvasSize,
toggleZoom, openOverlayForDoc,
}); });
const handleTagDragEnterDoc = useCallback( const handleTagDragEnterDoc = useCallback(
@@ -1489,40 +1562,9 @@ const SkeuomorphicWorkspace = ({
[queueFocusCanvas, handleTagDragEnd, onRemoveTagFromDocument, updateRemovalCursor], [queueFocusCanvas, handleTagDragEnd, onRemoveTagFromDocument, updateRemovalCursor],
); );
const renderBreadcrumbs = () => {
if (!breadcrumbs.length) return null;
return (
<nav className="skeuo-breadcrumbs" aria-label="Folder breadcrumbs">
{breadcrumbs.map((crumb, index) => {
const isLast = index === breadcrumbs.length - 1;
return (
<span key={crumb.id} className={`skeuo-crumb${isLast ? ' is-current' : ''}`}>
{crumb.name}
{!isLast && <span className="skeuo-crumb-separator"></span>}
</span>
);
})}
</nav>
);
};
return ( return (
<>
<div className="skeuo-shell"> <div className="skeuo-shell">
<header className="skeuo-header">
<div className="skeuo-header__meta">
<h2>{currentFolderName}</h2>
{renderBreadcrumbs()}
{showingSearchResults && <span className="meta">Showing search results</span>}
</div>
<div className="skeuo-header__actions">
<button type="button" className="secondary" onClick={onRefresh}>
Refresh
</button>
<button type="button" onClick={onExit}>
Back to List
</button>
</div>
</header>
<div <div
className="skeuo-canvas" className="skeuo-canvas"
ref={containerRef} ref={containerRef}
@@ -1550,31 +1592,17 @@ const SkeuomorphicWorkspace = ({
typeof layout.centerX === 'number' ? layout.centerX : fallbackLayout.centerX; typeof layout.centerX === 'number' ? layout.centerX : fallbackLayout.centerX;
const layoutCenterY = const layoutCenterY =
typeof layout.centerY === 'number' ? layout.centerY : fallbackLayout.centerY; typeof layout.centerY === 'number' ? layout.centerY : fallbackLayout.centerY;
const isZoomed = zoomedId === doc.id; const rotation = layout.rotation || 0;
const { zoomWidth, zoomHeight, zoomCenterX, zoomCenterY } = resolveZoomMetrics( const zoomScale = baseScale;
doc,
cardWidth,
cardHeight,
);
const targetCenterX = isZoomed ? zoomCenterX : layoutCenterX;
const targetCenterY = isZoomed ? zoomCenterY : layoutCenterY;
const rotation = isZoomed ? 0 : layout.rotation || 0;
const zoomScale = isZoomed
? Math.min(
1,
Number.isFinite(zoomWidth / baseWidth) ? zoomWidth / baseWidth : 1,
Number.isFinite(zoomHeight / baseHeight) ? zoomHeight / baseHeight : 1,
)
: baseScale;
const transform = formatTransform( const transform = formatTransform(
Math.round(targetCenterX), Math.round(layoutCenterX),
Math.round(targetCenterY), Math.round(layoutCenterY),
rotation, rotation,
zoomScale, zoomScale,
); );
const style = { const style = {
transform, transform,
zIndex: isZoomed ? 9999 : layout.z ?? 1, zIndex: layout.z ?? 1,
}; };
const bodyStyle = { const bodyStyle = {
width: Math.round(baseWidth), width: Math.round(baseWidth),
@@ -1595,7 +1623,6 @@ const SkeuomorphicWorkspace = ({
const dropPending = pendingTagDocId === doc.id; const dropPending = pendingTagDocId === doc.id;
const itemClasses = ['skeuo-item']; const itemClasses = ['skeuo-item'];
if (dragging) itemClasses.push('is-dragging'); if (dragging) itemClasses.push('is-dragging');
if (isZoomed) itemClasses.push('is-zoomed');
if (dropActive) itemClasses.push('is-tag-target'); if (dropActive) itemClasses.push('is-tag-target');
if (dropPending) itemClasses.push('is-tag-pending'); if (dropPending) itemClasses.push('is-tag-pending');
if (!matchesFilter) itemClasses.push('is-filtered-out'); if (!matchesFilter) itemClasses.push('is-filtered-out');
@@ -1616,9 +1643,7 @@ const SkeuomorphicWorkspace = ({
itemRefs.current.delete(doc.id); itemRefs.current.delete(doc.id);
} }
}} }}
onPointerDown={(event) => onPointerDown={(event) => handlePointerDown(event, doc.id)}
handlePointerDown(event, doc.id, { lockWhenZoomed: isZoomed })
}
onPointerMove={handlePointerMove} onPointerMove={handlePointerMove}
onPointerUp={handlePointerUp} onPointerUp={handlePointerUp}
onPointerCancel={handlePointerCancel} onPointerCancel={handlePointerCancel}
@@ -1640,6 +1665,7 @@ const SkeuomorphicWorkspace = ({
ensureAssetUrl={ensureAssetUrl} ensureAssetUrl={ensureAssetUrl}
getDocumentAsset={getDocumentAsset} getDocumentAsset={getDocumentAsset}
navScale={inverseTagScale} navScale={inverseTagScale}
onNavigatorSnapshot={handleNavigatorSnapshot}
/> />
{tags.length > 0 && ( {tags.length > 0 && (
<div className="skeuo-item__tags" aria-hidden="true" style={tagsStyle}> <div className="skeuo-item__tags" aria-hidden="true" style={tagsStyle}>
@@ -1687,6 +1713,14 @@ const SkeuomorphicWorkspace = ({
)} )}
</div> </div>
</div> </div>
<PreviewZoomOverlay
open={Boolean(overlayDisplay?.url)}
display={overlayDisplay}
onClose={closeOverlay}
originRect={overlayOriginRect}
originTransform={overlayOriginTransform}
/>
</>
); );
}; };
+634 -363
View File
File diff suppressed because it is too large Load Diff
+86 -8
View File
@@ -1,12 +1,22 @@
import React, { useCallback, useMemo, useState } from 'react'; import React, { useCallback, useMemo, useState } from 'react';
import { getTagColorStyle, HEX_COLOR_PATTERN } from '../utils/colors'; import { getTagColorStyle, HEX_COLOR_PATTERN } from '../utils/colors';
function TagsPanel({ tags, onRefresh, onUpdateTag, onDeleteTag, onNotify }) { function TagsPanel({
tags,
onRefresh,
onCreateTag,
onUpdateTag,
onDeleteTag,
onNotify,
}) {
const [editingId, setEditingId] = useState(null); const [editingId, setEditingId] = useState(null);
const [draftLabel, setDraftLabel] = useState(''); const [draftLabel, setDraftLabel] = useState('');
const [draftColor, setDraftColor] = useState(''); const [draftColor, setDraftColor] = useState('');
const [saving, setSaving] = useState(false); const [saving, setSaving] = useState(false);
const [deletingId, setDeletingId] = useState(null); const [deletingId, setDeletingId] = useState(null);
const [createLabel, setCreateLabel] = useState('');
const [createColor, setCreateColor] = useState('');
const [creating, setCreating] = useState(false);
const startEdit = useCallback((tag) => { const startEdit = useCallback((tag) => {
setEditingId(tag.id); setEditingId(tag.id);
@@ -98,25 +108,93 @@ function TagsPanel({ tags, onRefresh, onUpdateTag, onDeleteTag, onNotify }) {
[onDeleteTag, editingId, cancelEdit, onNotify], [onDeleteTag, editingId, cancelEdit, onNotify],
); );
const handleCreate = useCallback(
async (event) => {
event.preventDefault();
if (typeof onCreateTag !== 'function') {
return;
}
const trimmedLabel = createLabel.trim();
if (!trimmedLabel) {
onNotify?.('Tag label cannot be empty.', 'error');
return;
}
const trimmedColor = createColor.trim();
const colorPattern = /^#([0-9a-fA-F]{6})$/;
if (trimmedColor && !colorPattern.test(trimmedColor)) {
onNotify?.('Colors must use the #RRGGBB format.', 'error');
return;
}
setCreating(true);
try {
await onCreateTag({
label: trimmedLabel,
color: trimmedColor ? trimmedColor : null,
});
setCreateLabel('');
setCreateColor('');
} catch (createError) {
const message = createError?.message || 'Failed to create tag.';
onNotify?.(message, 'error');
} finally {
setCreating(false);
}
},
[createLabel, createColor, onCreateTag, onNotify],
);
return ( return (
<section className="tags-panel column"> <section className="tags-panel">
<div className="column-header"> <div className="panel-section__header">
<div className="column-header__titles"> <div className="panel-section__titles">
<h2>Tags</h2> <h2>Tags</h2>
<div className="column-subtitle">{tags.length} total</div> <div className="panel-section__subtitle">{tags.length} total</div>
</div> </div>
<div className="header-actions"> <div className="header-actions tags-actions">
<form className="tags-actions__form" onSubmit={handleCreate}>
<input
type="text"
placeholder="New tag label"
value={createLabel}
onChange={(event) => setCreateLabel(event.target.value)}
disabled={creating}
/>
<input
type="color"
className="tags-table__color-picker"
value={createColor || '#3366ff'}
onChange={(event) => setCreateColor(event.target.value)}
disabled={creating}
aria-label="Tag color (optional)"
/>
{createColor && (
<button
type="button"
className="secondary"
onClick={() => setCreateColor('')}
disabled={creating}
>
Clear
</button>
)}
<button type="submit" disabled={creating || !createLabel.trim()}>
{creating ? 'Creating…' : 'Create'}
</button>
</form>
<button <button
className="secondary" className="secondary"
type="button" type="button"
onClick={onRefresh} onClick={onRefresh}
disabled={saving || Boolean(deletingId)} disabled={saving || creating || Boolean(deletingId)}
> >
Refresh Refresh
</button> </button>
</div> </div>
</div> </div>
<div className="column-body tags-panel__body"> <div className="panel-section__body tags-panel__body">
{tags.length === 0 ? ( {tags.length === 0 ? (
<div className="empty-state">No tags created yet.</div> <div className="empty-state">No tags created yet.</div>
) : ( ) : (
+98
View File
@@ -9,6 +9,15 @@ import {
IconLayoutGrid, IconLayoutGrid,
IconArrowLeft, IconArrowLeft,
IconArrowRight, IconArrowRight,
IconArrowUp,
IconChevronsRight,
IconChevronsLeft,
IconAnalyze,
IconWindowMaximize,
IconTextScan2,
IconFolderPlus,
IconRefresh,
IconMinusVertical,
} from '@tabler/icons-react'; } from '@tabler/icons-react';
import FolderSvg from '../assets/folder.svg'; import FolderSvg from '../assets/folder.svg';
@@ -120,6 +129,78 @@ export const ArrowRightIcon = ({ className, size = '1em', stroke = 1.6, ...rest
/> />
); );
export const ChevronsLeftIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconChevronsLeft
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const ChevronsRightIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconChevronsRight
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const FolderPlusIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconFolderPlus
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const RefreshIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconRefresh
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const ArrowUpIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconArrowUp
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const MinusVerticalIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconMinusVertical
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const AnalyzeIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconAnalyze
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export const WindowMaximizeIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconWindowMaximize
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);
export default { export default {
ChevronIcon, ChevronIcon,
TrashIcon, TrashIcon,
@@ -130,4 +211,21 @@ export default {
DownloadIcon, DownloadIcon,
ViewListIcon, ViewListIcon,
ViewGridIcon, ViewGridIcon,
ChevronsLeftIcon,
ChevronsRightIcon,
AnalyzeIcon,
WindowMaximizeIcon,
FolderPlusIcon,
RefreshIcon,
ArrowUpIcon,
MinusVerticalIcon,
}; };
export const TextScanIcon = ({ className, size = '1em', stroke = 1.6, ...rest }) => (
<IconTextScan2
className={composeClassName('icon', className)}
size={size}
stroke={stroke}
{...rest}
/>
);