no-password

backend/src/bin/admin.rs

@@ -7,7 +7,6 @@ use reqwest::{Client, Method, StatusCode};
 use uuid::Uuid;
 
 use backend::{
-    auth::password,
     config::AppConfig,
     db::{self, PgPool},
     documents::search::ensure_quickwit_index,
@@ -28,11 +27,6 @@ use backend::{
 enum Command {
     CreateUser {
         username: String,
-        password: String,
-    },
-    SetPassword {
-        username: String,
-        password: String,
     },
     ListUsers,
     DeleteUser {
@@ -66,8 +60,7 @@ enum Command {
 impl Command {
     fn usage() -> &'static str {
         "Usage: admin\n\
-            create-user <username> <password>\n\
-            set-password <username> <password>\n\
+            create-user <username>\n\
             list-users\n\
             delete-user <username>\n\
             create-tenant <name> [storage_root] [quickwit_index]\n\
@@ -91,11 +84,6 @@ impl Command {
         match args.next().as_deref() {
             Some("create-user") => Ok(Self::CreateUser {
                 username: args.next().ok_or_else(|| anyhow!("username required"))?,
-                password: args.next().ok_or_else(|| anyhow!("password required"))?,
-            }),
-            Some("set-password") => Ok(Self::SetPassword {
-                username: args.next().ok_or_else(|| anyhow!("username required"))?,
-                password: args.next().ok_or_else(|| anyhow!("password required"))?,
             }),
             Some("list-users") => Ok(Self::ListUsers),
             Some("delete-user") => Ok(Self::DeleteUser {
@@ -141,8 +129,7 @@ async fn main() -> Result<()> {
     let pool = db::init_pool_with_size(&config.database_url, config.database_max_pool_size)?;
 
     match command {
-        Command::CreateUser { username, password } => create_user(&pool, &username, &password)?,
-        Command::SetPassword { username, password } => set_password(&pool, &username, &password)?,
+        Command::CreateUser { username } => create_user(&pool, &username)?,
         Command::ListUsers => list_users(&pool)?,
         Command::DeleteUser { username } => delete_user(&pool, &username)?,
         Command::CreateTenant {
@@ -175,13 +162,10 @@ async fn main() -> Result<()> {
     Ok(())
 }
 
-fn create_user(pool: &PgPool, username: &str, password: &str) -> Result<()> {
+fn create_user(pool: &PgPool, username: &str) -> Result<()> {
     if username.trim().is_empty() {
         bail!("username must not be empty");
     }
-    if password.is_empty() {
-        bail!("password must not be empty");
-    }
 
     let mut conn = pool.get().context("failed to get database connection")?;
     let exists: bool =
@@ -190,11 +174,9 @@ fn create_user(pool: &PgPool, username: &str, password: &str) -> Result<()> {
         bail!("user '{}' already exists", username);
     }
 
-    let password_hash = password::hash_password(password).map_err(|err| anyhow!(err))?;
     let new_user = NewUser {
         id: Uuid::new_v4(),
         username: username.to_string(),
-        password_hash,
     };
 
     diesel::insert_into(users::table)
@@ -205,26 +187,6 @@ fn create_user(pool: &PgPool, username: &str, password: &str) -> Result<()> {
     Ok(())
 }
 
-fn set_password(pool: &PgPool, username: &str, password: &str) -> Result<()> {
-    if password.is_empty() {
-        bail!("password must not be empty");
-    }
-
-    let mut conn = pool.get().context("failed to get database connection")?;
-    let password_hash = password::hash_password(password).map_err(|err| anyhow!(err))?;
-
-    let updated = diesel::update(users::table.filter(users::username.eq(username)))
-        .set(users::password_hash.eq(password_hash))
-        .execute(&mut conn)?;
-
-    if updated == 0 {
-        bail!("user '{}' not found", username);
-    }
-
-    println!("updated password for '{}'", username);
-    Ok(())
-}
-
 fn list_users(pool: &PgPool) -> Result<()> {
     let mut conn = pool.get().context("failed to get database connection")?;