error handling

backend/src/auth/webdav_tokens.rs

@@ -141,14 +141,20 @@ pub fn touch_webdav_token(conn: &mut PgPooledConnection, token_id: Uuid) -> Resu
 
 pub fn verify_token_secret(secret: &str, token_hash: &str) -> Result<bool, AppError> {
     crate::auth::password::verify_password(secret, token_hash)
-        .map_err(|err| AppError::internal(format!("failed to verify token: {err}")))
+        .map_err(|err| {
+            tracing::error!(error = ?err, "failed to verify token");
+            AppError::internal("failed to verify token")
+        })
 }
 
 fn generate_secret() -> Result<String, AppError> {
     let mut buffer = [0u8; TOKEN_SECRET_LENGTH];
     OsRng
         .try_fill_bytes(&mut buffer)
-        .map_err(|err| AppError::internal(format!("failed to generate token: {err}")))?;
+        .map_err(|err| {
+            tracing::error!(error = ?err, "failed to generate token");
+            AppError::internal("failed to generate token")
+        })?;
     Ok(hex::encode(buffer))
 }
 
@@ -156,7 +162,10 @@ fn hash_secret(secret: &str) -> Result<String, AppError> {
     let salt = SaltString::generate(&mut OsRng);
     let hash = Argon2::default()
         .hash_password(secret.as_bytes(), &salt)
-        .map_err(|err| AppError::internal(format!("failed to hash token: {err}")))?;
+        .map_err(|err| {
+            tracing::error!(error = ?err, "failed to hash token");
+            AppError::internal("failed to hash token")
+        })?;
     Ok(hash.to_string())
 }