refactor: streamline hook integration and context object creation in useDocumentsWorkspace by directly using hook return values and consolidating related state.

frontend/src/documents/data/useDocumentsWorkspace.ts

@@ -58,7 +58,7 @@ import { useApi } from '../../lib/context/ApiContext';
 import { useWorkspaceSelection } from '../../app/useWorkspaceSelection';
 import useDocumentPreview from '../../app/useDocumentPreview';
 import type { DocumentId, FolderNodeId, Identifier } from '../../types/identifiers';
-import type { Document, Tag } from '../../types/documents';
+import type { Document } from '../../types/documents';
 
 const EntryType = Object.freeze({
   document: 'document',
@@ -394,7 +394,6 @@ const useDocumentsWorkspace = ({
     setActiveTagFilters,
     activeCorrespondentFilters,
     setActiveCorrespondentFilters,
-    isFilterActive,
     documentsFilterValue,
   } = useDocumentsSearch({
     api: apiClient,
@@ -484,57 +483,21 @@ const useDocumentsWorkspace = ({
     selectionInitializedRef,
   });
 
-  const tagsStateRaw = useTags({
+  const tagsState = useTags({
     tenantIdRef,
     tagManager,
     setActiveTagFilters,
     documentsManager,
   });
 
-  useEffect(() => {
+  // Correspondents state
-    tagManager.ensureAll().catch((err) => console.warn('Failed to bootstrap tags', err));
+  const correspondentsState = useCorrespondents({
-  }, [tagManager]);
-
-  const {
-    tags,
-    refreshTags,
-    handleTagCreate,
-    handleTagUpdate,
-    handleTagDelete,
-  } = tagsStateRaw;
-
-  // tagLookupById is derived locally
-  useEffect(() => {
-    tenantIdRef.current = currentTenantId;
-  }, [currentTenantId, tenantIdRef]);
-
-  const tagLookupById = new Map<Identifier, Tag>();
-  tags.forEach((tag) => {
-    if (tag?.id) {
-      tagLookupById.set(tag.id, tag);
-    }
-  });
-
-  const tagsState = {
-    ...tagsStateRaw,
-    tags,
-    tagLookupById,
-    tagManager,
-  };
-
-  const correspondentsStateRaw = useCorrespondents({
     correspondentManager,
     documentsManager,
   });
 
-  const {
+  const { refreshTags } = tagsState;
-    correspondents,
+  const { refreshCorrespondents } = correspondentsState;
-    correspondentLookupById,
-    refreshCorrespondents,
-    handleCorrespondentCreate,
-    handleCorrespondentUpdate,
-    handleCorrespondentDelete,
-  } = correspondentsStateRaw;
 
   // Prefetch tags/correspondents when tenant changes
   useEffect(() => {
@@ -542,16 +505,7 @@ const useDocumentsWorkspace = ({
     refreshCorrespondents();
   }, [refreshTags, refreshCorrespondents, currentTenantId]);
 
-  const {
+  const passkeys = usePasskeys({});
-    passkeys,
-    passkeysSupported,
-    passkeysLoading,
-    registeringPasskey,
-    revokingPasskeyId,
-    refreshPasskeys,
-    registerPasskey,
-    revokePasskey,
-  } = usePasskeys({});
 
   const resolveTargetDocumentIds = useCallback(
     (candidateIds) => {
@@ -588,21 +542,14 @@ const useDocumentsWorkspace = ({
     handleBulkTagRemoveFromDetail,
     handleBulkSelectionReanalyze,
   } = useDocumentTagActions({
-    tags,
+    tags: tagsState.tags,
     tagManager,
-    refreshTags,
+    refreshTags: tagsState.refreshTags,
     resolveTargetDocumentIds,
     documentsManager,
   });
 
-  const {
+  const upload = useDocumentUploads({
-    dropOverlayState,
-    handleFileDrop,
-    uploadQueue,
-    clearUploadQueue,
-    resetUploadsState,
-    handleFileSelection,
-  } = useDocumentUploads({
     selectedFolder,
     currentFolderName,
     refreshCurrentFolder: refreshFolderData,
@@ -645,8 +592,8 @@ const useDocumentsWorkspace = ({
     detailPanelControlRef.current.close();
     assetManager.reset();
     resetPreviewState();
-    resetUploadsState();
+    upload.resetUploadsState();
-    clearUploadQueue();
+    upload.clearUploadQueue();
 
     detailFolderFetchRef.current = new Set();
     bootstrapInitializedRef.current = false;
@@ -671,8 +618,7 @@ const useDocumentsWorkspace = ({
     setActiveCorrespondentFilters,
     setActivePreviewId,
     resetPreviewState,
-    resetUploadsState,
+    upload,
-    clearUploadQueue,
   ]);
 
   useEffect(() => {
@@ -695,6 +641,22 @@ const useDocumentsWorkspace = ({
     closeDocumentPreview,
   };
 
+  const documentMutationsResult = useDocumentMutations({
+    documentsState,
+    folderState,
+    selectionState,
+    tagsState: {
+      ...tagsState,
+      tagManager,
+    },
+    correspondentsState: {
+      ...correspondentsState,
+      correspondentManager,
+    },
+    actions: actionsState,
+    previewDocumentId,
+  });
+
   const {
     moveDocumentsToFolder,
     handleThumbnailRegeneration,
@@ -708,20 +670,14 @@ const useDocumentsWorkspace = ({
     handleDocumentCorrespondentDetach,
     handleDocumentCorrespondentAdd,
     correspondentLookupByName,
-  } = useDocumentMutations({
+  } = documentMutationsResult;
-    documentsState,
+
-    folderState,
+  const mutations = {
-    selectionState,
+    ...documentMutationsResult,
-    tagsState,
+    handleDocumentDragStart,
-    correspondentsState: {
+    handleDocumentDragEnd,
-      correspondents,
+    draggedDocumentIds,
-      correspondentLookupById,
+  };
-      refreshCorrespondents,
-      correspondentManager,
-    },
-    actions: actionsState,
-    previewDocumentId,
-  });
 
   const dragState = {
     draggedDocumentIds,
@@ -730,18 +686,11 @@ const useDocumentsWorkspace = ({
     setDraggedFolderId,
   };
 
-  const {
+  const folderActions = useFolderTreeActions({
-    loadFolder,
-    selectFolder,
-    handleFolderRename,
-    handleFolderCreate,
-    handleFolderDelete,
-    folderClickHandlers,
-  } = useFolderTreeActions({
     folderState,
     dragState,
     actions: {
-      handleFileDrop,
+      handleFileDrop: upload.handleFileDrop,
       moveDocumentsToFolder,
     },
     utils: {
@@ -750,8 +699,13 @@ const useDocumentsWorkspace = ({
   });
 
   const {
-    clearDocumentSelection,
+    loadFolder,
-  } = useDocumentsSelection({
+    selectFolder,
+    handleFolderCreate,
+    handleFolderDelete,
+  } = folderActions;
+
+  const selectionContext = useDocumentsSelection({
     showingSearchResults,
     currentSubfolders: visibleSubfolders,
     visibleDocuments: viewDocuments,
@@ -767,6 +721,7 @@ const useDocumentsWorkspace = ({
     setFocusedEntryKey,
     focusedEntryKey,
   });
+
   const initializeAfterLogin = useCallback(async () => {
     await Promise.all([
       refreshTags(),
@@ -801,7 +756,6 @@ const useDocumentsWorkspace = ({
     routeFolderId,
     routeDocumentId,
     selectedFolder,
-    isFilterActive,
     selectFolder,
   ]);
 
@@ -849,12 +803,12 @@ const useDocumentsWorkspace = ({
   } = useBulkDocumentActions({
     resolveTargetDocumentIds,
     correspondentLookupByName,
-    handleCorrespondentCreate,
+    handleCorrespondentCreate: correspondentsState.handleCorrespondentCreate,
     selectedDocumentIds,
     selectedFolderIds,
     handleDocumentsDelete,
     handleFolderDelete,
-    clearDocumentSelection,
+    clearDocumentSelection: selectionContext.clearDocumentSelection,
     documentsManager,
   });
 
@@ -913,17 +867,17 @@ const useDocumentsWorkspace = ({
 
   const { managementModals, openTagsModal, openCorrespondentsModal } = useManagementModals({
     locationPathname: location.pathname,
-    tags,
+    tags: tagsState.tags,
-    refreshTags,
+    refreshTags: tagsState.refreshTags,
-    onTagCreate: handleTagCreate,
+    onTagCreate: tagsState.handleTagCreate,
-    onTagUpdate: async (tagId: string, changes: any) => { await handleTagUpdate(tagId, changes); },
+    onTagUpdate: async (tagId: string, changes: any) => { await tagsState.handleTagUpdate(tagId, changes); },
-    onTagDelete: async (tagId: string) => { await handleTagDelete(tagId); },
+    onTagDelete: async (tagId: string) => { await tagsState.handleTagDelete(tagId); },
-    correspondents,
+    correspondents: correspondentsState.correspondents,
-    correspondentLookupById,
+    correspondentLookupById: correspondentsState.correspondentLookupById,
-    refreshCorrespondents,
+    refreshCorrespondents: correspondentsState.refreshCorrespondents,
-    onCorrespondentCreate: handleCorrespondentCreate,
+    onCorrespondentCreate: correspondentsState.handleCorrespondentCreate,
-    onCorrespondentUpdate: handleCorrespondentUpdate,
+    onCorrespondentUpdate: correspondentsState.handleCorrespondentUpdate,
-    onCorrespondentDelete: handleCorrespondentDelete,
+    onCorrespondentDelete: correspondentsState.handleCorrespondentDelete,
     correspondentManager,
   });
 
@@ -971,13 +925,13 @@ const useDocumentsWorkspace = ({
     handleDocumentTagDetach,
     ensureAssetUrl,
     getAsset: getDocumentAsset,
-    correspondents,
+    correspondents: correspondentsState.correspondents,
     handleCorrespondentAdd: handleDocumentCorrespondentAdd,
     handleCorrespondentRemove: handleDocumentCorrespondentDetach,
     selectFolder,
-    tags,
+    tags: tagsState.tags,
-    tagLookupById,
+    tagLookupById: tagsState.tagLookupById,
-    correspondentLookupById,
+    correspondentLookupById: correspondentsState.correspondentLookupById,
   });
 
   const handleEntryPointerCore = useEntryPointerCore({
@@ -1009,7 +963,7 @@ const useDocumentsWorkspace = ({
     handleDocumentsViewModeChange,
   });
 
-  const sessionContext = {
+  const session = {
     token,
     appStatus,
     handleLogout,
@@ -1019,7 +973,7 @@ const useDocumentsWorkspace = ({
     handleTenantSelect,
   };
 
-  const uiContext = {
+  const ui = {
     notifyApiError,
     settingsOpen,
     openSettings,
@@ -1028,21 +982,11 @@ const useDocumentsWorkspace = ({
     refreshCurrentFolder: handleManualRefresh,
   };
 
-  const uploadContext = {
+  const tags = {
-    dropOverlayState,
+    ...tagsState,
-    uploadQueue,
+    tagManager,
-    clearUploadQueue,
-    handleFileSelection,
-  };
-
-  const tagsContext = {
-    tags,
-    refreshTags,
-    tagLookupById,
     activeTagFilters,
-    handleTagUpdate,
+    // Add derived/action handlers that were previously in tagsContext
-    handleTagCreate,
-    handleTagDelete,
     handleDocumentTagAttach,
     handleDocumentTagDetach,
     handleBulkTagAddFromDetail,
@@ -1050,14 +994,10 @@ const useDocumentsWorkspace = ({
     openTagsModal,
   };
 
-  const correspondentsContext = {
+  const correspondents = {
-    correspondents,
+    ...correspondentsState,
-    correspondentLookupById,
-    refreshCorrespondents,
     activeCorrespondentFilters,
-    handleCorrespondentUpdate,
+    // Add derived/action handlers
-    handleCorrespondentCreate,
-    handleCorrespondentDelete,
     handleDocumentCorrespondentAttach,
     handleDocumentCorrespondentDetach,
     handleDocumentCorrespondentAdd,
@@ -1066,18 +1006,7 @@ const useDocumentsWorkspace = ({
     openCorrespondentsModal,
   };
 
-  const passkeysContext = {
+  const preview = {
-    passkeys,
-    passkeysSupported,
-    passkeysLoading,
-    registeringPasskey,
-    revokingPasskeyId,
-    refreshPasskeys,
-    registerPasskey,
-    revokePasskey,
-  };
-
-  const previewContext = {
     previewActive,
     previewWorkspaceDocument,
     previewDocumentId,
@@ -1087,13 +1016,13 @@ const useDocumentsWorkspace = ({
     handleThumbnailRegeneration,
   };
 
-  const detailPanelContext = {
+  const detailPanel = {
     detailPanelProps,
     detailPanelOpen,
     openDetailPanel,
   };
 
-  const searchContext = {
+  const search = {
     searchQuery,
     documentsFilter,
     searchLoading,
@@ -1107,18 +1036,18 @@ const useDocumentsWorkspace = ({
     documents: viewDocuments,
   };
 
-  const folderTreeContext = {
+  const folderTree = {
     foldersManager,
     selectedFolder,
     currentFolderName,
     folderOptions,
     handleBreadcrumbNavigate,
     resolveFolderPath,
-    selectFolder,
+    selectFolder: folderActions.selectFolder,
     moveDocumentsToFolder,
-    folderClickHandlers,
+    folderClickHandlers: folderActions.folderClickHandlers,
-    handleFolderRename,
+    handleFolderRename: folderActions.handleFolderRename,
-    handleFolderDelete,
+    handleFolderDelete: folderActions.handleFolderDelete,
     handleFolderDragStart,
     handleFolderDragEnd,
     draggedFolderId,
@@ -1128,40 +1057,33 @@ const useDocumentsWorkspace = ({
     breadcrumbs,
   };
 
-  const selectionContext = {
+  const selection = {
-    clearDocumentSelection,
+    clearDocumentSelection: selectionContext.clearDocumentSelection,
     handleDeleteSelection,
     handleEntryPointerCore,
     handleBulkSelectionReanalyze,
     selectionValue: selectionState,
   };
 
-  const documentMutations = {
-    handleDocumentTitleUpdate,
-    handleDocumentDragStart,
-    handleDocumentDragEnd,
-    draggedDocumentIds,
-  };
-
   const managers = {
     documentsManager,
     documentLookup,
   };
 
   const contextValue = {
-    session: sessionContext,
+    session,
-    ui: uiContext,
+    ui,
-    upload: uploadContext,
+    upload,
-    tags: tagsContext,
+    tags,
-    correspondents: correspondentsContext,
+    correspondents,
-    passkeys: passkeysContext,
+    passkeys,
-    preview: previewContext,
+    preview,
-    detailPanel: detailPanelContext,
+    detailPanel,
-    search: searchContext,
+    search,
-    folderTree: folderTreeContext,
+    folderTree,
-    selection: selectionContext,
+    selection,
-    mutations: documentMutations,
+    mutations,
-    managers: managers,
+    managers,
   };
 
   // hook callers handle rendering / routing
@@ -1169,7 +1091,7 @@ const useDocumentsWorkspace = ({
     appStatus,
     location,
     shellRef,
-    dropOverlayState,
+    dropOverlayState: upload.dropOverlayState,
     managementModals,
     contextValue,
     settingsOpen,

frontend/src/documents/data/useTags.ts

@@ -14,6 +14,7 @@ interface UseTagsOptions {
 
 interface UseTagsResult {
   tags: Tag[];
+  tagLookupById: Map<TagId, Tag>;
   refreshTags: () => Promise<void>;
   handleTagUpdate: (tagId: TagId, changes: { label?: string; color?: string | null }) => Promise<boolean>;
   handleTagCreate: (payload?: { label?: string; color?: string | null }) => Promise<void>;
@@ -130,6 +131,7 @@ const useTags = ({
 
   return {
     tags,
+    tagLookupById: tagsSnapshot,
     refreshTags,
     handleTagUpdate,
     handleTagCreate,