This commit is contained in:
2025-11-05 22:15:27 +01:00
parent a75281aa13
commit c193b30c8e
10 changed files with 213 additions and 205 deletions
+25 -38
View File
@@ -9,11 +9,9 @@ use rand::RngCore;
use uuid::Uuid; use uuid::Uuid;
use crate::{ use crate::{
auth::capability_sets::{ auth::capability_sets::{load_capabilities_for_set, load_capability_set},
ensure_capability_set, load_capabilities_for_set, normalize_capabilities,
},
error::AppError, error::AppError,
models::{ApiCapability, ApiToken, NewApiToken}, models::{ApiCapability, ApiToken, CapabilitySet, NewApiToken},
schema::api_tokens, schema::api_tokens,
state::PgPooledConnection, state::PgPooledConnection,
tenants::{apply_api_token_prefix, clear_api_token_prefix}, tenants::{apply_api_token_prefix, clear_api_token_prefix},
@@ -37,10 +35,9 @@ pub fn create_api_token(
tenant_id: Uuid, tenant_id: Uuid,
label: Option<String>, label: Option<String>,
expires_at: Option<NaiveDateTime>, expires_at: Option<NaiveDateTime>,
capabilities: Vec<ApiCapability>, capability_set_id: Uuid,
) -> Result<IssuedApiToken, AppError> { ) -> Result<IssuedApiToken, AppError> {
let capabilities = normalize_capabilities(capabilities)?; let capability_set = validate_capability_set_belongs_to_tenant(conn, capability_set_id, tenant_id)?;
let capability_set = ensure_capability_set(conn, tenant_id, &capabilities)?;
let raw_secret = generate_secret()?; let raw_secret = generate_secret()?;
let token_prefix = raw_secret[..TOKEN_PREFIX_LENGTH].to_string(); let token_prefix = raw_secret[..TOKEN_PREFIX_LENGTH].to_string();
@@ -120,40 +117,13 @@ pub fn regenerate_api_token(
}) })
} }
/// Updates the set of capabilities associated with an API token.
pub fn update_api_token_capabilities(
conn: &mut PgPooledConnection,
token_id: Uuid,
user_id: Uuid,
tenant_id: Option<Uuid>,
capabilities: Vec<ApiCapability>,
) -> Result<ApiToken, AppError> {
let capabilities = normalize_capabilities(capabilities)?;
let token = find_user_token(conn, token_id, user_id, tenant_id)?;
if token.revoked_at.is_some() {
return Err(AppError::bad_request(
"cannot modify capabilities of a revoked API token",
));
}
let capability_set = ensure_capability_set(conn, token.tenant_id, &capabilities)?;
let updated = diesel::update(api_tokens::table.find(token.id))
.set(api_tokens::capability_set_id.eq(capability_set.id))
.get_result::<ApiToken>(conn)?;
Ok(updated)
}
/// Attempts to resolve an API token by its secret value while ensuring it provides the /// Attempts to resolve an API token by its secret value while ensuring it provides the
/// requested capability. /// requested capability.
pub fn find_active_token_by_secret( pub fn find_active_token_by_secret(
conn: &mut PgPooledConnection, conn: &mut PgPooledConnection,
tenant_id: Option<Uuid>, tenant_id: Option<Uuid>,
secret: &str, secret: &str,
required_capability: ApiCapability, required_capability: Option<ApiCapability>,
) -> Result<Option<ApiToken>, AppError> { ) -> Result<Option<ApiToken>, AppError> {
if secret.len() < TOKEN_PREFIX_LENGTH { if secret.len() < TOKEN_PREFIX_LENGTH {
return Ok(None); return Ok(None);
@@ -181,9 +151,11 @@ pub fn find_active_token_by_secret(
})?; })?;
for token in candidates { for token in candidates {
let capabilities = load_capabilities_for_set(conn, token.capability_set_id)?; if let Some(required) = required_capability {
if !capabilities.contains(&required_capability) { let capabilities = load_capabilities_for_set(conn, token.capability_set_id)?;
continue; if !capabilities.contains(&required) {
continue;
}
} }
if verify_token_secret(secret, &token.token_hash)? { if verify_token_secret(secret, &token.token_hash)? {
@@ -247,6 +219,21 @@ fn find_user_token(
.ok_or_else(AppError::not_found) .ok_or_else(AppError::not_found)
} }
fn validate_capability_set_belongs_to_tenant(
conn: &mut PgPooledConnection,
capability_set_id: Uuid,
tenant_id: Uuid,
) -> Result<CapabilitySet, AppError> {
let capability_set = load_capability_set(conn, capability_set_id)?;
if capability_set.tenant_id != tenant_id {
return Err(AppError::bad_request(
"capability set does not belong to the tenant",
));
}
Ok(capability_set)
}
fn with_api_token_prefix<T, F>( fn with_api_token_prefix<T, F>(
conn: &mut PgPooledConnection, conn: &mut PgPooledConnection,
prefix: &str, prefix: &str,
-1
View File
@@ -101,7 +101,6 @@ pub mod schemas {
}; };
pub use crate::routes::profile::{ pub use crate::routes::profile::{
ApiTokenCreatedResponse, ApiTokenResponse, CreateApiTokenRequest, RevokePasskeyQuery, ApiTokenCreatedResponse, ApiTokenResponse, CreateApiTokenRequest, RevokePasskeyQuery,
UpdateApiTokenCapabilitiesRequest,
}; };
pub use crate::routes::tags::{CreateTagRequest, TagCatalogEntry, UpdateTagRequest}; pub use crate::routes::tags::{CreateTagRequest, TagCatalogEntry, UpdateTagRequest};
} }
+3 -3
View File
@@ -29,8 +29,8 @@ use crate::{
}, },
error::{AppError, AppResult}, error::{AppError, AppResult},
models::{ models::{
ApiCapability, MagicToken, MagicTokenKind, NewUser, NewUserSession, TenantStatus, User, MagicToken, MagicTokenKind, NewUser, NewUserSession, TenantStatus, User, UserMembership,
UserMembership, UserSession, UserSession,
}, },
schema::{ schema::{
magic_tokens::dsl as magic_dsl, tenants::dsl as tenant_dsl, magic_tokens::dsl as magic_dsl, tenants::dsl as tenant_dsl,
@@ -232,7 +232,7 @@ pub async fn api_token_exchange(
let mut conn = state.db_unscoped()?; let mut conn = state.db_unscoped()?;
let token = find_active_token_by_secret(&mut conn, None, secret, ApiCapability::ProfileRead)? let token = find_active_token_by_secret(&mut conn, None, secret, None)?
.ok_or_else(AppError::unauthorized)?; .ok_or_else(AppError::unauthorized)?;
let user: User = dsl::users.find(token.user_id).first(&mut conn)?; let user: User = dsl::users.find(token.user_id).first(&mut conn)?;
+18 -3
View File
@@ -23,8 +23,6 @@ use crate::{
pub struct CapabilitySetResponse { pub struct CapabilitySetResponse {
pub id: Uuid, pub id: Uuid,
pub slug: String, pub slug: String,
#[serde(default)]
pub label: Option<String>,
pub is_system: bool, pub is_system: bool,
pub cap_version: i32, pub cap_version: i32,
pub capabilities: Vec<ApiCapability>, pub capabilities: Vec<ApiCapability>,
@@ -81,7 +79,6 @@ fn to_response(set: CapabilitySet, capabilities: Vec<ApiCapability>) -> Capabili
CapabilitySetResponse { CapabilitySetResponse {
id: set.id, id: set.id,
slug: set.slug, slug: set.slug,
label: None,
is_system: set.is_system, is_system: set.is_system,
cap_version: set.cap_version, cap_version: set.cap_version,
capabilities, capabilities,
@@ -115,6 +112,22 @@ pub async fn list_capability_sets(
Ok(Json(responses)) Ok(Json(responses))
} }
#[utoipa::path(
get,
path = "/api/capabilities",
responses((status = 200, body = [ApiCapability])),
tag = "Capability Sets"
)]
pub async fn list_capabilities(
TenantScopedConn { .. }: TenantScopedConn,
) -> AppResult<Json<Vec<ApiCapability>>> {
let capabilities = ApiCapability::variants()
.iter()
.map(|value| value.parse::<ApiCapability>().expect("valid capability"))
.collect();
Ok(Json(capabilities))
}
#[utoipa::path( #[utoipa::path(
get, get,
path = "/api/capability-sets/{id}", path = "/api/capability-sets/{id}",
@@ -335,12 +348,14 @@ pub async fn delete_capability_set(
#[openapi( #[openapi(
paths( paths(
crate::routes::capability_sets::list_capability_sets, crate::routes::capability_sets::list_capability_sets,
crate::routes::capability_sets::list_capabilities,
crate::routes::capability_sets::get_capability_set, crate::routes::capability_sets::get_capability_set,
crate::routes::capability_sets::create_capability_set, crate::routes::capability_sets::create_capability_set,
crate::routes::capability_sets::update_capability_set, crate::routes::capability_sets::update_capability_set,
crate::routes::capability_sets::delete_capability_set, crate::routes::capability_sets::delete_capability_set,
), ),
components(schemas( components(schemas(
crate::models::ApiCapability,
crate::routes::capability_sets::CapabilitySetResponse, crate::routes::capability_sets::CapabilitySetResponse,
crate::routes::capability_sets::CreateCapabilitySetRequest, crate::routes::capability_sets::CreateCapabilitySetRequest,
crate::routes::capability_sets::UpdateCapabilitySetRequest, crate::routes::capability_sets::UpdateCapabilitySetRequest,
+8 -5
View File
@@ -305,11 +305,6 @@ pub fn create_router(state: AppState) -> Router<()> {
post(profile::regenerate_api_token) post(profile::regenerate_api_token)
.layer(RequireCapabilitiesLayer::all([ApiCapability::ProfileWrite])), .layer(RequireCapabilitiesLayer::all([ApiCapability::ProfileWrite])),
) )
.route(
"/api-tokens/:id",
patch(profile::update_api_token)
.layer(RequireCapabilitiesLayer::all([ApiCapability::ProfileWrite])),
)
.route( .route(
"/api-tokens/:id", "/api-tokens/:id",
delete(profile::delete_api_token) delete(profile::delete_api_token)
@@ -358,6 +353,13 @@ pub fn create_router(state: AppState) -> Router<()> {
])), ])),
); );
let capabilities_routes = Router::new().route(
"/",
get(capability_sets::list_capabilities).layer(RequireCapabilitiesLayer::all([
ApiCapability::CapabilitySetsRead,
])),
);
let protected_state = state.clone(); let protected_state = state.clone();
let assets_routes = Router::new().route( let assets_routes = Router::new().route(
"/:asset_id", "/:asset_id",
@@ -373,6 +375,7 @@ pub fn create_router(state: AppState) -> Router<()> {
.nest("/api/correspondents", correspondents_routes) .nest("/api/correspondents", correspondents_routes)
.nest("/api/profile", profile_routes) .nest("/api/profile", profile_routes)
.nest("/api/capability-sets", capability_sets_routes) .nest("/api/capability-sets", capability_sets_routes)
.nest("/api/capabilities", capabilities_routes)
.nest("/api/assets", assets_routes) .nest("/api/assets", assets_routes)
.layer(middleware::from_extractor_with_state::<AuthenticatedUser, _>(protected_state)); .layer(middleware::from_extractor_with_state::<AuthenticatedUser, _>(protected_state));
+27 -72
View File
@@ -12,14 +12,13 @@ use crate::auth::{
api_tokens::{ api_tokens::{
create_api_token as issue_token, list_api_tokens as load_tokens, create_api_token as issue_token, list_api_tokens as load_tokens,
regenerate_api_token as rotate_token, revoke_api_token as revoke_token, regenerate_api_token as rotate_token, revoke_api_token as revoke_token,
update_api_token_capabilities as update_capabilities,
}, },
capability_sets::load_capabilities_for_set, capability_sets::load_capability_set,
passkeys::PasskeySummary, passkeys::PasskeySummary,
TenantScopedConn, TenantScopedConn,
}; };
use crate::error::{AppError, AppResult}; use crate::error::{AppError, AppResult};
use crate::models::{ApiCapability, ApiToken}; use crate::models::ApiToken;
use crate::state::{AppState, PgPooledConnection}; use crate::state::{AppState, PgPooledConnection};
use crate::utils::{db::no_content, time::to_iso}; use crate::utils::{db::no_content, time::to_iso};
@@ -29,7 +28,7 @@ pub struct ApiTokenResponse {
pub tenant_id: Uuid, pub tenant_id: Uuid,
#[schema(nullable)] #[schema(nullable)]
pub label: Option<String>, pub label: Option<String>,
pub capabilities: Vec<ApiCapability>, pub capability_set_id: Uuid,
pub created_at: String, pub created_at: String,
#[schema(nullable)] #[schema(nullable)]
pub last_used_at: Option<String>, pub last_used_at: Option<String>,
@@ -51,14 +50,7 @@ pub struct CreateApiTokenRequest {
pub label: Option<String>, pub label: Option<String>,
#[schema(nullable)] #[schema(nullable)]
pub expires_at: Option<String>, pub expires_at: Option<String>,
#[serde(default)] pub capability_set_id: Uuid,
#[schema(nullable)]
pub capabilities: Option<Vec<ApiCapability>>,
}
#[derive(Debug, Deserialize, ToSchema)]
pub struct UpdateApiTokenCapabilitiesRequest {
pub capabilities: Vec<ApiCapability>,
} }
#[derive(Debug, Deserialize, ToSchema)] #[derive(Debug, Deserialize, ToSchema)]
@@ -104,10 +96,7 @@ pub async fn list_api_tokens(
}: TenantScopedConn, }: TenantScopedConn,
) -> AppResult<Json<Vec<ApiTokenResponse>>> { ) -> AppResult<Json<Vec<ApiTokenResponse>>> {
let tokens = load_tokens(&mut conn, user_id, Some(tenant_id))?; let tokens = load_tokens(&mut conn, user_id, Some(tenant_id))?;
let mut responses = Vec::with_capacity(tokens.len()); let responses = tokens.into_iter().map(api_token_to_response).collect();
for token in tokens {
responses.push(api_token_to_response(&mut conn, token)?);
}
Ok(Json(responses)) Ok(Json(responses))
} }
@@ -132,13 +121,7 @@ pub async fn create_api_token(
None => None, None => None,
}; };
let capabilities = payload let capability_set_id = validate_capability_set(&mut conn, tenant_id, payload.capability_set_id)?;
.capabilities
.ok_or_else(|| AppError::bad_request("at least one capability is required"))?;
if capabilities.is_empty() {
return Err(AppError::bad_request("at least one capability is required"));
}
let issued = issue_token( let issued = issue_token(
&mut conn, &mut conn,
@@ -146,10 +129,10 @@ pub async fn create_api_token(
tenant_id, tenant_id,
payload.label.clone(), payload.label.clone(),
expires_at, expires_at,
capabilities, capability_set_id,
)?; )?;
let token_info = api_token_to_response(&mut conn, issued.record)?; let token_info = api_token_to_response(issued.record);
let response = ApiTokenCreatedResponse { let response = ApiTokenCreatedResponse {
token: issued.token, token: issued.token,
@@ -176,7 +159,7 @@ pub async fn regenerate_api_token(
Path(token_id): Path<Uuid>, Path(token_id): Path<Uuid>,
) -> AppResult<Json<ApiTokenCreatedResponse>> { ) -> AppResult<Json<ApiTokenCreatedResponse>> {
let issued = rotate_token(&mut conn, token_id, user_id, Some(tenant_id))?; let issued = rotate_token(&mut conn, token_id, user_id, Some(tenant_id))?;
let token_info = api_token_to_response(&mut conn, issued.record)?; let token_info = api_token_to_response(issued.record);
let response = ApiTokenCreatedResponse { let response = ApiTokenCreatedResponse {
token: issued.token, token: issued.token,
token_info, token_info,
@@ -185,41 +168,6 @@ pub async fn regenerate_api_token(
Ok(Json(response)) Ok(Json(response))
} }
#[utoipa::path(
patch,
path = "/api/profile/api-tokens/{id}",
params(("id" = Uuid, Path, description = "API token ID")),
request_body = UpdateApiTokenCapabilitiesRequest,
responses((status = 200, description = "API token updated", body = ApiTokenResponse)),
tag = "Profile"
)]
pub async fn update_api_token(
TenantScopedConn {
mut conn,
tenant_id,
user_id,
..
}: TenantScopedConn,
Path(token_id): Path<Uuid>,
Json(payload): Json<UpdateApiTokenCapabilitiesRequest>,
) -> AppResult<Json<ApiTokenResponse>> {
if payload.capabilities.is_empty() {
return Err(AppError::bad_request("at least one capability is required"));
}
let updated = update_capabilities(
&mut conn,
token_id,
user_id,
Some(tenant_id),
payload.capabilities,
)?;
let response = api_token_to_response(&mut conn, updated)?;
Ok(Json(response))
}
#[utoipa::path( #[utoipa::path(
delete, delete,
path = "/api/profile/api-tokens/{id}", path = "/api/profile/api-tokens/{id}",
@@ -271,10 +219,7 @@ pub async fn delete_passkey(
no_content() no_content()
} }
fn api_token_to_response( fn api_token_to_response(token: ApiToken) -> ApiTokenResponse {
conn: &mut PgPooledConnection,
token: ApiToken,
) -> AppResult<ApiTokenResponse> {
let ApiToken { let ApiToken {
id, id,
tenant_id, tenant_id,
@@ -287,18 +232,16 @@ fn api_token_to_response(
.. ..
} = token; } = token;
let capabilities = load_capabilities_for_set(conn, capability_set_id)?; ApiTokenResponse {
Ok(ApiTokenResponse {
id, id,
tenant_id, tenant_id,
label, label,
capabilities, capability_set_id,
created_at: to_iso(created_at), created_at: to_iso(created_at),
last_used_at: last_used_at.map(to_iso), last_used_at: last_used_at.map(to_iso),
expires_at: expires_at.map(to_iso), expires_at: expires_at.map(to_iso),
revoked_at: revoked_at.map(to_iso), revoked_at: revoked_at.map(to_iso),
}) }
} }
fn parse_timestamp(value: &str) -> AppResult<NaiveDateTime> { fn parse_timestamp(value: &str) -> AppResult<NaiveDateTime> {
@@ -307,13 +250,26 @@ fn parse_timestamp(value: &str) -> AppResult<NaiveDateTime> {
Ok(dt.naive_utc()) Ok(dt.naive_utc())
} }
fn validate_capability_set(
conn: &mut PgPooledConnection,
tenant_id: Uuid,
capability_set_id: Uuid,
) -> AppResult<Uuid> {
let set = load_capability_set(conn, capability_set_id)?;
if set.tenant_id != tenant_id {
return Err(AppError::bad_request(
"capability set does not belong to the tenant",
));
}
Ok(set.id)
}
#[derive(utoipa::OpenApi)] #[derive(utoipa::OpenApi)]
#[openapi( #[openapi(
paths( paths(
crate::routes::profile::list_api_tokens, crate::routes::profile::list_api_tokens,
crate::routes::profile::create_api_token, crate::routes::profile::create_api_token,
crate::routes::profile::regenerate_api_token, crate::routes::profile::regenerate_api_token,
crate::routes::profile::update_api_token,
crate::routes::profile::delete_api_token, crate::routes::profile::delete_api_token,
crate::routes::profile::list_passkeys, crate::routes::profile::list_passkeys,
crate::routes::profile::delete_passkey crate::routes::profile::delete_passkey
@@ -323,7 +279,6 @@ fn parse_timestamp(value: &str) -> AppResult<NaiveDateTime> {
crate::routes::profile::ApiTokenResponse, crate::routes::profile::ApiTokenResponse,
crate::routes::profile::ApiTokenCreatedResponse, crate::routes::profile::ApiTokenCreatedResponse,
crate::routes::profile::CreateApiTokenRequest, crate::routes::profile::CreateApiTokenRequest,
crate::routes::profile::UpdateApiTokenCapabilitiesRequest,
crate::routes::profile::RevokePasskeyQuery, crate::routes::profile::RevokePasskeyQuery,
crate::auth::passkeys::PasskeySummary crate::auth::passkeys::PasskeySummary
)) ))
+1 -1
View File
@@ -438,7 +438,7 @@ fn authenticate(state: &AppState, headers: &HeaderMap) -> Result<Option<WebDavCo
&mut conn, &mut conn,
None, None,
secret, secret,
ApiCapability::WebdavRead, Some(ApiCapability::WebdavRead),
)? { )? {
Some(token) => token, Some(token) => token,
None => { None => {
+122 -81
View File
@@ -7,7 +7,7 @@ use base64::engine::general_purpose::STANDARD as BASE64;
use base64::Engine; use base64::Engine;
use common::{acquire_db_lock, body_to_vec, TestApp}; use common::{acquire_db_lock, body_to_vec, TestApp};
use diesel::prelude::*; use diesel::prelude::*;
use papercrate::models::{ApiCapability, ApiToken}; use papercrate::models::ApiToken;
use papercrate::routes::webdav; use papercrate::routes::webdav;
use papercrate::schema::api_tokens; use papercrate::schema::api_tokens;
use serde::Deserialize; use serde::Deserialize;
@@ -26,27 +26,8 @@ const LEGACY_WEBDAV_CAPS: &[&str] = &[
"webdav:read", "webdav:read",
]; ];
const OWNER_CAPS: &[&str] = &[ const READ_ONLY_CAPS: &[&str] = &["documents:read"];
"correspondents:edit", const LIMITED_WEBDAV_CAPS: &[&str] = &["documents:read", "webdav:read"];
"correspondents:read",
"correspondents:write",
"documents:edit",
"documents:read",
"documents:upload",
"documents:write",
"folders:edit",
"folders:read",
"folders:write",
"profile:read",
"profile:write",
"tags:edit",
"tags:read",
"tags:write",
"webdav:read",
"webdav:write",
"capability_sets:read",
"capability_sets:write",
];
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
struct TokenInfo { struct TokenInfo {
@@ -54,7 +35,7 @@ struct TokenInfo {
label: Option<String>, label: Option<String>,
last_used_at: Option<String>, last_used_at: Option<String>,
revoked_at: Option<String>, revoked_at: Option<String>,
capabilities: Vec<ApiCapability>, capability_set_id: Uuid,
} }
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
@@ -78,6 +59,12 @@ struct TenantView {
name: String, name: String,
} }
#[derive(Debug, Deserialize)]
struct CapabilitySetSummary {
id: Uuid,
slug: String,
}
#[tokio::test] #[tokio::test]
async fn api_token_crud_flow() -> Result<()> { async fn api_token_crud_flow() -> Result<()> {
let _guard = acquire_db_lock().await; let _guard = acquire_db_lock().await;
@@ -88,34 +75,30 @@ async fn api_token_crud_flow() -> Result<()> {
app.insert_user(username, password, "admin").await?; app.insert_user(username, password, "admin").await?;
let access_token = app.login_token(username, password).await?; let access_token = app.login_token(username, password).await?;
let created = create_token( let legacy_set_id = ensure_capability_set_slug(
&app, &app,
&access_token, &access_token,
json!({ "label": "dav", "capabilities": LEGACY_WEBDAV_CAPS }), "legacy_webdav",
LEGACY_WEBDAV_CAPS,
) )
.await?; .await?;
let created =
create_token(&app, &access_token, Some("dav"), legacy_set_id, None).await?;
let token_id = created.info.id; let token_id = created.info.id;
assert_eq!(created.info.label.as_deref(), Some("dav")); assert_eq!(created.info.label.as_deref(), Some("dav"));
assert!(created.info.last_used_at.is_none()); assert!(created.info.last_used_at.is_none());
assert_capabilities(&created.info.capabilities, LEGACY_WEBDAV_CAPS); assert_eq!(created.info.capability_set_id, legacy_set_id);
let regenerated = regenerate_token(&app, &access_token, token_id).await?; let regenerated = regenerate_token(&app, &access_token, token_id).await?;
assert_eq!(regenerated.info.id, token_id); assert_eq!(regenerated.info.id, token_id);
assert_ne!(regenerated.token, created.token); assert_ne!(regenerated.token, created.token);
assert!(regenerated.info.last_used_at.is_none()); assert!(regenerated.info.last_used_at.is_none());
let updated = update_token_capabilities(
&app,
&access_token,
token_id,
json!({ "capabilities": OWNER_CAPS }),
)
.await?;
assert_capabilities(&updated.capabilities, OWNER_CAPS);
let listed = list_tokens(&app, &access_token).await?; let listed = list_tokens(&app, &access_token).await?;
assert_eq!(listed.len(), 1); assert_eq!(listed.len(), 1);
assert_eq!(listed[0].id, token_id); assert_eq!(listed[0].id, token_id);
assert_eq!(listed[0].capability_set_id, legacy_set_id);
let tenant_id_for_token = app let tenant_id_for_token = app
.with_conn(move |conn| { .with_conn(move |conn| {
@@ -127,6 +110,20 @@ async fn api_token_crud_flow() -> Result<()> {
}) })
.await?; .await?;
let readonly_set_id = ensure_capability_set_slug(
&app,
&access_token,
"readonly",
READ_ONLY_CAPS,
)
.await?;
let readonly_token =
create_token(&app, &access_token, Some("readonly"), readonly_set_id, None).await?;
let readonly_exchange = exchange_token(&app, &readonly_token.token).await?;
assert_eq!(readonly_exchange.tenant.id, tenant_id_for_token);
delete_token(&app, &access_token, readonly_token.info.id).await?;
let exchange = exchange_token(&app, &regenerated.token).await?; let exchange = exchange_token(&app, &regenerated.token).await?;
assert_eq!(exchange.token_type, "Bearer"); assert_eq!(exchange.token_type, "Bearer");
assert!(!exchange.access_token.is_empty()); assert!(!exchange.access_token.is_empty());
@@ -155,12 +152,16 @@ async fn webdav_basic_auth_uses_api_tokens() -> Result<()> {
app.insert_user(username, password, "admin").await?; app.insert_user(username, password, "admin").await?;
let access_token = app.login_token(username, password).await?; let access_token = app.login_token(username, password).await?;
let created = create_token( let legacy_set_id = ensure_capability_set_slug(
&app, &app,
&access_token, &access_token,
json!({ "label": "webdav", "capabilities": LEGACY_WEBDAV_CAPS }), "legacy_webdav",
LEGACY_WEBDAV_CAPS,
) )
.await?; .await?;
let created =
create_token(&app, &access_token, Some("webdav"), legacy_set_id, None).await?;
let token_id = created.info.id; let token_id = created.info.id;
let router = webdav::create_router().with_state(app.state.clone()); let router = webdav::create_router().with_state(app.state.clone());
@@ -229,16 +230,18 @@ async fn webdav_basic_auth_uses_api_tokens() -> Result<()> {
assert_eq!(response.status(), StatusCode::MULTI_STATUS); assert_eq!(response.status(), StatusCode::MULTI_STATUS);
// Token without webdav_read cannot authenticate. // Token without webdav_read cannot authenticate.
let limited_token = create_token( let read_only_set_id = ensure_capability_set_slug(
&app, &app,
&access_token, &access_token,
json!({ "documents_read",
"label": "limited", READ_ONLY_CAPS,
"capabilities": ["documents:read"]
}),
) )
.await?; .await?;
let limited_token =
create_token(&app, &access_token, Some("limited"), read_only_set_id, None).await?;
assert_eq!(limited_token.info.capability_set_id, read_only_set_id);
let limited_header = format!( let limited_header = format!(
"Basic {}", "Basic {}",
BASE64.encode(format!("{}:{}", username, limited_token.token)) BASE64.encode(format!("{}:{}", username, limited_token.token))
@@ -253,20 +256,28 @@ async fn webdav_basic_auth_uses_api_tokens() -> Result<()> {
let limited_response = router.clone().oneshot(limited_request).await?; let limited_response = router.clone().oneshot(limited_request).await?;
assert_eq!(limited_response.status(), StatusCode::UNAUTHORIZED); assert_eq!(limited_response.status(), StatusCode::UNAUTHORIZED);
let _ = app let limited_set_id = ensure_capability_set_slug(
.patch_json( &app,
&format!("/api/profile/api-tokens/{}", limited_token.info.id), &access_token,
&json!({ "documents_read_webdav",
"capabilities": ["documents:read", "webdav:read"] LIMITED_WEBDAV_CAPS,
}), )
Some(&access_token), .await?;
)
.await?; let upgraded_token =
create_token(&app, &access_token, Some("limited-webdav"), limited_set_id, None).await?;
assert_eq!(upgraded_token.info.capability_set_id, limited_set_id);
let upgraded_request = Request::builder() let upgraded_request = Request::builder()
.method(propfind.clone()) .method(propfind.clone())
.uri("/") .uri("/")
.header(header::AUTHORIZATION, limited_header) .header(
header::AUTHORIZATION,
format!(
"Basic {}",
BASE64.encode(format!("{}:{}", username, upgraded_token.token))
),
)
.header("depth", "0") .header("depth", "0")
.body(Body::empty())?; .body(Body::empty())?;
let upgraded_response = router.clone().oneshot(upgraded_request).await?; let upgraded_response = router.clone().oneshot(upgraded_request).await?;
@@ -290,8 +301,22 @@ async fn webdav_basic_auth_uses_api_tokens() -> Result<()> {
async fn create_token( async fn create_token(
app: &TestApp, app: &TestApp,
access_token: &str, access_token: &str,
payload: serde_json::Value, label: Option<&str>,
capability_set_id: Uuid,
expires_at: Option<&str>,
) -> Result<CreateTokenResponse> { ) -> Result<CreateTokenResponse> {
let mut payload = json!({
"capability_set_id": capability_set_id,
});
if let Some(label) = label {
payload["label"] = json!(label);
}
if let Some(expires) = expires_at {
payload["expires_at"] = json!(expires);
}
let response = app let response = app
.post_json("/api/profile/api-tokens", &payload, Some(access_token)) .post_json("/api/profile/api-tokens", &payload, Some(access_token))
.await?; .await?;
@@ -317,24 +342,6 @@ async fn regenerate_token(
Ok(serde_json::from_slice(&body)?) Ok(serde_json::from_slice(&body)?)
} }
async fn update_token_capabilities(
app: &TestApp,
access_token: &str,
token_id: Uuid,
payload: serde_json::Value,
) -> Result<TokenInfo> {
let response = app
.patch_json(
&format!("/api/profile/api-tokens/{token_id}"),
&payload,
Some(access_token),
)
.await?;
assert_eq!(response.status(), StatusCode::OK);
let body = body_to_vec(response.into_body()).await?;
Ok(serde_json::from_slice(&body)?)
}
async fn list_tokens(app: &TestApp, access_token: &str) -> Result<Vec<TokenInfo>> { async fn list_tokens(app: &TestApp, access_token: &str) -> Result<Vec<TokenInfo>> {
let response = app let response = app
.get("/api/profile/api-tokens", Some(access_token)) .get("/api/profile/api-tokens", Some(access_token))
@@ -355,17 +362,51 @@ async fn delete_token(app: &TestApp, access_token: &str, token_id: Uuid) -> Resu
Ok(()) Ok(())
} }
fn assert_capabilities(actual: &[ApiCapability], expected: &[&str]) { async fn ensure_capability_set_slug(
assert_eq!(actual.len(), expected.len()); app: &TestApp,
for capability in expected { access_token: &str,
assert!( slug: &str,
actual capabilities: &[&str],
.iter() ) -> Result<Uuid> {
.any(|candidate| candidate.as_str() == *capability), if let Some(existing) = find_capability_set_slug(app, access_token, slug).await? {
"capability '{}' not present", return Ok(existing);
capability
);
} }
let response = app
.post_json(
"/api/capability-sets",
&json!({
"slug": slug,
"capabilities": capabilities,
}),
Some(access_token),
)
.await?;
assert_eq!(response.status(), StatusCode::CREATED);
let body = body_to_vec(response.into_body()).await?;
let summary: CapabilitySetSummary = serde_json::from_slice(&body)?;
Ok(summary.id)
}
async fn find_capability_set_slug(
app: &TestApp,
access_token: &str,
slug: &str,
) -> Result<Option<Uuid>> {
let sets = list_capability_sets(app, access_token).await?;
Ok(sets.into_iter().find(|set| set.slug == slug).map(|set| set.id))
}
async fn list_capability_sets(
app: &TestApp,
access_token: &str,
) -> Result<Vec<CapabilitySetSummary>> {
let response = app
.get("/api/capability-sets", Some(access_token))
.await?;
assert_eq!(response.status(), StatusCode::OK);
let body = body_to_vec(response.into_body()).await?;
Ok(serde_json::from_slice(&body)?)
} }
async fn exchange_token(app: &TestApp, api_token: &str) -> Result<LoginResponseView> { async fn exchange_token(app: &TestApp, api_token: &str) -> Result<LoginResponseView> {
let response = app let response = app
+8
View File
@@ -40,6 +40,14 @@ async fn capability_set_crud_flow() -> Result<()> {
assert!(sets.iter().any(|set| set.slug == "readonly")); assert!(sets.iter().any(|set| set.slug == "readonly"));
assert!(sets.iter().any(|set| set.slug == "webdav")); assert!(sets.iter().any(|set| set.slug == "webdav"));
let capabilities_resp = app.get("/api/capabilities", Some(&token)).await?;
assert_eq!(capabilities_resp.status(), StatusCode::OK);
let capabilities_body = body_to_vec(capabilities_resp.into_body()).await?;
let capabilities: Vec<String> = serde_json::from_slice(&capabilities_body)?;
assert!(capabilities.contains(&"documents:read".to_string()));
assert!(capabilities.contains(&"capability_sets:write".to_string()));
assert_eq!(capabilities.len(), 18);
// Create a new capability set. // Create a new capability set.
let create = app let create = app
.post_json( .post_json(
+1 -1
View File
@@ -91,7 +91,7 @@ curl -X DELETE \
## Assigning Sets ## Assigning Sets
- **User memberships**: change the `capability_set_id` column (via future admin APIs or direct SQL) to reassign a user. The authentication pipeline will enforce the new capabilities automatically. - **User memberships**: change the `capability_set_id` column (via future admin APIs or direct SQL) to reassign a user. The authentication pipeline will enforce the new capabilities automatically.
- **API tokens**: `PATCH /api/profile/api-tokens/{id}` accepts a capability array; underneath the token is mapped to the corresponding capability set. With the new endpoints, we can expose a `capability_set_id` field to limit tokens to specific bundles. - **API tokens**: `POST /api/profile/api-tokens` requires a `capability_set_id`. Tokens are bound to the selected set; raw capability arrays are no longer accepted.
## Guard Coverage ## Guard Coverage