refactor

frontend/src/hooks/documents/useDocumentMutations.ts

@@ -1,4 +1,5 @@
 import { useCallback } from 'react';
+import { isPlainObject } from '../../utils/typeGuards';
 import type { Dispatch, MutableRefObject, SetStateAction } from 'react';
 import { DEFAULT_FOLDER_NAME, getRowId, isDocumentRowKey } from '../../app/appLayoutUtils';
 
@@ -173,7 +174,7 @@ interface UseDocumentMutationsResult {
 
 const normalizeDocumentId = (value: unknown): DocumentId | null => {
   if (!value) return null;
-  if (typeof value === 'object' && value !== null && 'id' in value && value.id != null) {
+  if (isPlainObject(value) && 'id' in value && value.id != null) {
     return value.id as DocumentId;
   }
   return value as DocumentId;
@@ -562,8 +563,8 @@ const useDocumentMutations = ({
         }
         await api.post(`/documents/${document.id}/tags`, { tag_ids: [tag.id] });
         setStatusMessage('Tag assigned.', 'success');
-        if (input && typeof input === 'object') {
-          input.value = '';
+        if (input && Object(input) === input && 'value' in (input as Record<string, unknown>)) {
+          (input as { value?: string }).value = '';
         }
         await refreshCurrentFolder();
       } catch (error) {
@@ -582,12 +583,16 @@ const useDocumentMutations = ({
       const resolveTagForCache = (): Tag | null => {
         const lookupTag = tagLookupById.get(tagId);
         const source = lookupTag ?? tagData;
-        if (!source || source.id == null || typeof source.label?.trim !== 'function') {
+        if (!source || source.id == null) {
+          return null;
+        }
+        const labelText = `${source.label ?? ''}`.trim();
+        if (!labelText) {
           return null;
         }
         return {
           id: source.id,
-          label: source.label,
+          label: labelText,
           color: Object.prototype.hasOwnProperty.call(source, 'color') ? (source as Tag).color ?? null : null,
         };
       };