cleanup

frontend/src/hooks/documents/useFolderTreeActions.ts

@@ -35,7 +35,6 @@ interface EnsureFolderOptions {
 }
 
 interface LoadFolderOptions {
-  showLoading?: boolean;
   preserveSearch?: boolean;
 }
 
@@ -64,7 +63,6 @@ interface UseFolderTreeActionsOptions {
   applySelectedFolder: (folderId: FolderKey, contents: any) => void;
   notifyApiError: (error: unknown, message?: string) => void;
   setStatusMessage: (message: string, level?: string) => void;
-  setLoading: (value: boolean) => void;
   setFolderContents: (
     updater: (prev: Map<FolderKey, FolderContentsState>) => Map<FolderKey, FolderContentsState>,
   ) => void;
@@ -94,7 +92,6 @@ const useFolderTreeActions = ({
   applySelectedFolder,
   notifyApiError,
   setStatusMessage,
-  setLoading,
   setFolderContents,
   setCurrentFolder,
   setSearchResultIds,
@@ -211,12 +208,11 @@ const useFolderTreeActions = ({
   );
 
   const loadFolder = useCallback(
-    async (folderId: FolderKey | null, { showLoading = true, preserveSearch = false }: LoadFolderOptions = {}) => {
+    async (folderId: FolderKey | null, { preserveSearch = false }: LoadFolderOptions = {}) => {
       const targetId = folderId || 'root';
       setSelectedFolder(targetId);
       await ensureFolderAncestorsLoaded(targetId);
       expandFolderAncestors(targetId);
-      if (showLoading) setLoading(true);
       try {
         const contents = await ensureFolderData(targetId, { force: true, prefetchDepth: 1 });
         if (targetId !== 'root') {
@@ -236,8 +232,6 @@ const useFolderTreeActions = ({
         }
       } catch (error) {
         notifyApiError(error, 'Failed to load folder contents.');
-      } finally {
-        if (showLoading) setLoading(false);
       }
     },
     [
@@ -246,7 +240,6 @@ const useFolderTreeActions = ({
       ensureFolderData,
       expandFolderAncestors,
       notifyApiError,
-      setLoading,
       setSearchResultIds,
       setSelectedFolder,
     ],
@@ -289,8 +282,6 @@ const useFolderTreeActions = ({
         setStatusMessage('Folder name cannot be empty.', 'error');
         return false;
       }
-
-      setLoading(true);
       try {
         await renameFolderRequest(folderId, trimmed);
 
@@ -323,8 +314,6 @@ const useFolderTreeActions = ({
         const message = error.response?.data?.error || 'Failed to rename folder.';
         notifyApiError(error, message);
         return false;
-      } finally {
-        setLoading(false);
       }
     },
     [
@@ -332,7 +321,6 @@ const useFolderTreeActions = ({
       setCurrentFolder,
       setFolderContents,
       setFolderNodes,
-      setLoading,
       setStatusMessage,
       token,
     ],
@@ -412,7 +400,7 @@ const useFolderTreeActions = ({
   );
 
   const handleFolderDelete = useCallback(
-    async (folderId: FolderKey, { showMessage = true, manageLoading = true }: { showMessage?: boolean; manageLoading?: boolean } = {}) => {
+    async (folderId: FolderKey, { showMessage = true }: { showMessage?: boolean } = {}) => {
       if (!token) {
         if (showMessage) {
           setStatusMessage('Log in to manage folders.', 'error');
@@ -426,10 +414,6 @@ const useFolderTreeActions = ({
         return false;
       }
 
-      if (manageLoading) {
-        setLoading(true);
-      }
-
       try {
         const contents = await ensureFolderData(folderId, {
           force: true,
@@ -495,10 +479,6 @@ const useFolderTreeActions = ({
           setStatusMessage(message, 'error');
         }
         return false;
-      } finally {
-        if (manageLoading) {
-          setLoading(false);
-        }
       }
     },
     [
@@ -510,7 +490,6 @@ const useFolderTreeActions = ({
       selectedFolder,
       setFolderContents,
       setFolderNodes,
-      setLoading,
       setSelectedFolder,
       setStatusMessage,
     ],