feat: Refactor folder tree management to use FoldersManager and remove onToggle functionality

frontend/src/documents/features/folders/useFolderTreeActions.ts

@@ -30,9 +30,7 @@ interface FolderContentsState {
 }
 
 interface EnsureFolderOptions {
-  force?: boolean;
   includeDocuments?: boolean;
-  prefetchDepth?: number;
 }
 
 interface LoadFolderOptions {
@@ -45,7 +43,6 @@ interface SelectFolderOptions {
 }
 
 interface FolderClickHandlers {
-  onToggle: (folderId: FolderKey) => Promise<void>;
   onSelect: (folderId: FolderKey, options?: SelectFolderOptions) => Promise<void>;
   onDrop: (event: DragEvent<HTMLElement>, folderId: FolderKey) => Promise<void>;
   onDragOver: (event: DragEvent<HTMLElement>, folderId: FolderKey) => void;
@@ -59,8 +56,6 @@ interface UseFolderTreeActionsOptions {
   selectedFolder: FolderKey;
   setSelectedFolder: (folderId: FolderKey) => void;
   ensureFolderData: (folderId: FolderKey, options?: EnsureFolderOptions) => Promise<any>;
-  ensureFolderAncestorsLoaded: (folderId: FolderKey) => Promise<void>;
-  expandFolderAncestors: (folderId: FolderKey, options?: { includeSelf?: boolean }) => void;
   applySelectedFolder: (folderId: FolderKey, contents: any) => void;
   notifyApiError: (error: unknown, message?: string) => void;
   setStatusMessage: (message: string, level?: string) => void;
@@ -88,8 +83,6 @@ const useFolderTreeActions = ({
   selectedFolder,
   setSelectedFolder,
   ensureFolderData,
-  ensureFolderAncestorsLoaded,
-  expandFolderAncestors,
   applySelectedFolder,
   notifyApiError,
   setStatusMessage,
@@ -175,12 +168,12 @@ const useFolderTreeActions = ({
         const refreshTargets = new Set([previousParentKey, targetKey]);
         await Promise.all(
           Array.from(refreshTargets).map((key) =>
-            ensureFolderData(key === 'root' ? 'root' : key, { force: true, prefetchDepth: 1 }),
+            ensureFolderData(key),
           ),
         );
 
         if (selectedFolder === folderId) {
-          await ensureFolderData(folderId, { force: true, prefetchDepth: 1 });
+          await ensureFolderData(folderId);
           setSelectedFolder(folderId);
         }
 
@@ -192,7 +185,7 @@ const useFolderTreeActions = ({
         const refreshTargets = new Set([previousParentKey, targetKey]);
         await Promise.all(
           Array.from(refreshTargets).map((key) =>
-            ensureFolderData(key === 'root' ? 'root' : key, { force: true, prefetchDepth: 1 }),
+            ensureFolderData(key),
           ),
         );
       }
@@ -212,16 +205,12 @@ const useFolderTreeActions = ({
     async (folderId: FolderKey | null, { preserveSearch = false }: LoadFolderOptions = {}) => {
       const targetId = folderId || 'root';
       setSelectedFolder(targetId);
-      await ensureFolderAncestorsLoaded(targetId);
-      expandFolderAncestors(targetId);
       try {
-        const contents = await ensureFolderData(targetId, { force: true, prefetchDepth: 1 });
+        const contents = await ensureFolderData(targetId);
         if (targetId !== 'root') {
           try {
             await ensureFolderData('root', {
-              force: false,
               includeDocuments: false,
-              prefetchDepth: 1,
             });
           } catch (error) {
             console.warn('Failed to refresh root folder tree', error);
@@ -237,9 +226,7 @@ const useFolderTreeActions = ({
     },
     [
       applySelectedFolder,
-      ensureFolderAncestorsLoaded,
       ensureFolderData,
-      expandFolderAncestors,
       notifyApiError,
       setSearchResultIds,
       setSelectedFolder,
@@ -250,9 +237,6 @@ const useFolderTreeActions = ({
     async (folderId: FolderKey | null, { replace = false, immediate = false }: SelectFolderOptions = {}) => {
       const targetId = folderId && folderId !== 'root' ? folderId : 'root';
 
-      await ensureFolderAncestorsLoaded(targetId);
-      expandFolderAncestors(targetId);
-
       if (!navigate || immediate) {
         await loadFolder(targetId, { preserveSearch: isFilterActive });
         setSelectedFolder(targetId);
@@ -263,8 +247,6 @@ const useFolderTreeActions = ({
       navigate(path, { replace });
     },
     [
-      ensureFolderAncestorsLoaded,
-      expandFolderAncestors,
       isFilterActive,
       loadFolder,
       navigate,
@@ -381,7 +363,7 @@ const useFolderTreeActions = ({
 
         // Refresh the parent folder to ensure consistency
         const refreshTarget = targetParentId || 'root';
-        await ensureFolderData(refreshTarget, { force: true, prefetchDepth: 1 });
+        await ensureFolderData(refreshTarget);
 
         await selectFolder(folderData.id, { immediate: true });
         succeeded = true;
@@ -425,10 +407,7 @@ const useFolderTreeActions = ({
       }
 
       try {
-        const contents = await ensureFolderData(folderId, {
-          force: true,
-          prefetchDepth: 1,
-        });
+        const contents = await ensureFolderData(folderId);
         const hasChildren = (contents.subfolders || []).length > 0;
         const hasDocs = (contents.documents || []).length > 0;
         if (hasChildren || hasDocs) {
@@ -469,13 +448,10 @@ const useFolderTreeActions = ({
           const node = folderNodes.get(folderId);
           const parentId = node?.parentId || 'root';
           setSelectedFolder(parentId);
-          const parentContents = await ensureFolderData(parentId, {
-            force: true,
-            prefetchDepth: 1,
-          });
+          const parentContents = await ensureFolderData(parentId);
           applySelectedFolder(parentId, parentContents);
         } else if (selectedFolder !== 'root') {
-          await ensureFolderData(selectedFolder, { force: true, prefetchDepth: 1 });
+          await ensureFolderData(selectedFolder);
         }
 
         if (showMessage) {
@@ -507,36 +483,6 @@ const useFolderTreeActions = ({
 
   const folderClickHandlers: FolderClickHandlers = useMemo(
     () => ({
-      onToggle: async (folderId: FolderKey) => {
-        const node = folderNodes.get(folderId);
-        const nextExpanded = !(node?.expanded ?? false);
-        if (nextExpanded) {
-          try {
-            await ensureFolderData(folderId, {
-              includeDocuments: false,
-              prefetchDepth: 1,
-            });
-          } catch (error) {
-            notifyApiError(error, 'Failed to load folder.');
-          }
-        } else if (node && !node.loaded) {
-          try {
-            await ensureFolderData(folderId, {
-              includeDocuments: false,
-              prefetchDepth: 1,
-            });
-          } catch (error) {
-            notifyApiError(error, 'Failed to load folder.');
-          }
-        }
-        setFolderNodes((prev) => {
-          const next = new Map(prev);
-          const current = next.get(folderId);
-          if (!current) return prev;
-          next.set(folderId, { ...current, expanded: nextExpanded });
-          return next;
-        });
-      },
       onSelect: selectFolder,
       onDrop: async (event: DragEvent<HTMLElement>, folderId: FolderKey) => {
         event.preventDefault();
@@ -659,18 +605,14 @@ const useFolderTreeActions = ({
     [
       draggedDocumentIds,
       draggedFolderId,
-      ensureFolderData,
-      folderNodes,
       handleFileDrop,
       isInvalidFolderDrop,
       moveDocumentsToFolder,
       moveFolder,
-      notifyApiError,
       selectFolder,
       selectedFolder,
       setDraggedDocumentIds,
       setDraggedFolderId,
-      setFolderNodes,
       setStatusMessage,
     ],
   );