stuff

frontend/src/app/AppLayout.jsx

@@ -371,7 +371,7 @@ const AppLayout = () => {
     setFocusedRowKey,
     applySelection,
     clearSelection: clearSelectionInternal,
-    handleRowSelection: handleRowSelectionInternal,
+    handleEntrySelection: handleEntrySelectionInternal,
     promoteSelectionOrder: promoteSelectionOrderInternal,
     configureSelectionEnvironment,
   } = useDocumentSelection({
@@ -784,44 +784,6 @@ const AppLayout = () => {
     [mapDocumentCaches],
   );
 
-  const removeDocumentFromCaches = useCallback(
-    (documentId) => {
-      if (!documentId) {
-        return;
-      }
-
-      const removeFromList = (list) => {
-        const next = list.filter((doc) => doc.id !== documentId);
-        return next.length === list.length ? list : next;
-      };
-
-      setDocuments((prev) => removeFromList(prev));
-      setSearchResults((prev) => (Array.isArray(prev) ? removeFromList(prev) : prev));
-      setFolderContents((prev) => {
-        if (!prev.size) {
-          return prev;
-        }
-        let changed = false;
-        const next = new Map();
-        prev.forEach((contents, key) => {
-          const docs = Array.isArray(contents?.documents) ? contents.documents : null;
-          if (!docs || docs.length === 0) {
-            next.set(key, contents);
-            return;
-          }
-          const filteredDocs = docs.filter((doc) => doc.id !== documentId);
-          if (filteredDocs.length !== docs.length) {
-            changed = true;
-            next.set(key, { ...contents, documents: filteredDocs });
-          } else {
-            next.set(key, contents);
-          }
-        });
-        return changed ? next : prev;
-      });
-    },
-    [setDocuments, setSearchResults, setFolderContents],
-  );
 
 
   const folderOptions = useMemo(() => {
@@ -900,11 +862,11 @@ const AppLayout = () => {
     });
   }, [configureSelectionEnvironment, visibleRowKeySet, navigableRowKeys]);
 
-  const handleRowSelection = useCallback(
+  const handleEntrySelection = useCallback(
     (rowKey, event) => {
-      handleRowSelectionInternal(rowKey, event);
+      handleEntrySelectionInternal(rowKey, event);
     },
-    [handleRowSelectionInternal],
+    [handleEntrySelectionInternal],
   );
 
   const promoteSelectionOrder = useCallback(
@@ -2462,7 +2424,7 @@ const AppLayout = () => {
       if (!isAlreadySelected && folderKey) {
         effectiveFolderSelection = [folderId];
         effectiveDocumentSelection = [];
-        handleRowSelection(folderKey, { preventDefault: () => {} });
+        handleEntrySelection(folderKey, { preventDefault: () => {} });
       }
 
       const uniqueFolders = effectiveFolderSelection.length
@@ -2513,7 +2475,7 @@ const AppLayout = () => {
       selectedDocumentIds,
       setDraggedFolderId,
       setDraggedDocumentIds,
-      handleRowSelection,
+      handleEntrySelection,
       documentLookup,
       createDragPreview,
     ],
@@ -3150,7 +3112,7 @@ const AppLayout = () => {
         if (!row) {
           return;
         }
-        handleRowSelection(row.key, event);
+        handleEntrySelection(row.key, event);
         if (row.type === 'folder') {
           selectFolder(row.id);
         } else if (row.type === 'document') {
@@ -3163,7 +3125,7 @@ const AppLayout = () => {
 
       if (key === 'ArrowDown') {
         if (initializedFromEmptyState && selectedEntries.length === 0) {
-          handleRowSelection(activeKey, {
+          handleEntrySelection(activeKey, {
             shiftKey,
             preventDefault: () => {},
           });
@@ -3172,7 +3134,7 @@ const AppLayout = () => {
         nextIndex = currentIndex === -1 ? 0 : Math.min(currentIndex + 1, navigableRows.length - 1);
       } else if (key === 'ArrowUp') {
         if (initializedFromEmptyState && selectedEntries.length === 0) {
-          handleRowSelection(activeKey, {
+          handleEntrySelection(activeKey, {
             shiftKey,
             preventDefault: () => {},
           });
@@ -3200,7 +3162,7 @@ const AppLayout = () => {
 
       setFocusedRowKey(targetRow.key);
 
-      handleRowSelection(targetRow.key, {
+      handleEntrySelection(targetRow.key, {
         shiftKey,
         preventDefault: () => {},
       });
@@ -3210,7 +3172,7 @@ const AppLayout = () => {
       navigableRowKeys,
       focusedRowKey,
       selectedEntries,
-      handleRowSelection,
+      handleEntrySelection,
       selectFolder,
       openDocumentPreview,
       setFocusedRowKey,
@@ -4163,76 +4125,6 @@ const AppLayout = () => {
     return list.find((doc) => doc.id === focusedDocumentId) || null;
   }, [searchResults, documents, focusedDocumentId]);
 
-  const handleDocumentDelete = useCallback(
-    async (documentId) => {
-      if (!documentId) return;
-      if (!token) {
-        setStatusMessage('Log in to manage documents.', 'error');
-        return;
-      }
-
-      const doc = documentLookup.get(documentId) || null;
-      const label = doc?.title;
-
-      const confirmed = window.confirm(`Move "${label}" to trash? You can restore it from trash later.`);
-      if (!confirmed) {
-        return;
-      }
-
-      setLoading(true);
-      try {
-        await api.delete(`/documents/${documentId}`);
-
-        removeDocumentFromCaches(documentId);
-
-        setPreviewEntries((prev) => {
-          if (!prev.has(documentId)) {
-            return prev;
-          }
-          const next = new Map(prev);
-          next.delete(documentId);
-          return next;
-        });
-        previewInflightRef.current.delete(documentId);
-
-        if (selectedDocumentIds.includes(documentId)) {
-          const remainingRowKeys = selectedDocumentIds
-            .filter((id) => id !== documentId)
-            .map((id) => resolveDocumentRowKey(id))
-            .filter(Boolean);
-          const removedKey = resolveDocumentRowKey(documentId);
-          applySelection(remainingRowKeys, {
-            anchor: null,
-            interactedKeys: removedKey ? [removedKey] : [],
-          });
-        }
-
-        if (previewDocumentId === documentId) {
-          closeDocumentPreview();
-        }
-
-        setStatusMessage('Document deleted.', 'success');
-      } catch (error) {
-        const message = error.response?.data?.error || 'Failed to delete document.';
-        notifyApiError(error, message);
-      } finally {
-        setLoading(false);
-      }
-    },
-    [
-      token,
-      documentLookup,
-      setStatusMessage,
-      removeDocumentFromCaches,
-      setPreviewEntries,
-      previewInflightRef,
-      previewDocumentId,
-      closeDocumentPreview,
-      selectedDocumentIds,
-      applySelection,
-      notifyApiError,
-    ],
-  );
 
   const orderedSelectedDocuments = useMemo(() => {
     const ordered = [];
@@ -4591,10 +4483,8 @@ const AppLayout = () => {
       onFolderDragStart: handleFolderDragStart,
       onFolderDragEnd: handleFolderDragEnd,
       draggedFolderId,
-      onFolderDelete: handleFolderDelete,
       onFolderRename: handleFolderRename,
       onDocumentOpen: openDocumentPreview,
-      onDocumentDelete: handleDocumentDelete,
       onDocumentRename: handleDocumentTitleUpdate,
       selectedDocumentIds,
       selectedFolderIds,
@@ -4610,17 +4500,13 @@ const AppLayout = () => {
       onFocusedRowChange: setFocusedRowKey,
       ensureAssetUrl,
       getDocumentAsset,
-      getDownloadHref: (doc) =>
-        doc?.current_version?.download_path
-          ? resolveApiPath(doc.current_version.download_path)
-          : null,
       onTagClick: toggleTagFilter,
       onCorrespondentClick: toggleCorrespondentFilter,
       onDocumentTagDrop: handleDocumentTagDrop,
       viewMode: documentsViewMode,
       onViewModeChange: handleDocumentsViewModeChange,
       onClearSelection: clearDocumentSelection,
-      onRowSelection: handleRowSelection,
+      onEntrySelection: handleEntrySelection,
       onOpenDetailPanel: openDetailPanel,
     }),
     [
@@ -4635,7 +4521,6 @@ const AppLayout = () => {
       draggedFolderId,
       focusedRowKey,
       folderClickHandlers,
-      handleDocumentDelete,
       handleDocumentDragEnd,
       handleDocumentDragStart,
       handleDocumentListFocus,
@@ -4643,11 +4528,10 @@ const AppLayout = () => {
       handleDocumentTagDrop,
       handleDocumentTitleUpdate,
       handleDocumentsViewModeChange,
-      handleFolderDelete,
       handleFolderDragEnd,
       handleFolderDragStart,
       handleFolderRename,
-      handleRowSelection,
+      handleEntrySelection,
       isFilterActive,
       openDetailPanel,
       openDocumentPreview,
@@ -4715,9 +4599,9 @@ const AppLayout = () => {
       currentTenantId,
       folderClickHandlers,
       folderNodes,
-      handleFolderDelete,
       handleFolderDragEnd,
       handleFolderDragStart,
+      handleFolderDelete,
       handleFolderRename,
       handleLogout,
       handleSearchChange,
@@ -4830,9 +4714,9 @@ const AppLayout = () => {
       if (!rowKey) {
         return;
       }
-      handleRowSelection(rowKey, event);
+      handleEntrySelection(rowKey, event);
     },
-    [handleRowSelection],
+    [handleEntrySelection],
   );
 
   const handleDeskDocumentStackSelect = useCallback(

frontend/src/app/useDocumentSelection.js

@@ -143,7 +143,7 @@ export const useDocumentSelection = ({
     applySelection([], { anchor: null, interactedKeys: [] });
   }, [applySelection]);
 
-  const handleRowSelection = useCallback(
+  const handleEntrySelection = useCallback(
     (rowKey, event) => {
       const visibleRowKeySet = visibleRowKeySetRef.current;
       const navigableRowKeys = navigableRowKeysRef.current;
@@ -241,7 +241,7 @@ export const useDocumentSelection = ({
     setFocusedRowKey,
     applySelection,
     clearSelection,
-    handleRowSelection,
+    handleEntrySelection,
     promoteSelectionOrder,
     configureSelectionEnvironment,
   };