refactor

frontend/src/documents/DocumentSummarySection.jsx

@@ -2,50 +2,13 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { EditIcon, IconX, PlusIcon } from '../ui/icons';
 import QuickAddMenu from '../ui/QuickAddMenu';
 import { getTagColorStyle } from '../utils/colors';
+import {
+  formatDate,
+  toDateInputValue,
+  toIssuedTimestamp,
+} from '../utils/date';
 import { describeDocumentSummary } from './documentSummary';
 
-const formatDate = (value) => {
-  if (!value) {
-    return null;
-  }
-  const date = new Date(value);
-  if (Number.isNaN(date.getTime())) {
-    return null;
-  }
-  return date.toLocaleDateString();
-};
-
-const toDateInputValue = (value) => {
-  if (!value) {
-    return '';
-  }
-  const date = new Date(value);
-  if (Number.isNaN(date.getTime())) {
-    return '';
-  }
-  const timezoneOffset = date.getTimezoneOffset();
-  const localDate = new Date(date.getTime() - timezoneOffset * 60000);
-  return localDate.toISOString().slice(0, 10);
-};
-
-const toIssuedTimestamp = (dateString, fallback) => {
-  if (!dateString) {
-    return null;
-  }
-  const base = fallback ? new Date(fallback) : new Date();
-  if (Number.isNaN(base.getTime())) {
-    return null;
-  }
-  const [year, month, day] = dateString.split('-').map((part) => Number.parseInt(part, 10));
-  if (!year || !month || !day) {
-    return null;
-  }
-
-  const candidate = new Date(base);
-  candidate.setUTCFullYear(year, month - 1, day);
-  return candidate.toISOString();
-};
-
 export const sortCorrespondents = (entries = []) =>
   entries
     .filter((entry) => entry && entry.name)
@@ -257,7 +220,10 @@ const DocumentSummarySection = ({
     }
     return describeDocumentSummary(document);
   }, [document]);
-  const issuedDateLabel = useMemo(() => formatDate(document?.issued_at), [document?.issued_at]);
+  const issuedDateLabel = useMemo(
+    () => formatDate(document?.issued_at, { fallback: null }),
+    [document?.issued_at],
+  );
 
   const editableTitle = Boolean(document && onUpdateTitle);
   const editableIssued = Boolean(document && onUpdateIssued);

frontend/src/documents/DocumentsList.jsx

@@ -1,23 +1,13 @@
 import React from 'react';
 import { FolderIcon, CheckIcon, CloseIcon } from '../ui/icons';
 import { getTagColorStyle } from '../utils/colors';
+import { formatDate } from '../utils/date';
 import DocumentThumbnailImage from './DocumentThumbnailImage';
 import CorrespondentLinks from './CorrespondentLinks';
 import { resolveCorrespondents } from './correspondents';
 import { writeTagTransferData } from './tagTransfer';
 import useInlineRename from './useInlineRename';
 
-const formatDate = (value) => {
-  if (!value) {
-    return "—";
-  }
-  const timestamp = Date.parse(value);
-  if (Number.isNaN(timestamp)) {
-    return "—";
-  }
-  return new Date(timestamp).toLocaleDateString();
-};
-
 const DocumentsList = ({
   entries,
   focusedRowKey,

frontend/src/documents/documentMetadata.js

@@ -1,10 +1,4 @@
-const formatDateTime = (value) => {
-  if (!value) {
-    return '—';
-  }
-  const date = new Date(value);
-  return Number.isNaN(date.getTime()) ? '—' : date.toLocaleString();
-};
+import { formatDateTime } from '../utils/date';
 
 export const buildDocumentMetadataItems = (document) => {
   if (!document) {

frontend/src/documents/documentSummary.js

@@ -1,15 +1,5 @@
 import { formatFileSize } from '../utils/format';
-
-const defaultFormatDateTime = (value) => {
-  if (!value) {
-    return '—';
-  }
-  const date = new Date(value);
-  if (Number.isNaN(date.getTime())) {
-    return '—';
-  }
-  return date.toLocaleString();
-};
+import { formatDateTime as defaultFormatDateTime } from '../utils/date';
 
 const coercePageCount = (metadata) => {
   const raw = metadata?.page_count;

frontend/src/documents/useEntryPointer.js

@@ -14,11 +14,12 @@ export const isPrimaryPointerEvent = (event) => {
   return type === 'click' || type === 'pointerdown' || type === 'pointerup';
 };
 
-export const useEntryPointerHandler = ({
+export const useEntryPointer = ({
   resolveDocumentRowKey,
   resolveFolderRowKey,
   onSelectDocument,
   onSelectFolder,
+  onInspectDocument,
 }) =>
   useCallback(
     (entry, event) => {
@@ -39,16 +40,20 @@ export const useEntryPointerHandler = ({
 
       const modifierClick = isPointerModifierEvent(event);
       const primaryClick = isPrimaryPointerEvent(event);
+      const metadata = { modifierClick, primaryClick, rowKey };
 
       if (type === 'document') {
         if (typeof onSelectDocument === 'function') {
-          onSelectDocument(id, event, { modifierClick, primaryClick, rowKey });
+          onSelectDocument(id, event, metadata);
+        }
+        if (!modifierClick && primaryClick && typeof onInspectDocument === 'function') {
+          onInspectDocument(id, metadata);
         }
         return;
       }
 
       if (typeof onSelectFolder === 'function') {
-        onSelectFolder(id, event, { modifierClick, primaryClick, rowKey });
+        onSelectFolder(id, event, metadata);
       }
     },
     [
@@ -56,7 +61,8 @@ export const useEntryPointerHandler = ({
       resolveFolderRowKey,
       onSelectDocument,
       onSelectFolder,
+      onInspectDocument,
     ],
   );
 
-export default useEntryPointerHandler;
+export default useEntryPointer;