fix deletion
This commit is contained in:
@@ -1868,16 +1868,13 @@ void MessageMap::remove(Message* message) {
|
|||||||
uint64_t key = message->getKey();
|
uint64_t key = message->getKey();
|
||||||
bool conditional = message->isConditional();
|
bool conditional = message->isConditional();
|
||||||
const auto keyIt = m_messagesByKey.find(key);
|
const auto keyIt = m_messagesByKey.find(key);
|
||||||
bool deleted = false;
|
bool needDelete = false;
|
||||||
if (keyIt != m_messagesByKey.end()) {
|
if (keyIt != m_messagesByKey.end()) {
|
||||||
vector<Message*>* messages = &keyIt->second;
|
vector<Message*>* messages = &keyIt->second;
|
||||||
for (auto it = messages->begin(); it != messages->end(); ) {
|
for (auto it = messages->begin(); it != messages->end(); ) {
|
||||||
Message* other = *it;
|
Message* other = *it;
|
||||||
if (other == message) {
|
if (other == message) {
|
||||||
if (!deleted) {
|
needDelete = true;
|
||||||
deleted = true;
|
|
||||||
delete(other);
|
|
||||||
}
|
|
||||||
it = messages->erase(it);
|
it = messages->erase(it);
|
||||||
} else {
|
} else {
|
||||||
++it;
|
++it;
|
||||||
@@ -1894,10 +1891,7 @@ void MessageMap::remove(Message* message) {
|
|||||||
Message* other = *it;
|
Message* other = *it;
|
||||||
if (other == message) {
|
if (other == message) {
|
||||||
storedByName = true;
|
storedByName = true;
|
||||||
if (!deleted) {
|
needDelete = true;
|
||||||
deleted = true;
|
|
||||||
delete(other);
|
|
||||||
}
|
|
||||||
it = messages->erase(it);
|
it = messages->erase(it);
|
||||||
} else {
|
} else {
|
||||||
++it;
|
++it;
|
||||||
@@ -1922,6 +1916,9 @@ void MessageMap::remove(Message* message) {
|
|||||||
if (message->getPollPriority() > 0) {
|
if (message->getPollPriority() > 0) {
|
||||||
m_pollMessages.remove(message);
|
m_pollMessages.remove(message);
|
||||||
}
|
}
|
||||||
|
if (needDelete) {
|
||||||
|
delete message;
|
||||||
|
}
|
||||||
unlock();
|
unlock();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user